mirror of
https://github.com/apple/swift.git
synced 2025-12-21 12:14:44 +01:00
28d7f8813c
Currently, ModuleFileSharedCore::fatal() calls abort(), which may be reasonable in a swift-frontend invocation, but has dire consequences when the Swift frontend is embedded into another process, for example, LLDB where the abort() kills the entire debugging session. This patch introduces a few alternatives to the ModuleFile::fatal() familiy of functions that instead push a fatal diagnostic to the ASTContext's DiagnosticsEngine and return an llvm::Error so the error can be roperly communicated and the ASTContext can be wound down without killing the parent process. The transition is not complete, this patch does not yet handle fatalIfUnexpected(), for example. This patch is NFC for the Swift compiler: When DebuggerSupport in off ModuleFile::diagnoseFatal() will still call abort(), but if it is on, the error will be passed up, together with a pretty stack trace. rdar://64511878
29 lines
1.9 KiB
Swift
29 lines
1.9 KiB
Swift
// RUN: %empty-directory(%t)
|
|
// RUN: %target-swift-frontend -emit-module -o %t -module-name Lib -I %S/Inputs/custom-modules -swift-version 4 %s
|
|
|
|
// RUN: echo 'import Lib; _ = Sub.disappearingMethod' | not --crash %target-swift-frontend -typecheck -I %t -I %S/Inputs/custom-modules -swift-version 4 -disable-deserialization-recovery -Xcc -DBAD - 2>&1 | %FileCheck -check-prefix CHECK-CRASH -check-prefix CHECK-CRASH-4 %s
|
|
// RUN: echo 'import Lib; _ = Sub.disappearingMethod' | not --crash %target-swift-frontend -typecheck -I %t -I %S/Inputs/custom-modules -swift-version 4.2 -disable-deserialization-recovery -Xcc -DBAD - 2>&1 | %FileCheck -check-prefix CHECK-CRASH -check-prefix CHECK-CRASH-4_2 %s
|
|
// RUN: echo 'import Lib; _ = Sub.disappearingMethod' | not --crash %target-swift-frontend -typecheck -I %t -I %S/Inputs/custom-modules -debugger-support -swift-version 4 -disable-deserialization-recovery -Xcc -DBAD - 2>&1 | %FileCheck -check-prefix CHECK-CRASH-DEBUGGER %s
|
|
|
|
// REQUIRES: objc_interop
|
|
|
|
import Overrides
|
|
|
|
public class Sub: Base {
|
|
public override func disappearingMethod() {}
|
|
}
|
|
|
|
// CHECK-CRASH: error: fatal error encountered while reading from module 'Lib'; please submit a bug report (https://swift.org/contributing/#reporting-bugs){{$}}
|
|
// CHECK-CRASH-4: Compiling with effective version 4.1.50
|
|
// CHECK-CRASH-4_2: Compiling with effective version 4.2
|
|
// CHECK-CRASH: While loading members for 'Sub' (in module 'Lib')
|
|
// CHECK-CRASH-LABEL: *** DESERIALIZATION FAILURE ***
|
|
// CHECK-CRASH-LABEL: *** If any module named here was modified in the SDK, please delete the ***
|
|
// CHECK-CRASH-LABEL: *** new swiftmodule files from the SDK and keep only swiftinterfaces. ***
|
|
// CHECK-CRASH: module 'Lib', builder version {{.*}}4.1.50
|
|
// CHECK-CRASH: could not find 'disappearingMethod()' in parent class
|
|
// Part of the error message:
|
|
// CHECK-CRASH-DEBUGGER: Stack dump
|
|
// Produced by fatal() because of -disable-deserialization-recovery.
|
|
// CHECK-CRASH-DEBUGGER: Stack dump
|