mirror of
https://github.com/apple/swift.git
synced 2025-12-14 20:36:38 +01:00
f3ff561c6f
This is phase-1 of switching from llvm::Optional to std::optional in the
next rebranch. llvm::Optional was removed from upstream LLVM, so we need
to migrate off rather soon. On Darwin, std::optional, and llvm::Optional
have the same layout, so we don't need to be as concerned about ABI
beyond the name mangling. `llvm::Optional` is only returned from one
function in
```
getStandardTypeSubst(StringRef TypeName,
bool allowConcurrencyManglings);
```
It's the return value, so it should not impact the mangling of the
function, and the layout is the same as `std::optional`, so it should be
mostly okay. This function doesn't appear to have users, and the ABI was
already broken 2 years ago for concurrency and no one seemed to notice
so this should be "okay".
I'm doing the migration incrementally so that folks working on main can
cherry-pick back to the release/5.9 branch. Once 5.9 is done and locked
away, then we can go through and finish the replacement. Since `None`
and `Optional` show up in contexts where they are not `llvm::None` and
`llvm::Optional`, I'm preparing the work now by going through and
removing the namespace unwrapping and making the `llvm` namespace
explicit. This should make it fairly mechanical to go through and
replace llvm::Optional with std::optional, and llvm::None with
std::nullopt. It's also a change that can be brought onto the
release/5.9 with minimal impact. This should be an NFC change.
66 lines
2.1 KiB
C++
66 lines
2.1 KiB
C++
//===--- EditorPlaceholderTest.cpp ----------------------------------------===//
|
|
//
|
|
// This source file is part of the Swift.org open source project
|
|
//
|
|
// Copyright (c) 2014 - 2017 Apple Inc. and the Swift project authors
|
|
// Licensed under Apache License v2.0 with Runtime Library Exception
|
|
//
|
|
// See https://swift.org/LICENSE.txt for license information
|
|
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "swift/Basic/EditorPlaceholder.h"
|
|
#include "llvm/ADT/Optional.h"
|
|
#include "gtest/gtest.h"
|
|
|
|
using namespace swift;
|
|
|
|
TEST(EditorPlaceholder, EditorPlaceholders) {
|
|
const char *Text = "<#this is simple#>";
|
|
EditorPlaceholderData Data = *parseEditorPlaceholder(Text);
|
|
EXPECT_EQ(EditorPlaceholderKind::Basic, Data.Kind);
|
|
EXPECT_EQ("this is simple", Data.Display);
|
|
EXPECT_TRUE(Data.Type.empty());
|
|
EXPECT_TRUE(Data.TypeForExpansion.empty());
|
|
|
|
Text = "<#T##x: Int##Int#>";
|
|
Data = *parseEditorPlaceholder(Text);
|
|
EXPECT_EQ(EditorPlaceholderKind::Typed, Data.Kind);
|
|
EXPECT_EQ("x: Int", Data.Display);
|
|
EXPECT_EQ("Int", Data.Type);
|
|
EXPECT_EQ("Int", Data.TypeForExpansion);
|
|
|
|
Text = "<#T##x: Int##Blah##()->Int#>";
|
|
Data = *parseEditorPlaceholder(Text);
|
|
EXPECT_EQ(EditorPlaceholderKind::Typed, Data.Kind);
|
|
EXPECT_EQ("x: Int", Data.Display);
|
|
EXPECT_EQ("Blah", Data.Type);
|
|
EXPECT_EQ("()->Int", Data.TypeForExpansion);
|
|
|
|
Text = "<#T##Int#>";
|
|
Data = *parseEditorPlaceholder(Text);
|
|
EXPECT_EQ(EditorPlaceholderKind::Typed, Data.Kind);
|
|
EXPECT_EQ("Int", Data.Display);
|
|
EXPECT_EQ("Int", Data.Type);
|
|
EXPECT_EQ("Int", Data.TypeForExpansion);
|
|
}
|
|
|
|
TEST(EditorPlaceholder, InvalidEditorPlaceholders) {
|
|
const char *Text = "<#foo";
|
|
llvm::Optional<EditorPlaceholderData> DataOpt = parseEditorPlaceholder(Text);
|
|
EXPECT_FALSE(DataOpt.has_value());
|
|
|
|
Text = "foo#>";
|
|
DataOpt = parseEditorPlaceholder(Text);
|
|
EXPECT_FALSE(DataOpt.has_value());
|
|
|
|
Text = "#foo#>";
|
|
DataOpt = parseEditorPlaceholder(Text);
|
|
EXPECT_FALSE(DataOpt.has_value());
|
|
|
|
Text = " <#foo#>";
|
|
DataOpt = parseEditorPlaceholder(Text);
|
|
EXPECT_FALSE(DataOpt.has_value());
|
|
}
|