swift-mirror

mirror of https://github.com/apple/swift.git synced 2026-06-27 12:25:55 +02:00

Files

T

Chris Lattner 30ec0f4128 Fix <rdar://23036383> QoI: Invalid trailing closures in stmt-conditions produce lowsy diagnostics

It is a common problem that people use a call to a function with a
trailing closure in a if condition, foreach loop, etc.  These don't allow
trailing closures, because they are ambiguous with the brace-enclosed body
of the conditional statement.

In an effort to improve QoI on this, perform lookahead to disambiguate the most common
form of this, in a very narrow situation.  This allows us to produce a nice error
with fixit hints like:

t.swift:26:25: error: trailing closure requires parentheses for disambiguation in this context
for _ in numbers.filter {$0 > 4} {
                        ^

instead of spewing out this garbage:

t.swift:26:26: error: anonymous closure argument not contained in a closure
for _ in numbers.filter {$0 > 4} {
                         ^
t.swift:26:33: error: consecutive statements on a line must be separated by ';'
for _ in numbers.filter {$0 > 4} {
                                ^
                                ;
t.swift:26:34: error: statement cannot begin with a closure expression
for _ in numbers.filter {$0 > 4} {
                                 ^
t.swift:26:34: note: explicitly discard the result of the closure by assigning to '_'
for _ in numbers.filter {$0 > 4} {
                                 ^
                                 _ =
t.swift:26:34: error: braced block of statements is an unused closure
for _ in numbers.filter {$0 > 4} {
                                 ^
t.swift:26:18: error: type '(@noescape (Int) throws -> Bool) throws -> [Int]' does not conform to protocol 'Sequence'
for _ in numbers.filter {$0 > 4} {
                 ^
t.swift:26:34: error: expression resolves to an unused function
for _ in numbers.filter {$0 > 4} {
                                 ^

2016-03-22 22:06:06 -07:00

CMakeLists.txt

[gardening] Sort file listings in CMakeLists.txt files

2016-02-27 19:50:30 +01:00

Lexer.cpp

[Lexer] Remove redundant checks in lexNumber()

2016-03-16 22:28:39 +01:00

ParseDecl.cpp

Reapply "Merge pull request #1725 from atrick/specialize"

2016-03-21 12:43:05 -07:00

ParseExpr.cpp

Fix <rdar://23036383> QoI: Invalid trailing closures in stmt-conditions produce lowsy diagnostics