mirror of
https://github.com/apple/swift.git
synced 2025-12-21 12:14:44 +01:00
bbf189c8ab
Previously, when evaluating a `#if canImport(Module, _version: 42)` directive the compiler could diagnose and ignore the directive under the following conditions: - The associated binary module is corrupt/bogus. - The .tbd for an underlying Clang module is missing a current-version field. This behavior is surprising when there is a valid `.swiftinterface` available and it only becomes apparent when building against an SDK with an old enough version of the module that the version in the `.swiftinterface` is too low, making this failure easy to miss. Some modules have different versioning systems for their Swift and Clang modules and it can also be intentional for a distributed binary `.swiftmodule` to contain bogus data (to force the compiler to recompile the `.swiftinterface`) so we need to handle both of these cases gracefully and predictably. Now the compiler will enumerate all module loaders, ask each of them to attempt to parse the module version and then consistently use the parsed version from a single source. The `.swiftinterface` is preferred if present, then the binary module if present, and then finally the `.tbd`. The `.tbd` is still always used exclusively for the `_underlyingVersion` variant of `canImport()`. Resolves rdar://88723492
143 lines
6.1 KiB
Swift
143 lines
6.1 KiB
Swift
// RUN: %empty-directory(%t)
|
|
// RUN: %empty-directory(%t/textual)
|
|
// RUN: %empty-directory(%t/binary)
|
|
|
|
// RUN: echo "public func foo() {}" > %t/Foo.swift
|
|
// RUN: %target-swift-frontend -emit-module %t/Foo.swift -module-name Foo -swift-version 5 -disable-implicit-concurrency-module-import -user-module-version 113.330.1.2.3 -emit-module-interface-path %t/textual/Foo.swiftinterface -enable-library-evolution -emit-module-path %t/binary/Foo.swiftmodule
|
|
|
|
// RUN: %target-typecheck-verify-swift -disable-implicit-concurrency-module-import -I %t/textual
|
|
// RUN: %target-typecheck-verify-swift -disable-implicit-concurrency-module-import -I %t/binary
|
|
|
|
import Foo
|
|
|
|
func canImportVersioned() {
|
|
#if canImport(Foo, _version: 0)
|
|
let majorZero = 1 // expected-warning {{initialization of immutable value 'majorZero' was never used; consider replacing with assignment to '_' or removing it}}
|
|
#endif
|
|
|
|
#if canImport(Foo, _version: 112)
|
|
let majorSmaller = 1 // expected-warning {{initialization of immutable value 'majorSmaller' was never used; consider replacing with assignment to '_' or removing it}}
|
|
#endif
|
|
|
|
#if canImport(Foo, _version: 113)
|
|
let majorEqual = 1 // expected-warning {{initialization of immutable value 'majorEqual' was never used; consider replacing with assignment to '_' or removing it}}
|
|
#endif
|
|
|
|
#if canImport(Foo, _version: 114)
|
|
let majorLarger = 1
|
|
#endif
|
|
|
|
#if canImport(Foo, _version: 113.329)
|
|
let minorSmaller = 1 // expected-warning {{initialization of immutable value 'minorSmaller' was never used; consider replacing with assignment to '_' or removing it}}
|
|
#endif
|
|
|
|
#if canImport(Foo, _version: 113.330)
|
|
let minorEqual = 1 // expected-warning {{initialization of immutable value 'minorEqual' was never used; consider replacing with assignment to '_' or removing it}}
|
|
#endif
|
|
|
|
#if canImport(Foo, _version: 113.331)
|
|
let minorLarger = 1
|
|
#endif
|
|
|
|
#if canImport(Foo, _version: 113.330.0)
|
|
let patchSmaller = 1 // expected-warning {{initialization of immutable value 'patchSmaller' was never used; consider replacing with assignment to '_' or removing it}}
|
|
#endif
|
|
|
|
#if canImport(Foo, _version: 113.330.1)
|
|
let patchEqual = 1 // expected-warning {{initialization of immutable value 'patchEqual' was never used; consider replacing with assignment to '_' or removing it}}
|
|
#endif
|
|
|
|
#if canImport(Foo, _version: 113.330.2)
|
|
let patchLarger = 1
|
|
#endif
|
|
|
|
#if canImport(Foo, _version: 113.330.1.1)
|
|
let buildSmaller = 1 // expected-warning {{initialization of immutable value 'buildSmaller' was never used; consider replacing with assignment to '_' or removing it}}
|
|
#endif
|
|
|
|
#if canImport(Foo, _version: 113.330.1.2)
|
|
let buildEqual = 1 // expected-warning {{initialization of immutable value 'buildEqual' was never used; consider replacing with assignment to '_' or removing it}}
|
|
#endif
|
|
|
|
#if canImport(Foo, _version: 113.330.1.3)
|
|
let buildLarger = 1
|
|
#endif
|
|
|
|
#if canImport(Foo, _version: 113.330.1.2.0) // expected-warning {{trailing components of version '113.330.1.2' are ignored}}
|
|
let extraComponent = 1 // expected-warning {{initialization of immutable value 'extraComponent' was never used; consider replacing with assignment to '_' or removing it}}
|
|
#endif
|
|
|
|
#if canImport(Foo, _underlyingVersion: 113.33)
|
|
// Foo is a Swift module with no underlying clang module.
|
|
let underlyingMinorSmaller = 1
|
|
#endif
|
|
|
|
#if canImport(Foo)
|
|
let noVersion = 1 // expected-warning {{initialization of immutable value 'noVersion' was never used; consider replacing with assignment to '_' or removing it}}
|
|
#endif
|
|
}
|
|
|
|
/// Test versions specified as string literals.
|
|
func canImportVersionedString() {
|
|
#if canImport(Foo, _version: "0")
|
|
let majorZero = 1 // expected-warning {{initialization of immutable value 'majorZero' was never used; consider replacing with assignment to '_' or removing it}}
|
|
#endif
|
|
|
|
#if canImport(Foo, _version: "112")
|
|
let majorSmaller = 1 // expected-warning {{initialization of immutable value 'majorSmaller' was never used; consider replacing with assignment to '_' or removing it}}
|
|
#endif
|
|
|
|
#if canImport(Foo, _version: "113")
|
|
let majorEqual = 1 // expected-warning {{initialization of immutable value 'majorEqual' was never used; consider replacing with assignment to '_' or removing it}}
|
|
#endif
|
|
|
|
#if canImport(Foo, _version: "114")
|
|
let majorLarger = 1
|
|
#endif
|
|
|
|
#if canImport(Foo, _version: "113.329")
|
|
let minorSmaller = 1 // expected-warning {{initialization of immutable value 'minorSmaller' was never used; consider replacing with assignment to '_' or removing it}}
|
|
#endif
|
|
|
|
#if canImport(Foo, _version: "113.330")
|
|
let minorEqual = 1 // expected-warning {{initialization of immutable value 'minorEqual' was never used; consider replacing with assignment to '_' or removing it}}
|
|
#endif
|
|
|
|
#if canImport(Foo, _version: "113.331")
|
|
let minorLarger = 1
|
|
#endif
|
|
|
|
#if canImport(Foo, _version: "113.330.0")
|
|
let patchSmaller = 1 // expected-warning {{initialization of immutable value 'patchSmaller' was never used; consider replacing with assignment to '_' or removing it}}
|
|
#endif
|
|
|
|
#if canImport(Foo, _version: "113.330.1")
|
|
let patchEqual = 1 // expected-warning {{initialization of immutable value 'patchEqual' was never used; consider replacing with assignment to '_' or removing it}}
|
|
#endif
|
|
|
|
#if canImport(Foo, _version: "113.330.2")
|
|
let patchLarger = 1
|
|
#endif
|
|
|
|
#if canImport(Foo, _version: "113.330.1.1")
|
|
let buildSmaller = 1 // expected-warning {{initialization of immutable value 'buildSmaller' was never used; consider replacing with assignment to '_' or removing it}}
|
|
#endif
|
|
|
|
#if canImport(Foo, _version: "113.330.1.2")
|
|
let buildEqual = 1 // expected-warning {{initialization of immutable value 'buildEqual' was never used; consider replacing with assignment to '_' or removing it}}
|
|
#endif
|
|
|
|
#if canImport(Foo, _version: "113.330.1.3")
|
|
let buildLarger = 1
|
|
#endif
|
|
|
|
#if canImport(Foo, _version: "113.330.1.2.0") // expected-warning {{trailing components of version '113.330.1.2' are ignored}}
|
|
let extraComponent = 1 // expected-warning {{initialization of immutable value 'extraComponent' was never used; consider replacing with assignment to '_' or removing it}}
|
|
#endif
|
|
|
|
#if canImport(Foo, _underlyingVersion: "113.33")
|
|
// Foo is a Swift module with no underlying clang module.
|
|
let underlyingMinorSmaller = 1
|
|
#endif
|
|
}
|