mirror of
https://github.com/apple/swift.git
synced 2025-12-14 20:36:38 +01:00
All SILArgument types are "block arguments". There are three kinds: 1. Function arguments 2. Phis 3. Terminator results In every situation where the source of the block argument matters, we need to distinguish between these three. Accidentally failing to handle one of the cases is an perpetual source of compiler bugs. Attempting to handle both phis and terminator results uniformly is *always* a bug, especially once OSSA has phi flags. Even when all cases are handled correctly, the code that deals with data flow across blocks is incomprehensible without giving each case a type. This continues to be a massive waste of time literally every time I review code that involves cross-block control flow. Unfortunately, we don't have these C++ types yet (nothing big is blocking that, it just wasn't done). That's manageable because we can use wrapper types on the Swift side for now. Wrapper types don't create any more complexity than protocols, but they do sacrifice some usability in switch cases. There is no reason for a BlockArgument type. First, a function argument is a block argument just as much as any other. BlockArgument provides no useful information beyond Argument. And it is nearly always a mistake to care about whether a value is a function argument and not care whether it is a phi or terminator result.
129 lines
4.6 KiB
Swift
129 lines
4.6 KiB
Swift
//===--- SimplifyRefCasts.swift -------------------------------------------===//
|
|
//
|
|
// This source file is part of the Swift.org open source project
|
|
//
|
|
// Copyright (c) 2014 - 2023 Apple Inc. and the Swift project authors
|
|
// Licensed under Apache License v2.0 with Runtime Library Exception
|
|
//
|
|
// See https://swift.org/LICENSE.txt for license information
|
|
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
import SIL
|
|
|
|
// Note: this simplifications are not SILCombineSimplifyable, because SILCombine has
|
|
// its own simplifications for those cast instructions which are not ported to Swift, yet.
|
|
|
|
extension CheckedCastBranchInst : OnoneSimplifyable {
|
|
func simplify(_ context: SimplifyContext) {
|
|
// Has only an effect if the source is an (existential) reference.
|
|
simplifySourceOperandOfRefCast(context)
|
|
}
|
|
}
|
|
|
|
extension UncheckedRefCastInst : OnoneSimplifyable {
|
|
func simplify(_ context: SimplifyContext) {
|
|
simplifySourceOperandOfRefCast(context)
|
|
}
|
|
}
|
|
|
|
private extension UnaryInstruction {
|
|
|
|
/// Look through `upcast` and `init_existential_ref` instructions and replace the
|
|
/// operand of this cast instruction with the original value.
|
|
/// For example:
|
|
/// ```
|
|
/// %2 = upcast %1 : $Derived to $Base
|
|
/// %3 = init_existential_ref %2 : $Base : $Base, $AnyObject
|
|
/// checked_cast_br AnyObject in %3 : $AnyObject to Derived, bb1, bb2
|
|
/// ```
|
|
///
|
|
/// This makes it more likely that the cast can be constant folded because the source
|
|
/// operand's type is more accurate. In the example above, the cast reduces to
|
|
/// ```
|
|
/// checked_cast_br Derived in %1 : $Derived to Derived, bb1, bb2
|
|
/// ```
|
|
/// which can be trivially folded to always-succeeds.
|
|
///
|
|
func simplifySourceOperandOfRefCast(_ context: SimplifyContext) {
|
|
while true {
|
|
switch operand.value {
|
|
case let ier as InitExistentialRefInst:
|
|
if !tryReplaceSource(withOperandOf: ier, context) {
|
|
return
|
|
}
|
|
case let uc as UpcastInst:
|
|
if !tryReplaceSource(withOperandOf: uc, context) {
|
|
return
|
|
}
|
|
default:
|
|
return
|
|
}
|
|
}
|
|
|
|
}
|
|
|
|
func tryReplaceSource(withOperandOf inst: SingleValueInstruction, _ context: SimplifyContext) -> Bool {
|
|
let singleUse = context.preserveDebugInfo ? inst.uses.singleUse : inst.uses.singleNonDebugUse
|
|
let canEraseInst = singleUse?.instruction == self
|
|
let replacement = inst.operands[0].value
|
|
|
|
if parentFunction.hasOwnership {
|
|
if !canEraseInst && replacement.ownership == .owned {
|
|
// We cannot add more uses to `replacement` without inserting a copy.
|
|
return false
|
|
}
|
|
|
|
operand.set(to: replacement, context)
|
|
|
|
if let ccb = self as? CheckedCastBranchInst {
|
|
// In OSSA, the source value is passed as block argument to the failure block.
|
|
// We have to re-create the skipped source instruction in the failure block.
|
|
insertCompensatingInstructions(for: inst, in: ccb.failureBlock, context)
|
|
}
|
|
} else {
|
|
operand.set(to: replacement, context)
|
|
}
|
|
|
|
if canEraseInst {
|
|
context.erase(instructionIncludingDebugUses: inst)
|
|
}
|
|
return true
|
|
}
|
|
}
|
|
|
|
/// Compensate a removed source value instruction in the failure block.
|
|
/// For example:
|
|
/// ```
|
|
/// %inst = upcast %sourceValue : $Derived to $Base
|
|
/// checked_cast_br Base in %inst : $Base to Derived, success_block, failure_block
|
|
/// ...
|
|
/// failure_block(%oldArg : $Base):
|
|
/// ```
|
|
/// is converted to:
|
|
/// ```
|
|
/// checked_cast_br Derived in %sourceValue : $Derived to Derived, success_block, failure_block
|
|
/// ...
|
|
/// failure_block(%newArg : $Derived):
|
|
/// %3 = upcast %newArg : $Derived to $Base
|
|
/// ```
|
|
private func insertCompensatingInstructions(for inst: Instruction, in failureBlock: BasicBlock, _ context: SimplifyContext) {
|
|
assert(failureBlock.arguments.count == 1)
|
|
let sourceValue = inst.operands[0].value
|
|
let newArg = failureBlock.addArgument(type: sourceValue.type, ownership: sourceValue.ownership, context)
|
|
let builder = Builder(atBeginOf: failureBlock, context)
|
|
let newInst: SingleValueInstruction
|
|
switch inst {
|
|
case let ier as InitExistentialRefInst:
|
|
newInst = builder.createInitExistentialRef(instance: newArg, existentialType: ier.type, useConformancesOf: ier)
|
|
case let uc as UpcastInst:
|
|
newInst = builder.createUpcast(from: newArg, to: uc.type)
|
|
default:
|
|
fatalError("unhandled instruction")
|
|
}
|
|
let oldArg = failureBlock.arguments[0]
|
|
oldArg.uses.replaceAll(with: newInst, context)
|
|
failureBlock.eraseArgument(at: 0, context)
|
|
}
|