averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
b577a13019aa2d92f70b51e56c3a617fbfdffed1
swift-mirror/test/SILOptimizer/templvalueopt_ossa.sil
Erik Eckstein f0b7bdb382 TempLValueOpt: avoid creating invalid apply argument aliasing. 
An indirect argument (except `@inout_aliasable`) must not alias with another indirect argument.
Now, if we would replace tempAddr with destAddr in
```
  apply %f(%tempAddr, %destAddr) : (@in T) -> @out T
```
we would invalidate this rule.
This is even true if the called function does not read from destAddr.

Fixes a SIL verification error.
rdar://145090659
2025-02-19 10:33:18 +01:00

406 lines
15 KiB
Plaintext
Raw Blame History

// RUN: %target-sil-opt -sil-print-types -enable-sil-verify-all %s -temp-lvalue-opt | %FileCheck %s
// REQUIRES: swift_in_compiler
import Swift
import Builtin
// CHECK-LABEL: sil [ossa] @test_enum_with_initialize :
// CHECK: bb0(%0 : $*Optional<Any>, %1 : $*Any):
// CHECK-NEXT: [[E:%[0-9]+]] = init_enum_data_addr %0
// CHECK-NEXT: copy_addr [take] %1 to [init] [[E]]
// CHECK-NEXT: inject_enum_addr %0 : $*Optional<Any>, #Optional.some!enumelt
// CHECK-NOT: copy_addr
// CHECK: } // end sil function 'test_enum_with_initialize'
sil [ossa] @test_enum_with_initialize : $@convention(thin) (@in Any) -> @out Optional<Any> {
bb0(%0 : $*Optional<Any>, %1 : $*Any):
%2 = alloc_stack $Optional<Any>
%3 = init_enum_data_addr %2 : $*Optional<Any>, #Optional.some!enumelt
copy_addr [take] %1 to [init] %3 : $*Any
inject_enum_addr %2 : $*Optional<Any>, #Optional.some!enumelt
copy_addr [take] %2 to [init] %0 : $*Optional<Any>
dealloc_stack %2 : $*Optional<Any>
%6 = tuple ()
return %6 : $()
}
// CHECK-LABEL: sil [ossa] @test_enum_without_initialize :
// CHECK: bb0(%0 : $*Optional<Any>, %1 : $*Any):
// CHECK-NEXT: destroy_addr %0
// CHECK-NEXT: [[E:%[0-9]+]] = init_enum_data_addr %0
// CHECK-NEXT: copy_addr [take] %1 to [init] [[E]]
// CHECK-NEXT: inject_enum_addr %0 : $*Optional<Any>, #Optional.some!enumelt
// CHECK-NOT: copy_addr
// CHECK: } // end sil function 'test_enum_without_initialize'
sil [ossa] @test_enum_without_initialize : $@convention(thin) (@inout Optional<Any>, @in Any) -> () {
bb0(%0 : $*Optional<Any>, %1 : $*Any):
%2 = alloc_stack $Optional<Any>
%3 = init_enum_data_addr %2 : $*Optional<Any>, #Optional.some!enumelt
copy_addr [take] %1 to [init] %3 : $*Any
inject_enum_addr %2 : $*Optional<Any>, #Optional.some!enumelt
copy_addr [take] %2 to %0 : $*Optional<Any>
dealloc_stack %2 : $*Optional<Any>
%6 = tuple ()
return %6 : $()
}
protocol Proto {}
struct ConformingStruct : Proto {
@_hasStorage let a: Any
}
// CHECK-LABEL: sil [ossa] @test_existential :
// CHECK: bb0(%0 : $*any Proto, %1 : $*ConformingStruct):
// CHECK-NEXT: [[E:%[0-9]+]] = init_existential_addr %0
// CHECK-NEXT: copy_addr [take] %1 to [init] [[E]]
// CHECK-NOT: copy_addr
// CHECK: } // end sil function 'test_existential'
sil [ossa] @test_existential : $@convention(thin) (@in ConformingStruct) -> @out Proto {
bb0(%0 : $*Proto, %1 : $*ConformingStruct):
%2 = alloc_stack $Proto
%3 = init_existential_addr %2 : $*Proto, $ConformingStruct
copy_addr [take] %1 to [init] %3 : $*ConformingStruct
copy_addr [take] %2 to [init] %0 : $*Proto
dealloc_stack %2 : $*Proto
%6 = tuple ()
return %6 : $()
}
enum Either<Left, Right> {
case left(Left), right(Right)
}
public struct TestStruct {
@_hasStorage var e: Either<AddressOnlyPayload, Int>
}
struct AddressOnlyPayload {
@_hasStorage let a: Any
@_hasStorage let i: Int
}
// There should only be a single copy_addr after optimization.
//
// CHECK-LABEL: sil [ossa] @test_initialize_struct :
// CHECK: bb0(%0 : $*TestStruct, %1 : $*Any, %2 : $Int):
// CHECK-NEXT: [[E:%[0-9]+]] = struct_element_addr %0
// CHECK-NEXT: [[LEFT:%[0-9]+]] = init_enum_data_addr [[E]]
// CHECK-NEXT: [[A:%[0-9]+]] = struct_element_addr [[LEFT]]
// CHECK-NEXT: copy_addr [take] %1 to [init] [[A]]
// CHECK-NEXT: [[I:%[0-9]+]] = struct_element_addr [[LEFT]]
// CHECK-NEXT: store %2 to [trivial] [[I]]
// CHECK-NEXT: inject_enum_addr [[E]]
// CHECK-NOT: copy_addr
// CHECK: } // end sil function 'test_initialize_struct'
sil [ossa] @test_initialize_struct : $@convention(method) (@in Any, Int) -> @out TestStruct {
bb0(%0 : $*TestStruct, %1 : $*Any, %2 : $Int):
%3 = alloc_stack $TestStruct
%4 = alloc_stack $Either<AddressOnlyPayload, Int>
%5 = alloc_stack $AddressOnlyPayload
%6 = struct_element_addr %5 : $*AddressOnlyPayload, #AddressOnlyPayload.a
copy_addr [take] %1 to [init] %6 : $*Any
%8 = struct_element_addr %5 : $*AddressOnlyPayload, #AddressOnlyPayload.i
store %2 to [trivial] %8 : $*Int
%10 = init_enum_data_addr %4 : $*Either<AddressOnlyPayload, Int>, #Either.left!enumelt
copy_addr [take] %5 to [init] %10 : $*AddressOnlyPayload
inject_enum_addr %4 : $*Either<AddressOnlyPayload, Int>, #Either.left!enumelt
dealloc_stack %5 : $*AddressOnlyPayload
%14 = struct_element_addr %3 : $*TestStruct, #TestStruct.e
copy_addr [take] %4 to [init] %14 : $*Either<AddressOnlyPayload, Int>
dealloc_stack %4 : $*Either<AddressOnlyPayload, Int>
copy_addr %3 to [init] %0 : $*TestStruct
destroy_addr %3 : $*TestStruct
dealloc_stack %3 : $*TestStruct
%20 = tuple ()
return %20 : $()
}
// CHECK-LABEL: sil [ossa] @bail_on_write_to_dest :
// CHECK: alloc_stack
// CHECK: copy_addr
// CHECK: copy_addr
// CHECK: } // end sil function 'bail_on_write_to_dest'
sil [ossa] @bail_on_write_to_dest : $@convention(thin) (@inout Optional<Any>, @in Any) -> () {
bb0(%0 : $*Optional<Any>, %1 : $*Any):
%2 = alloc_stack $Optional<Any>
%3 = init_enum_data_addr %2 : $*Optional<Any>, #Optional.some!enumelt
copy_addr [take] %1 to [init] %3 : $*Any
inject_enum_addr %2 : $*Optional<Any>, #Optional.some!enumelt
destroy_addr %0 : $*Optional<Any>
copy_addr [take] %2 to [init] %0 : $*Optional<Any>
dealloc_stack %2 : $*Optional<Any>
%6 = tuple ()
return %6 : $()
}
// CHECK-LABEL: sil [ossa] @write_to_dest_ok_if_before_liverange :
// CHECK: bb0(%0 : $*Optional<Any>, %1 : $*Any):
// CHECK-NEXT: destroy_addr
// CHECK-NEXT: init_enum_data_addr
// CHECK-NEXT: copy_addr
// CHECK-NEXT: inject_enum_addr
// CHECK-NOT: copy_addr
// CHECK: } // end sil function 'write_to_dest_ok_if_before_liverange'
sil [ossa] @write_to_dest_ok_if_before_liverange : $@convention(thin) (@inout Optional<Any>, @in Any) -> () {
bb0(%0 : $*Optional<Any>, %1 : $*Any):
%2 = alloc_stack $Optional<Any>
destroy_addr %0 : $*Optional<Any>
%3 = init_enum_data_addr %2 : $*Optional<Any>, #Optional.some!enumelt
copy_addr [take] %1 to [init] %3 : $*Any
inject_enum_addr %2 : $*Optional<Any>, #Optional.some!enumelt
copy_addr [take] %2 to [init] %0 : $*Optional<Any>
dealloc_stack %2 : $*Optional<Any>
%6 = tuple ()
return %6 : $()
}
enum Enum {
case A(Optional<Any>), B
}
struct StructWithEnum : Proto {
@_hasStorage let e: Enum
}
// CHECK-LABEL: sil [ossa] @move_projections :
// CHECK: bb0(%0 : $*any Proto, %1 : $*Any):
// CHECK-NEXT: [[S:%[0-9]+]] = init_existential_addr %0 : $*any Proto, $StructWithEnum
// CHECK-NEXT: [[E:%[0-9]+]] = struct_element_addr [[S]] : $*StructWithEnum, #StructWithEnum.e
// CHECK-NEXT: [[ENUMA:%[0-9]+]] = init_enum_data_addr [[E]] : $*Enum, #Enum.A!enumelt
// CHECK-NEXT: [[OPTIONAL:%[0-9]+]] = init_enum_data_addr [[ENUMA]] : $*Optional<Any>, #Optional.some!enumelt
// CHECK-NEXT: copy_addr [take] %1 to [init] [[OPTIONAL]] : $*Any
// CHECK-NEXT: inject_enum_addr [[ENUMA]] : $*Optional<Any>, #Optional.some!enumelt
// CHECK-NEXT: inject_enum_addr [[E]] : $*Enum, #Enum.A!enumelt
// CHECK-NOT: copy_addr
// CHECK: } // end sil function 'move_projections'
sil [ossa] @move_projections : $@convention(thin) (@in Any) -> @out Proto {
bb0(%0 : $*Proto, %1 : $*Any):
%2 = alloc_stack $Optional<Any>
%3 = init_enum_data_addr %2 : $*Optional<Any>, #Optional.some!enumelt
copy_addr [take] %1 to [init] %3 : $*Any
inject_enum_addr %2 : $*Optional<Any>, #Optional.some!enumelt
%4 = init_existential_addr %0 : $*Proto, $StructWithEnum
%5 = struct_element_addr %4 : $*StructWithEnum, #StructWithEnum.e
%6 = init_enum_data_addr %5 : $*Enum, #Enum.A!enumelt
copy_addr [take] %2 to [init] %6 : $*Optional<Any>
inject_enum_addr %5 : $*Enum, #Enum.A!enumelt
dealloc_stack %2 : $*Optional<Any>
%10 = tuple ()
return %10 : $()
}
// CHECK-LABEL: sil [ossa] @cant_move_projections :
// CHECK: alloc_stack
// CHECK: copy_addr
// CHECK: load
// CHECK: copy_addr
// CHECK: } // end sil function 'cant_move_projections'
sil [ossa] @cant_move_projections : $@convention(thin) (@in Any, @in_guaranteed Builtin.RawPointer) -> () {
bb0(%0 : $*Any, %1 : $*Builtin.RawPointer):
%2 = alloc_stack $Optional<Any>
%3 = init_enum_data_addr %2 : $*Optional<Any>, #Optional.some!enumelt
copy_addr [take] %0 to [init] %3 : $*Any
inject_enum_addr %2 : $*Optional<Any>, #Optional.some!enumelt
%4 = load [trivial] %1 : $*Builtin.RawPointer
%5 = pointer_to_address %4 : $Builtin.RawPointer to $*Optional<Any>
copy_addr [take] %2 to [init] %5 : $*Optional<Any>
dealloc_stack %2 : $*Optional<Any>
%10 = tuple ()
return %10 : $()
}
sil [ossa] @init_optional : $@convention(thin) () -> @out Optional<Any>
// CHECK-LABEL: sil [ossa] @instructions_after_copy_addr :
// CHECK: alloc_stack
// CHECK: copy_addr
// CHECK: copy_addr
// CHECK: apply
// CHECK: } // end sil function 'instructions_after_copy_addr'
sil [ossa] @instructions_after_copy_addr : $@convention(thin) (@in Any) -> @out Optional<Any> {
bb0(%0 : $*Optional<Any>, %1 : $*Any):
%2 = alloc_stack $Optional<Any>
%3 = init_enum_data_addr %2 : $*Optional<Any>, #Optional.some!enumelt
copy_addr [take] %1 to [init] %3 : $*Any
inject_enum_addr %2 : $*Optional<Any>, #Optional.some!enumelt
copy_addr [take] %2 to [init] %0 : $*Optional<Any>
%4 = function_ref @init_optional : $@convention(thin) () -> @out Optional<Any>
%5 = apply %4(%2) : $@convention(thin) () -> @out Optional<Any>
destroy_addr %2 : $*Optional<Any>
dealloc_stack %2 : $*Optional<Any>
%6 = tuple ()
return %6 : $()
}
// CHECK-LABEL: sil [ossa] @dont_optimize_swap :
// CHECK: alloc_stack
// CHECK: copy_addr
// CHECK: copy_addr
// CHECK: copy_addr
// CHECK: dealloc_stack
// CHECK: } // end sil function 'dont_optimize_swap'
sil [ossa] @dont_optimize_swap : $@convention(thin) <T> (@inout T, @inout T) -> () {
bb0(%0 : $*T, %1 : $*T):
%2 = alloc_stack $T
copy_addr [take] %0 to [init] %2 : $*T
copy_addr [take] %1 to [init] %0 : $*T
copy_addr [take] %2 to [init] %1 : $*T
dealloc_stack %2 : $*T
%78 = tuple ()
return %78 : $()
}
class Child { }
struct Parent {
var c : Child
}
sil @gen_child : $@convention(thin) () -> @out Child
// Check that alias analysis is invalidated correctly and that the pass does
// not produce invalid SIL (which would trigger a MemoryLifetime failure).
//
// CHECK-LABEL: sil [ossa] @invalidateAliasAnalysis :
// CHECK: copy_addr
// CHECK: } // end sil function 'invalidateAliasAnalysis'
sil [ossa] @invalidateAliasAnalysis : $@convention(thin) (@owned Child) -> () {
bb0(%0 :@owned $Child):
%2 = alloc_stack $Parent
%4 = alloc_stack $Child
store %0 to [init] %4 : $*Child
%7 = alloc_stack $Child
%func = function_ref @gen_child : $@convention(thin) () -> @out Child
%10 = apply %func(%7) : $@convention(thin)() -> @out Child
%11 = struct_element_addr %2 : $*Parent, #Parent.c
copy_addr [take] %7 to [init] %11 : $*Child
dealloc_stack %7 : $*Child
copy_addr [take] %4 to %11 : $*Child
%17 = tuple ()
dealloc_stack %4 : $*Child
destroy_addr %2 : $*Parent
dealloc_stack %2 : $*Parent
%res = tuple ()
return %res : $()
}
// CHECK-LABEL: sil [ossa] @cleanup_debuginsts :
// CHECK: copy_addr [take]
// CHECK-NOT: debug_value {{.*}} expr op_deref
// CHECK-LABEL: } // end sil function 'cleanup_debuginsts'
sil [ossa] @cleanup_debuginsts : $@convention(thin) <T> (@in T) -> () {
bb0(%0 : $*T):
%2 = alloc_stack $T
debug_value %0 : $*T, expr op_deref
copy_addr %0 to [init] %2 : $*T
debug_value %0 : $*T, expr op_deref
destroy_addr %0 : $*T
destroy_addr %2 : $*T
dealloc_stack %2 : $*T
%78 = tuple ()
return %78 : $()
}
sil @createAny : $@convention(thin) () -> @out Any
sil @createAny_no_barrier : $@convention(thin) () -> @out Any {
[global:]
}
// CHECK-LABEL: sil [ossa] @test_deinit_barrier :
// CHECK: copy_addr [take]
// CHECK-LABEL: } // end sil function 'test_deinit_barrier'
sil [ossa] @test_deinit_barrier : $@convention(thin) (@guaranteed Any, @inout Any) -> () {
bb0(%0 : @guaranteed $Any, %1 : $*Any):
%2 = alloc_stack $Any
%4 = function_ref @createAny : $@convention(thin) () -> @out Any
%5 = apply %4(%2) : $@convention(thin) () -> @out Any
copy_addr [take] %2 to %1 : $*Any
dealloc_stack %2 : $*Any
%11 = tuple ()
return %11 : $()
}
// CHECK-LABEL: sil [ossa] @test_no_deinit_barrier :
// CHECK-NOT: copy_addr
// CHECK-LABEL: } // end sil function 'test_no_deinit_barrier'
sil [ossa] @test_no_deinit_barrier : $@convention(thin) (@guaranteed Any, @inout Any) -> () {
bb0(%0 : @guaranteed $Any, %1 : $*Any):
%2 = alloc_stack $Any
%4 = function_ref @createAny_no_barrier : $@convention(thin) () -> @out Any
%5 = apply %4(%2) : $@convention(thin) () -> @out Any
copy_addr [take] %2 to %1 : $*Any
dealloc_stack %2 : $*Any
%11 = tuple ()
return %11 : $()
}
struct TwoFields {
var a: Child
var b: Child
}
sil @no_read : $@convention(thin) (@in_guaranteed TwoFields) -> @out Child {
[%0: write v**]
[global: ]
}
sil @no_reads : $@convention(thin) (@in_guaranteed Child, @in_guaranteed TwoFields) -> () {
[global: ]
}
// CHECK-LABEL: sil [ossa] @argument_aliasing :
// CHECK: %1 = alloc_stack
// CHECK: apply %{{[0-9]+}}(%1, %0)
// CHECK-LABEL: } // end sil function 'argument_aliasing'
sil [ossa] @argument_aliasing : $@convention(thin) (@inout TwoFields) -> () {
bb0(%0 : $*TwoFields):
%1 = alloc_stack $Child
%2 = function_ref @no_read : $@convention(thin) (@in_guaranteed TwoFields) -> @out Child
%3 = apply %2(%1, %0) : $@convention(thin) (@in_guaranteed TwoFields) -> @out Child
%4 = struct_element_addr %0, #TwoFields.a
copy_addr [take] %1 to %4
dealloc_stack %1
%7 = tuple ()
return %7
}
// CHECK-LABEL: sil [ossa] @no_argument_aliasing :
// CHECK-NOT: alloc_stack
// CHECK: [[A:%.*]] = struct_element_addr %0 : $*TwoFields, #TwoFields.a
// CHECK-NEXT: destroy_addr [[A]]
// CHECK: apply %{{[0-9]+}}([[A]], %1)
// CHECK-NOT: copy_addr
// CHECK-LABEL: } // end sil function 'no_argument_aliasing'
sil [ossa] @no_argument_aliasing : $@convention(thin) (@inout TwoFields, @inout TwoFields) -> () {
bb0(%0 : $*TwoFields, %1 : $*TwoFields):
%2 = alloc_stack $Child
%3 = function_ref @no_read : $@convention(thin) (@in_guaranteed TwoFields) -> @out Child
%4 = apply %3(%2, %1) : $@convention(thin) (@in_guaranteed TwoFields) -> @out Child
%5 = struct_element_addr %0, #TwoFields.a
copy_addr [take] %2 to %5
dealloc_stack %2
%8 = tuple ()
return %8
}
// CHECK-LABEL: sil [ossa] @guaranteed_argument_aliasing :
// CHECK-NOT: alloc_stack
// CHECK: [[A:%.*]] = struct_element_addr %0 : $*TwoFields, #TwoFields.a
// CHECK-NEXT: destroy_addr [[A]]
// CHECK: apply %{{[0-9]+}}([[A]], %0)
// CHECK-NOT: copy_addr
// CHECK-LABEL: } // end sil function 'guaranteed_argument_aliasing'
sil [ossa] @guaranteed_argument_aliasing : $@convention(thin) (@inout TwoFields, @owned Child) -> () {
bb0(%0 : $*TwoFields, %1 : @owned $Child):
%2 = alloc_stack $Child
store %1 to [init] %2
%3 = function_ref @no_reads : $@convention(thin) (@in_guaranteed Child, @in_guaranteed TwoFields) -> ()
%4 = apply %3(%2, %0) : $@convention(thin) (@in_guaranteed Child, @in_guaranteed TwoFields) -> ()
%5 = struct_element_addr %0, #TwoFields.a
copy_addr [take] %2 to %5
dealloc_stack %2
%8 = tuple ()
return %8
}
Reference in New Issue View Git Blame Copy Permalink