mirror of
https://github.com/apple/swift.git
synced 2025-12-14 20:36:38 +01:00
6e6b6b9837
Rather than mangling the complete generic signature of a constrained
extension, only mangle the requirements not already satisfied by the
nominal type. For example, given:
extension Dictionary where Value: Equatable {
// OLD: _T0s10DictionaryV2t3s8HashableRzs9EquatableR_r0_lE3baryyF
// NEW: _T0s10DictionaryV2t3s9EquatableR_rlE3baryyF
public func bar() { }
}
In the existing mangling, we mangle the `Key: Hashable` requirement that’s
part of the generic signature. With this change, we only mangle the new
requirement (`Value: Equatable`).
This is a win for constrained extensions *except* in the case of a
constrained extension of a nominal type with a single, unconstrained
generic parameter:
extension Array where Element: Equatable {
// OLD: _T0Sa2t3s9EquatableRzlE3baryyF
// NEW would be: _T0Sa2t3s9EquatableRzrlE3baryyF
public func bar() { }
}
Check explicily for this shortcut mangling and fall back to the old
path, so this change is a strict improvement.
40 lines
1.6 KiB
Swift
40 lines
1.6 KiB
Swift
// RUN: %target-swift-frontend -emit-silgen -parse-as-library -enable-sil-ownership %s | %FileCheck %s
|
|
|
|
|
|
func dup<T>(_ x: T) -> (T, T) { return (x,x) }
|
|
// CHECK-LABEL: sil hidden @_T014generic_tuples3dup{{[_0-9a-zA-Z]*}}F
|
|
// CHECK: ([[RESULT_0:%.*]] : @trivial $*T, [[RESULT_1:%.*]] : @trivial $*T, [[XVAR:%.*]] : @trivial $*T):
|
|
// CHECK-NEXT: debug_value_addr [[XVAR]] : $*T, let, name "x"
|
|
// CHECK-NEXT: copy_addr [[XVAR]] to [initialization] [[RESULT_0]]
|
|
// CHECK-NEXT: copy_addr [[XVAR]] to [initialization] [[RESULT_1]]
|
|
// CHECK-NEXT: destroy_addr [[XVAR]]
|
|
// CHECK-NEXT: [[T0:%.*]] = tuple ()
|
|
// CHECK-NEXT: return [[T0]]
|
|
|
|
// <rdar://problem/13822463>
|
|
// Specializing a generic function on a tuple type changes the number of
|
|
// SIL parameters, which caused a failure in the ownership conventions code.
|
|
|
|
struct Blub {}
|
|
// CHECK-LABEL: sil hidden @_T014generic_tuples3foo{{[_0-9a-zA-Z]*}}F
|
|
func foo<T>(_ x: T) {}
|
|
// CHECK-LABEL: sil hidden @_T014generic_tuples3bar{{[_0-9a-zA-Z]*}}F
|
|
func bar(_ x: (Blub, Blub)) { foo(x) }
|
|
|
|
|
|
// rdar://26279628
|
|
// A type parameter constrained to be a concrete type must be handled
|
|
// as that concrete type throughout SILGen. That's especially true
|
|
// if it's constrained to be a tuple.
|
|
|
|
protocol HasAssoc {
|
|
associatedtype A
|
|
}
|
|
extension HasAssoc where A == (Int, Int) {
|
|
func returnTupleAlias() -> A {
|
|
return (0, 0)
|
|
}
|
|
}
|
|
// CHECK-LABEL: sil hidden @_T014generic_tuples8HasAssocPAASi_Sit1ARtzrlE16returnTupleAliasSi_SityF : $@convention(method) <Self where Self : HasAssoc, Self.A == (Int, Int)> (@in_guaranteed Self) -> (Int, Int) {
|
|
// CHECK: return {{.*}} : $(Int, Int)
|