mirror of
https://github.com/apple/swift.git
synced 2025-12-21 12:14:44 +01:00
8b55a0f61b
For Swift 3 / 4: Deprecate the spelling "ImplicitlyUnwrappedOptional", emitting a warning and suggesting "!" in places where they are allowed according to SE-0054. In places where SE-0054 disallowed IUOs but we continued to accept them in previous compilers, emit a warning suggesting "Optional" or "?" as an alternative depending on context and treat the IUO as an Optional, noting this in the diagnostic. For Swift 5: Treat "ImplicitlyUnwrappedOptional" as an error, suggesting "!" in places where they are allowed by SE-0054. In places where SE-0054 disallowed IUOs, emit an error suggestion "Optional" or "?" as an alternative depending on context.
197 lines
10 KiB
Swift
197 lines
10 KiB
Swift
// RUN: %target-typecheck-verify-swift -swift-version 5
|
|
|
|
// These are all legal uses of '!'.
|
|
struct Fine {
|
|
var value: Int!
|
|
|
|
func m(_ unnamed: Int!, named: Int!) -> Int! { return unnamed }
|
|
static func s(_ unnamed: Int!, named: Int!) -> Int! { return named }
|
|
|
|
init(_ value: Int) { self.value = value }
|
|
init!() { return nil }
|
|
|
|
subscript (
|
|
index: Int!
|
|
) -> Int! {
|
|
return index
|
|
}
|
|
|
|
subscript<T> (
|
|
index: T!
|
|
) -> T! {
|
|
return index
|
|
}
|
|
}
|
|
let _: ImplicitlyUnwrappedOptional<Int> = 1 // expected-error {{the spelling 'ImplicitlyUnwrappedOptional' is unsupported; use '!' after the type name}}{{8-36=}} {{39-39=!}} {{39-40=}}
|
|
let _: ImplicitlyUnwrappedOptional = 1 // expected-error {{the spelling 'ImplicitlyUnwrappedOptional' is unsupported; use an explicit type followed by '!'}}
|
|
|
|
extension ImplicitlyUnwrappedOptional {} // expected-error {{the spelling 'ImplicitlyUnwrappedOptional' is unsupported; use 'Optional' instead}}{{11-38=Optional}}
|
|
|
|
func functionSpelling(
|
|
_: ImplicitlyUnwrappedOptional<Int> // expected-error {{the spelling 'ImplicitlyUnwrappedOptional' is unsupported; use '!' after the type name}}{{6-34=}} {{37-37=!}} {{37-38=}}
|
|
) -> ImplicitlyUnwrappedOptional<Int> { // expected-error {{the spelling 'ImplicitlyUnwrappedOptional' is unsupported; use '!' after the type name}}{{6-34=}} {{37-37=!}} {{37-38=}}
|
|
return 1
|
|
}
|
|
|
|
// Okay, like in the method case.
|
|
func functionSigil(
|
|
_: Int!
|
|
) -> Int! {
|
|
return 1
|
|
}
|
|
|
|
// Not okay because '!' is not at the top level of the type.
|
|
func functionSigilArray(
|
|
_: [Int!] // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{10-11=?}}
|
|
) -> [Int!] { // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{10-11=?}}
|
|
return [1]
|
|
}
|
|
|
|
func genericFunction<T>(
|
|
iuo: ImplicitlyUnwrappedOptional<T> // expected-error {{the spelling 'ImplicitlyUnwrappedOptional' is unsupported; use '!' after the type name}}{{8-36=}} {{37-37=!}} {{37-38=}}
|
|
) -> ImplicitlyUnwrappedOptional<T> { // expected-error {{the spelling 'ImplicitlyUnwrappedOptional' is unsupported; use '!' after the type name}}{{6-34=}} {{35-35=!}} {{35-36=}}
|
|
return iuo
|
|
}
|
|
|
|
// Okay, like in the non-generic case.
|
|
func genericFunctionSigil<T>(
|
|
iuo: T!
|
|
) -> T! {
|
|
return iuo
|
|
}
|
|
|
|
func genericFunctionSigilArray<T>(
|
|
// FIXME: We validate these types multiple times resulting in multiple diagnostics
|
|
iuo: [T!] // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{10-11=?}}
|
|
// expected-error@-1 {{'!' is not allowed here; perhaps '?' was intended?}}{{10-11=?}}
|
|
// expected-error@-2 {{'!' is not allowed here; perhaps '?' was intended?}}{{10-11=?}}
|
|
) -> [T!] { // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{8-9=?}}
|
|
// expected-error@-1 {{'!' is not allowed here; perhaps '?' was intended?}}{{8-9=?}}
|
|
// expected-error@-2 {{'!' is not allowed here; perhaps '?' was intended?}}{{8-9=?}}
|
|
return iuo
|
|
}
|
|
|
|
protocol P {
|
|
associatedtype T
|
|
associatedtype U
|
|
}
|
|
|
|
struct S : P {
|
|
typealias T = ImplicitlyUnwrappedOptional<Int> // expected-error {{'ImplicitlyUnwrappedOptional' is not allowed here; perhaps 'Optional' was intended?}}{{17-45=}} {{48-48=?}} {{48-49=}}
|
|
typealias U = Optional<ImplicitlyUnwrappedOptional<Int>> // expected-error {{'ImplicitlyUnwrappedOptional' is not allowed here; perhaps 'Optional' was intended?}}{{26-54=}} {{57-57=?}} {{57-58=}}
|
|
|
|
typealias V = Int! // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{20-21=?}}
|
|
typealias W = Int!? // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{20-21=?}}
|
|
|
|
var x: V
|
|
var y: W
|
|
var fn1: (Int!) -> Int // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{16-17=?}}
|
|
var fn2: (Int) -> Int! // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{24-25=?}}
|
|
|
|
subscript (
|
|
index: ImplicitlyUnwrappedOptional<Int> // expected-error {{the spelling 'ImplicitlyUnwrappedOptional' is unsupported; use '!' after the type name}}{{12-40=}} {{43-43=!}} {{43-44=}}
|
|
) -> ImplicitlyUnwrappedOptional<Int> { // expected-error {{the spelling 'ImplicitlyUnwrappedOptional' is unsupported; use '!' after the type name}}{{12-40=}} {{43-43=!}} {{43-44=}}
|
|
return index
|
|
}
|
|
|
|
subscript<T> (
|
|
index: ImplicitlyUnwrappedOptional<T> // expected-error {{the spelling 'ImplicitlyUnwrappedOptional' is unsupported; use '!' after the type name}}{{12-40=}} {{41-41=!}} {{41-42=}}
|
|
) -> ImplicitlyUnwrappedOptional<T> { // expected-error {{the spelling 'ImplicitlyUnwrappedOptional' is unsupported; use '!' after the type name}}{{12-40=}} {{41-41=!}} {{41-42=}}
|
|
return index
|
|
}
|
|
}
|
|
|
|
func generic<T : P>(_: T) where T.T == ImplicitlyUnwrappedOptional<Int> { } // expected-error {{'ImplicitlyUnwrappedOptional' is not allowed here; perhaps 'Optional' was intended?}}{{40-68=}} {{71-71=?}} {{71-72=}}
|
|
func genericOptIUO<T : P>(_: T) where T.U == Optional<ImplicitlyUnwrappedOptional<Int>> {} // expected-error {{'ImplicitlyUnwrappedOptional' is not allowed here; perhaps 'Optional' was intended?}}{{55-83=}} {{86-86=?}} {{86-87=}}
|
|
|
|
func testClosure() -> Int {
|
|
return {
|
|
(i: ImplicitlyUnwrappedOptional<Int>) // expected-error {{the spelling 'ImplicitlyUnwrappedOptional' is unsupported; use '!' after the type name}}{{9-37=}} {{40-40=!}} {{40-41=}}
|
|
-> ImplicitlyUnwrappedOptional<Int> in // expected-error {{'ImplicitlyUnwrappedOptional' is not allowed here; perhaps 'Optional' was intended?}}{{9-37=}} {{40-40=?}} {{40-41=}}
|
|
return i
|
|
}(1)
|
|
}
|
|
|
|
_ = Array<Int!>() // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{14-15=?}}
|
|
let _: Array<Int!> = [1] // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{17-18=?}}
|
|
_ = [Int!]() // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{9-10=?}}
|
|
let _: [Int!] = [1] // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{12-13=?}}
|
|
_ = Optional<Int!>(nil) // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{17-18=?}}
|
|
let _: Optional<Int!> = nil // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{20-21=?}}
|
|
_ = Int!?(0) // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{8-9=?}}
|
|
let _: Int!? = 0 // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{11-12=?}}
|
|
_ = (
|
|
Int!, // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{6-7=?}}
|
|
Float!, // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{8-9=?}}
|
|
String! // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{9-10=?}}
|
|
)(1, 2.0, "3")
|
|
let _: (
|
|
Int!, // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{6-7=?}}
|
|
Float!, // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{8-9=?}}
|
|
String! // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{9-10=?}}
|
|
) = (1, 2.0, "3")
|
|
|
|
struct Generic<T, U, C> {
|
|
init(_ t: T, _ u: U, _ c: C) {}
|
|
}
|
|
_ = Generic<Int!, // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{16-17=?}}
|
|
Float!, // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{18-19=?}}
|
|
String!>(1, 2.0, "3") // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{19-20=?}}
|
|
let _: Generic<Int!, // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{19-20=?}}
|
|
Float!, // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{21-22=?}}
|
|
String!> = Generic(1, 2.0, "3") // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{22-23=?}}
|
|
|
|
func vararg(_ first: Int, more: Int!...) { // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{36-37=?}}
|
|
}
|
|
|
|
func varargIdentifier(_ first: Int, more: ImplicitlyUnwrappedOptional<Int>...) { // expected-error {{'ImplicitlyUnwrappedOptional' is not allowed here; perhaps 'Optional' was intended?}}{{43-71=}} {{74-74=?}} {{74-75=}}
|
|
}
|
|
|
|
func iuoInTuple() -> (Int!) { // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{26-27=?}}
|
|
return 1
|
|
}
|
|
|
|
func iuoInTupleIdentifier() -> (ImplicitlyUnwrappedOptional<Int>) { // expected-error {{'ImplicitlyUnwrappedOptional' is not allowed here; perhaps 'Optional' was intended?}}{{33-61=}} {{64-64=?}} {{64-65=}}
|
|
return 1
|
|
}
|
|
|
|
func iuoInTuple2() -> (Float, Int!) { // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{34-35=?}}
|
|
return (1.0, 1)
|
|
}
|
|
|
|
func iuoInTuple2Identifier() -> (Float, ImplicitlyUnwrappedOptional<Int>) { // expected-error {{'ImplicitlyUnwrappedOptional' is not allowed here; perhaps 'Optional' was intended?}}{{41-69=}} {{72-72=?}} {{72-73=}}
|
|
return (1.0, 1)
|
|
}
|
|
|
|
func takesFunc(_ fn: (Int!) -> Int) -> Int { // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{26-27=?}}
|
|
return fn(0)
|
|
}
|
|
|
|
func takesFuncIdentifier(_ fn: (ImplicitlyUnwrappedOptional<Int>) -> Int) -> Int { // expected-error {{'ImplicitlyUnwrappedOptional' is not allowed here; perhaps 'Optional' was intended?}}{{33-61=}} {{64-64=?}} {{64-65=}}
|
|
return fn(0)
|
|
}
|
|
|
|
func takesFunc2(_ fn: (Int) -> Int!) -> Int { // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{35-36=?}}
|
|
return fn(0)!
|
|
}
|
|
|
|
func takesFunc2Identifier(_ fn: (Int) -> ImplicitlyUnwrappedOptional<Int>) -> Int { // expected-error {{'ImplicitlyUnwrappedOptional' is not allowed here; perhaps 'Optional' was intended?}}{{42-70=}} {{73-73=?}} {{73-74=}}
|
|
return fn(0)
|
|
}
|
|
|
|
func returnsFunc() -> (Int!) -> Int { // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{27-28=?}}
|
|
return { $0! }
|
|
}
|
|
|
|
func returnsFuncIdentifier() -> (ImplicitlyUnwrappedOptional<Int>) -> Int { // expected-error {{'ImplicitlyUnwrappedOptional' is not allowed here; perhaps 'Optional' was intended?}}{{34-62=}} {{65-65=?}} {{65-66=}}
|
|
return { $0 }
|
|
}
|
|
|
|
func returnsFunc2() -> (Int) -> Int! { // expected-error {{'!' is not allowed here; perhaps '?' was intended?}}{{36-37=?}}
|
|
return { $0 }
|
|
}
|
|
|
|
func returnsFunc2Identifier() -> (Int) -> ImplicitlyUnwrappedOptional<Int> { // expected-error {{'ImplicitlyUnwrappedOptional' is not allowed here; perhaps 'Optional' was intended?}}{{43-71=}} {{74-74=?}} {{74-75=}}
|
|
return { $0 }
|
|
}
|