Doug Gregor d9095b1079 [Conformance checking] Don't suppress substitution failures during checking. ...

When checking whether a particular protocol conformance satisfies all of
the protocol's requirements, we were suppressing substitution failures.
In some cases, this would mean that we marked a conformance "invalid"
without ever emitting a diagnostic, which would lead to downstream crashes.

Instead, treat substitution failures somewhat more lazily. If we encounter
one while performing the checking, put the conformance into a "delayed" list
rather than failing immediately. Teach the top-level type checking
loop to re-check these conformances, emitting a diagnostic if they
fail the second time around.

Fixes rdar://problem/35082483 and likely other issues that slipped
through the type checker or blew up in unpredictable ways.

2017-12-18 16:43:59 -08:00

..

Inputs

Avoid building conformance lookup tables when we don't have to.

2017-07-05 11:23:27 -07:00

0001-rdar19792730.swift

…

0002-rdar19792768.swift

[gardening] Mark crash cases as fixed.

2016-12-09 21:46:43 +01:00

0003-rdar20564378.swift

Rename -parse flag to -typecheck

2016-11-28 10:50:55 -08:00

0003-rdar20740573.swift

[gardening] Mark crash cases as fixed.

2016-12-09 21:46:43 +01:00

0004-rdar20564605.swift

Rename -parse flag to -typecheck

2016-11-28 10:50:55 -08:00

0006-rdar20588474.swift

Rename -parse flag to -typecheck

2016-11-28 10:50:55 -08:00

0007-rdar20750480.swift

Rename -parse flag to -typecheck

2016-11-28 10:50:55 -08:00

0008-rdar18796397.swift

…

0009-rdar18996669.swift

[SE-0046] Implements consistent function parameter labels by discarding extraneous parameter names and adding _ where necessary

2016-04-06 20:21:58 -04:00

0010-rdar20638881.swift

Rename -parse flag to -typecheck

2016-11-28 10:50:55 -08:00

0011-rdar20985062.swift

[SE-0046] Implements consistent function parameter labels by discarding extraneous parameter names and adding _ where necessary

2016-04-06 20:21:58 -04:00

0011-rdar21042357.swift

Rename -parse flag to -typecheck

2016-11-28 10:50:55 -08:00

0012-rdar20270240.swift

…

0013-rdar19519590.swift

update validation tests to modern syntax.

2016-07-02 17:10:49 -07:00

0014-rdar20508671.swift

Rename -parse flag to -typecheck

2016-11-28 10:50:55 -08:00

0015-rdar16803384.swift

Rename -parse flag to -typecheck

2016-11-28 10:50:55 -08:00

0016-rdar21437203.swift

Flip the switch on 'private' and 'fileprivate' (SE-0025).

2016-07-28 09:55:23 -07:00

0017-rdar21087186.swift

Rename -parse flag to -typecheck

2016-11-28 10:50:55 -08:00

0018-rdar21524144.swift

Rename -parse flag to -typecheck

2016-11-28 10:50:55 -08:00

0019-rdar21511651.swift

Fix and un-XFAIL regressed crashers from recent stdlib change

2017-05-17 05:51:51 -07:00

0020-rdar21598514.swift

Fix and un-XFAIL regressed crashers from recent stdlib change

2017-05-17 05:51:51 -07:00

0021-rdar21333511.swift

Rename -parse flag to -typecheck

2016-11-28 10:50:55 -08:00

0022-rdar21625478.swift

Arithmetic => Numeric

2017-03-13 11:50:02 -07:00

0023-rdar21679169.swift

Rename -parse flag to -typecheck

2016-11-28 10:50:55 -08:00

0024-rdar21551616.swift

Rename -parse flag to -typecheck

2016-11-28 10:50:55 -08:00

0025-rdar21783334.swift

Rename -parse flag to -typecheck

2016-11-28 10:50:55 -08:00

0026-rdar21382194.swift

Rename -parse flag to -typecheck

2016-11-28 10:50:55 -08:00

0027-rdar21514140.swift

[gardening] 2016 → 2017

2017-01-06 16:41:22 +01:00

0028-rdar19686707.swift

Rename -parse flag to -typecheck

2016-11-28 10:50:55 -08:00

0029-rdar21389284.swift

Rename -parse flag to -typecheck

2016-11-28 10:50:55 -08:00

0030-rdar19534837.swift

Rename -parse flag to -typecheck

2016-11-28 10:50:55 -08:00

0031-rdar19606899.swift

Rename -parse flag to -typecheck

2016-11-28 10:50:55 -08:00

0032-rdar19919421.swift

Rename -parse flag to -typecheck

2016-11-28 10:50:55 -08:00

0033-rdar21945994.swift

Rename -parse flag to -typecheck

2016-11-28 10:50:55 -08:00

0034-rdar21982453.swift

update validation tests to modern syntax.

2016-07-02 17:10:49 -07:00

0035-rdar22003613.swift

Rename -parse flag to -typecheck

2016-11-28 10:50:55 -08:00

0036-rdar23719809.swift

Rename -parse flag to -typecheck

2016-11-28 10:50:55 -08:00

0037-SILWitnessVisitor.swift

…

0038-lowering-CheckedCastEmitter-emitConditional.swift

SILGen: Fix crash with non-scalar casts requiring re-abstraction

2017-01-03 19:05:41 -08:00

0039-typechecker-crash.swift

…

0040-rdar23899799-broken-bool.swift

Revert "Fix the build."

2016-07-17 16:29:18 -07:00

0041-walkToDeclPost-crash.swift

[test] Cleaning up tests

2017-08-29 10:04:39 -07:00

0042-rdar21775089.swift

[GSB] Cope with typealiases within protocol hierarchies.

2017-06-23 17:25:45 -07:00

0043-rdar25298116.swift

Rename -parse flag to -typecheck

2016-11-28 10:50:55 -08:00

0044-enum-dot-crash.swift

[Diagnostics] When building a subscript don't assume that overload is always present

2016-11-28 19:18:44 -08:00

0045-sr3267.swift

SILGen: Implement missing function conversions from tuples to Any

2017-01-03 19:05:40 -08:00

0046-recursive-generic-arg-in-inherited-clause.swift

[gardening] Remove "REQUIRES: asserts" from fixed crashers.

2016-12-11 00:50:26 +01:00

0047-sr1307.swift

Add test cases for a few bugs that seem to be fixed already

2017-01-04 02:02:29 -08:00

0048-sr2333.swift

Add test cases for a few bugs that seem to be fixed already

2017-01-04 02:02:29 -08:00

0049-sr2611.swift

Add test cases for a few bugs that seem to be fixed already

2017-01-04 02:02:29 -08:00

0050-sr3159.swift

Add test cases for a few bugs that seem to be fixed already

2017-01-04 02:02:29 -08:00

0051-sr3212.swift

Add test cases for a few bugs that seem to be fixed already

2017-01-04 02:02:29 -08:00

0052-sr3478.swift

Add test cases for a few bugs that seem to be fixed already

2017-01-04 02:02:29 -08:00

0053-sr490.swift

Add test cases for a few bugs that seem to be fixed already

2017-01-04 02:02:29 -08:00

0054-sr833.swift

Add test cases for a few bugs that seem to be fixed already

2017-01-04 02:02:29 -08:00

0055-sr3137.swift

AST: Make TypeBase::getSuperclass() return the superclass type when called on an UnboundGenericType

2017-01-03 20:15:30 -08:00

0056-sr3326.swift

SILGen: Fix reabstraction thunk emission when generic parameters are made non-canonical

2017-01-03 21:49:44 -08:00

0057-rdar29587093.swift

Add test cases for a few bugs that seem to be fixed already

2017-01-04 02:02:29 -08:00

0058-rdar29223240.swift

Add test cases for a few bugs that seem to be fixed already

2017-01-04 02:02:29 -08:00

0059-sr3321.swift

AST: Targeted fix for conformance lookup issue

2017-04-03 15:35:10 -07:00

0060-sr2702.swift

This test requires Objective-C interop

2017-01-03 22:22:14 -08:00

0061-sr3173.swift

SILGen: Fix calls to literal constructors defined in protocol extensions

2017-01-03 19:05:41 -08:00

0062-rdar28765265.swift

Add regression test for a radar that got fixed along the way

2017-01-05 18:00:39 -08:00

0063-rdar29782437.swift

Add a regression test for <https://github.com/apple/swift/pull/6536>

2017-01-05 18:00:45 -08:00

0064-rdar27627862.swift

Add regression test for a bug that's already been fixed

2017-01-23 23:54:50 -08:00

0065-sr3706.swift

SILGen: Relax assertion in tuple-to-optional function result conversion

2017-01-24 18:47:21 -08:00

0066-sr3687-updated.swift

[stdlib] Add Sequence.Element, change ExpressibleByArrayLiteral.Element to ArrayLiteralElement (#8990)

2017-05-14 06:33:25 -07:00

0066-sr3687.swift

[stdlib] Add Sequence.Element, change ExpressibleByArrayLiteral.Element to ArrayLiteralElement (#8990)

2017-05-14 06:33:25 -07:00

0067-typeof-check-source-ranges.swift

[Parse] Fix potential crasher regarding EndLoc of erroneous 'type(of:)' expr

2017-02-02 17:13:14 +09:00

0068-sr3853.swift

Migrate the rest of the tests to %empty-directory

2017-06-04 11:08:39 -07:00

0069-sr3657.swift

Fix tests

2017-04-04 13:10:43 -07:00

0070-sr3515.swift

Fix numbering compiler_crashers_2_fixed test cases

2017-02-08 15:43:08 -08:00

0071-sr3714.swift

Migrate the rest of the tests to %empty-directory

2017-06-04 11:08:39 -07:00

0072-sr3895-2.swift

Add regression test for a bug that seems to be fixed

2017-02-08 15:45:27 -08:00

0072-sr3895.swift

Add regression test for a bug that seems to be fixed

2017-02-08 15:45:27 -08:00

0073-sr2796.swift

Add regression test for a bug that got fixed along the way

2017-02-12 00:51:25 -08:00

0074-rdar28544316.swift

[GSB] Stop creating unresolved potential archetypes; rework typo correction.

2017-06-29 16:52:46 -07:00

0075-rdar30248571.swift

[GSB] Make sure we wire up same-named type declarations consistently.

2017-10-27 22:17:45 -07:00

0076-sr3500.swift

AST: Targeted fix for conformance lookup issue

2017-04-03 15:35:10 -07:00

0077-sr3884.swift

Add some crashers

2017-02-25 16:17:28 -08:00

0078-sr4059.swift

[Type checker] Teach areOverrideCompatibleSimple() to look at initializers.

2017-02-27 13:34:49 -08:00

0079-rdar30702721.swift

Add fixed compiled crasher from rdar://problem/30702721.

2017-03-03 10:50:49 -08:00

0080-rdar30442622.swift

[stdlib] Eradicate IndexDistance associated type (#12641)

2017-12-08 12:00:23 -08:00

0081-rdar30751491.swift

Sema: Fix crash if we try to look up constructors while validating a constructor

2017-03-13 01:50:41 -07:00

0082-rdar30354669.swift

Reimplement associated conformance IRGen using Doug's conformance

2017-03-14 03:48:10 -04:00

0083-rdar31163470-1.swift

Mangling: Fix bug in the logic for dropping same-type constraints

2017-03-21 00:15:18 -07:00

0083-rdar31163470-2.swift

[GSB] Filter out conformance constraints derived from concrete conformance.

2017-04-16 23:05:23 -07:00

0084-rdar31093854.swift

[GSB] Resolve dependent member types in same-type and superclass constraints.

2017-05-30 11:43:53 -07:00

0085-rdar31000248.swift

Sema: Fix convenience init delegation to a convenience init in a generic base class

2017-03-26 00:00:53 -07:00

0086-sr4301.swift

[QoI] Fix crash when constructing existential metatype without '.init'

2017-05-29 22:08:50 -07:00

0087-sr4016.swift

Add test for SR-4016 / rdar://problem/30677848, which is now fixed.

2017-03-24 11:36:45 -07:00

0088-sr4315.swift

Add regression test for a bug that's already fixed

2017-04-06 15:56:41 -07:00

0089-sr4458.swift

Eliminate the _*Indexable protocols.

2017-10-01 15:08:23 -07:00

0090-emit-implied-witness-table-ref.swift

Add a regression test

2017-04-18 14:10:56 -07:00

0090-sr4617.swift

[Generic environment] Only substitute top-level archetypes.

2017-04-18 13:19:21 -07:00

0091-rdar30168645.swift

AST: Remove AnyObject protocol

2017-05-02 19:45:00 -07:00

0092-se-0154.swift

[Substitution Map] Handle substitutions of generic parameters made concrete.

2017-04-28 16:22:07 -07:00

0093-sr-4471.swift

Add a regression test

2017-05-03 22:31:52 -07:00

0094-rdar30689883.swift

Add a regression test

2017-05-07 01:57:38 -07:00

0095-rdar30154791.swift

Add fixed crasher for rdar://problem/30154791.

2017-05-11 09:31:58 -07:00

0096-sr4272.swift

Add a regression test

2017-05-22 18:35:52 -07:00

0097-rdar32077627.swift

[GSB] Pull typo correction for nested types into delayed reqs handling.

2017-06-19 22:47:33 -07:00

0098-rdar30354669.swift

Add an unfixed crasher and two fixed ones

2017-05-23 23:14:10 -07:00

0099-sr4973.swift

Add an unfixed crasher and two fixed ones

2017-05-23 23:14:10 -07:00

0100-sr4295.swift

[GSB] Improve handling of conformances resolved by concrete types.

2017-06-23 09:34:57 -07:00

0101-sr5014.swift

[GSB] Don't add invalid concrete requirements.

2017-06-23 22:23:46 -07:00

0102-sr4575.swift

AST: Don't return hasTypeParameter() for DependentMemberTypes with an ErrorType base

2017-05-26 18:10:13 -07:00

0103-sr4743.swift

Sema: Change a getInterfaceType() to hasInterfaceType() in a couple of places

2017-05-29 00:06:55 -07:00

0104-sr4388.swift

Add a fixed crasher and an unfixed one

2017-06-02 20:43:27 -07:00

0105-sr1261.swift

Sema: Add a SE-0110-related test case that used to crash

2017-06-05 23:11:53 -07:00

0105-sr5050.swift

Sema: Fix failure to produce diagnostics when 'is' casts are involved

2017-06-13 20:19:43 -07:00

0106-rdar32700180.swift

Fold ConstraintSolver::coerceToRValue() into TypeChecker::coerceToRValue()

2017-06-14 22:44:32 -07:00

0107-rdar32700180.swift

[Type checker] Re-validate typealiases in protocols after protocol validation.

2017-06-15 22:51:30 -07:00

0108-sr4088.swift

AST: Tweak a concrete-nested-type-of-archetype hack slightly

2017-06-20 22:18:50 -07:00

0109-sr4737.swift

[stdlib] Eradicate IndexDistance associated type (#12641)

2017-12-08 12:00:23 -08:00

0110-sr4786.swift

Add formerly-crashing test case for SR-4786 / rdar://problem/31955862.

2017-06-23 22:17:58 -07:00

0111-rdar33067102.swift

Fix another subtle SE-0110-related break.

2017-07-10 17:36:53 -07:00

0112-rdar33135487.swift

[QoI] Don't try to lookup members on incorrect type while diagnosing keypath components

2017-07-05 17:19:05 -07:00

0112-rdar33139928.swift

[GSB] Cope with elided conformance requirements in concrete nested types.

2017-07-05 23:08:41 -07:00

0113-rdar33044867.swift

[QoI] Don't try to lookup members on incorrect type during Objective-C KeyPath validation

2017-07-12 14:04:10 -07:00

0114-rdar33189068.swift

Sema/AST: Fix a couple of protocol typealias validation order bugs

2017-07-23 17:34:38 -07:00

0115-sr5601.swift

[GSB] Form minimal requirement sources by removing redundant subpaths.

2017-08-10 17:00:07 -07:00

0116-rdar33365139.swift

Add regression test for rdar://33365139, which was fixed at some point

2017-08-14 00:31:57 -04:00

0117-rdar33433087.swift

Switch test from 'not ...' to positive test with the correct verify check.

2017-09-05 12:38:17 -07:00

0118-rdar31529413.swift

Add a test case for rdar://problem/31529413.

2017-09-05 12:40:06 -07:00

0119-rdar33613329.swift

[Diagnostics] Restore inout ParamDecl types properly after type-check

2017-09-25 17:38:28 -07:00

0120-rdar34184392.swift

[AST] Don't try to compute substitutions for a missing generic signature.

2017-10-02 13:30:43 -07:00

0122-rdar30965000.swift

Add now-passing test for rdar://problem/30965000.

2017-10-03 08:32:13 -07:00

0124-sr5825.swift

[Type checker] Diagnose failed attempts to resolve associated type witnesses.

2017-10-03 21:59:14 -07:00

0125-rdar33575781.swift

Add fixed crasher from rdar://problem/33575781

2017-10-03 13:47:19 -07:00

0126-sr5905.swift

Add fixed crasher from SR-5905.

2017-10-04 10:59:16 -07:00

0128-rdar35088384.swift

Add a regression test for rdar://problem/35088384

2017-10-24 22:47:07 -07:00

0129-rdar35019075.swift

Add fixed crasher from rdar://problem/35019075

2017-10-26 14:08:07 -07:00

0130-rdar35632543.swift

[AST] Properly adjust substitution type for inherited conformances.

2017-11-19 21:50:24 -08:00

0131-sr6466.swift

[AST] Fix a crash when conformance lookup fails during substitution.

2017-11-24 23:18:11 -08:00

0132-rdar35699666.swift

[Diagnostics] Fix crash related to diagnostics of trailing closures

2017-11-28 13:12:25 -08:00

0133-rdar35832679.swift

Fix whitespace in a test

2017-12-06 16:35:59 -08:00

0134-rdar35947198.swift

Add CHECK lines to 0134-rdar35947198 validation-test

2017-12-14 13:33:25 -08:00

0135-rdar26140749.swift

Add test case for rdar://problem/26140749, a fixed crasher

2017-12-18 16:43:46 -08:00

0136-rdar35082483.swift

[Conformance checking] Don't suppress substitution failures during checking.

2017-12-18 16:43:59 -08:00

rdar35441779.swift

Add no-longer-crashing test case from rdar://problem/35441779.

2017-11-16 11:36:52 -08:00

sr5330.swift

Avoid building conformance lookup tables when we don't have to.

2017-07-05 11:23:27 -07:00

sr-5836.swift

Sema: Fix a failure to emit a diagnostic

2017-09-27 16:39:06 -07:00