Files
swift-mirror/lib/SILOptimizer/LoopTransforms/LoopUnroll.cpp
Andrew Trick bd28b0ea1b SILCloner and SILInliner rewrite.
Mostly functionally neutral:
- may fix latent bugs.
- may reduce useless basic blocks after inlining.

This rewrite encapsulates the cloner's internal state, providing a
clean API for the CRTP subclasses. The subclasses are rewritten to use
the exposed API and extension points. This makes it much easier to
understand, work with, and extend SIL cloners, which are central to
many optimization passes. Basic SIL invariants are now clearly
expressed and enforced. There is no longer a intricate dance between
multiple levels of subclasses operating on underlying low-level data
structures. All of the logic needed to keep the original SIL in a
consistent state is contained within the SILCloner itself. Subclasses
only need to be responsible for their own modifications.

The immediate motiviation is to make CFG updates self-contained so
that SIL remains in a valid state. This will allow the removal of
critical edge splitting hacks and will allow general SIL utilities to
take advantage of the fact that we don't allow critical edges.

This rewrite establishes a simple principal that should be followed
everywhere: aside from the primitive mutation APIs on SIL data types,
each SIL utility is responsibile for leaving SIL in a valid state and
the logic for doing so should exist in one central location.

This includes, for example:
- Generating a valid CFG, splitting edges if needed.
- Returning a valid instruction iterator if any instructions are removed.
- Updating dominance.
- Updating SSA (block arguments).

(Dominance info and SSA properties are fundamental to SIL verification).

LoopInfo is also somewhat fundamental to SIL, and should generally be
updated, but it isn't required.

This also fixes some latent bugs related to iterator invalidation in
recursivelyDeleteTriviallyDeadInstructions and SILInliner. Note that
the SILModule deletion callback should be avoided. It can be useful as
a simple cache invalidation mechanism, but it is otherwise bug prone,
too limited to be very useful, and basically bad design. Utilities
that mutate should return a valid instruction iterator and provide
their own deletion callbacks.
2018-10-08 19:30:09 -07:00

458 lines
15 KiB
C++

//===--- LoopUnroll.cpp - Loop unrolling ----------------------------------===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2014 - 2017 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//
#define DEBUG_TYPE "sil-loopunroll"
#include "llvm/ADT/DepthFirstIterator.h"
#include "swift/SIL/PatternMatch.h"
#include "swift/SIL/SILCloner.h"
#include "swift/SILOptimizer/Analysis/LoopAnalysis.h"
#include "swift/SILOptimizer/PassManager/Passes.h"
#include "swift/SILOptimizer/PassManager/Transforms.h"
#include "swift/SILOptimizer/Utils/PerformanceInlinerUtils.h"
#include "swift/SILOptimizer/Utils/SILInliner.h"
#include "swift/SILOptimizer/Utils/SILSSAUpdater.h"
using namespace swift;
using namespace swift::PatternMatch;
using llvm::DenseMap;
using llvm::MapVector;
namespace {
/// Clone the basic blocks in a loop.
class LoopCloner : public SILCloner<LoopCloner> {
SILLoop *Loop;
friend class SILInstructionVisitor<LoopCloner>;
friend class SILCloner<LoopCloner>;
public:
LoopCloner(SILLoop *Loop)
: SILCloner<LoopCloner>(*Loop->getHeader()->getParent()), Loop(Loop) {}
/// Clone the basic blocks in the loop.
void cloneLoop();
// Update SSA helper.
void collectLoopLiveOutValues(
DenseMap<SILValue, SmallVector<SILValue, 8>> &LoopLiveOutValues);
protected:
// SILCloner CRTP override.
SILValue remapValue(SILValue V) {
if (auto *BB = V->getParentBlock()) {
if (!Loop->contains(BB))
return V;
}
return SILCloner<LoopCloner>::remapValue(V);
}
// SILCloner CRTP override.
void postProcess(SILInstruction *Orig, SILInstruction *Cloned) {
SILCloner<LoopCloner>::postProcess(Orig, Cloned);
}
};
} // end anonymous namespace
void LoopCloner::cloneLoop() {
SmallVector<SILBasicBlock *, 16> ExitBlocks;
Loop->getExitBlocks(ExitBlocks);
// Clone the entire loop.
cloneReachableBlocks(Loop->getHeader(), ExitBlocks);
}
/// Determine the number of iterations the loop is at most executed. The loop
/// might contain early exits so this is the maximum if no early exits are
/// taken.
static Optional<uint64_t> getMaxLoopTripCount(SILLoop *Loop,
SILBasicBlock *Preheader,
SILBasicBlock *Header,
SILBasicBlock *Latch) {
// Skip a split backedge.
SILBasicBlock *OrigLatch = Latch;
if (!Loop->isLoopExiting(Latch) &&
!(Latch = Latch->getSinglePredecessorBlock()))
return None;
if (!Loop->isLoopExiting(Latch))
return None;
// Get the loop exit condition.
auto *CondBr = dyn_cast<CondBranchInst>(Latch->getTerminator());
if (!CondBr)
return None;
// Match an add 1 recurrence.
SILPhiArgument *RecArg;
IntegerLiteralInst *End;
SILValue RecNext;
unsigned Adjust = 0;
if (!match(CondBr->getCondition(),
m_BuiltinInst(BuiltinValueKind::ICMP_EQ, m_SILValue(RecNext),
m_IntegerLiteralInst(End))) &&
!match(CondBr->getCondition(),
m_BuiltinInst(BuiltinValueKind::ICMP_SGE, m_SILValue(RecNext),
m_IntegerLiteralInst(End)))) {
if (!match(CondBr->getCondition(),
m_BuiltinInst(BuiltinValueKind::ICMP_SGT, m_SILValue(RecNext),
m_IntegerLiteralInst(End))))
return None;
// Otherwise, we have a greater than comparison.
else
Adjust = 1;
}
if (!match(RecNext,
m_TupleExtractInst(m_ApplyInst(BuiltinValueKind::SAddOver,
m_SILPhiArgument(RecArg), m_One()),
0)))
return None;
if (RecArg->getParent() != Header)
return None;
auto *Start = dyn_cast_or_null<IntegerLiteralInst>(
RecArg->getIncomingPhiValue(Preheader));
if (!Start)
return None;
if (RecNext != RecArg->getIncomingPhiValue(OrigLatch))
return None;
auto StartVal = Start->getValue();
auto EndVal = End->getValue();
if (StartVal.sgt(EndVal))
return None;
auto Dist = EndVal - StartVal;
if (Dist.getBitWidth() > 64)
return None;
if (Dist == 0)
return None;
return Dist.getZExtValue() + Adjust;
}
/// Check whether we can duplicate the instructions in the loop and use a
/// heuristic that looks at the trip count and the cost of the instructions in
/// the loop to determine whether we should unroll this loop.
static bool canAndShouldUnrollLoop(SILLoop *Loop, uint64_t TripCount) {
assert(Loop->getSubLoops().empty() && "Expect innermost loops");
if (TripCount > 32)
return false;
// We can unroll a loop if we can duplicate the instructions it holds.
uint64_t Cost = 0;
// Average number of instructions per basic block.
// It is used to estimate the cost of the callee
// inside a loop.
const uint64_t InsnsPerBB = 4;
// Use command-line threshold for unrolling.
const uint64_t SILLoopUnrollThreshold = Loop->getBlocks().empty() ? 0 :
(Loop->getBlocks())[0]->getParent()->getModule().getOptions().UnrollThreshold;
for (auto *BB : Loop->getBlocks()) {
for (auto &Inst : *BB) {
if (!Loop->canDuplicate(&Inst))
return false;
if (instructionInlineCost(Inst) != InlineCost::Free)
++Cost;
if (auto AI = FullApplySite::isa(&Inst)) {
auto Callee = AI.getCalleeFunction();
if (Callee && getEligibleFunction(AI, InlineSelection::Everything)) {
// If callee is rather big and potentialy inlinable, it may be better
// not to unroll, so that the body of the calle can be inlined later.
Cost += Callee->size() * InsnsPerBB;
}
}
if (Cost * TripCount > SILLoopUnrollThreshold)
return false;
}
}
return true;
}
/// Redirect the terminator of the current loop iteration's latch to the next
/// iterations header or if this is the last iteration remove the backedge to
/// the header.
static void redirectTerminator(SILBasicBlock *Latch, unsigned CurLoopIter,
unsigned LastLoopIter, SILBasicBlock *OrigHeader,
SILBasicBlock *NextIterationsHeader) {
auto *CurrentTerminator = Latch->getTerminator();
// We can either have a split backedge as our latch terminator.
// HeaderBlock:
// ...
// cond_br %cond, ExitBlock, BackedgeBlock
//
// BackedgeBlock:
// br HeaderBlock:
//
// Or a conditional branch back to the header.
// HeaderBlock:
// ...
// cond_br %cond, ExitBlock, HeaderBlock
//
// Redirect the HeaderBlock target to the unrolled successor. In the
// unrolled block of the last iteration unconditionally jump to the
// ExitBlock instead.
// Handle the split backedge case.
if (auto *Br = dyn_cast<BranchInst>(CurrentTerminator)) {
// On the last iteration change the conditional exit to an unconditional
// one.
if (CurLoopIter == LastLoopIter) {
auto *CondBr = cast<CondBranchInst>(
Latch->getSinglePredecessorBlock()->getTerminator());
if (CondBr->getTrueBB() != Latch)
SILBuilder(CondBr).createBranch(CondBr->getLoc(), CondBr->getTrueBB(),
CondBr->getTrueArgs());
else
SILBuilder(CondBr).createBranch(CondBr->getLoc(), CondBr->getFalseBB(),
CondBr->getFalseArgs());
CondBr->eraseFromParent();
return;
}
// Otherwise, branch to the next iteration's header.
SILBuilder(Br).createBranch(Br->getLoc(), NextIterationsHeader,
Br->getArgs());
Br->eraseFromParent();
return;
}
// Otherwise, we have a conditional branch to the header.
auto *CondBr = cast<CondBranchInst>(CurrentTerminator);
// On the last iteration change the conditional exit to an unconditional
// one.
if (CurLoopIter == LastLoopIter) {
if (CondBr->getTrueBB() != OrigHeader)
SILBuilder(CondBr).createBranch(CondBr->getLoc(), CondBr->getTrueBB(),
CondBr->getTrueArgs());
else
SILBuilder(CondBr).createBranch(CondBr->getLoc(), CondBr->getFalseBB(),
CondBr->getFalseArgs());
CondBr->eraseFromParent();
return;
}
// Otherwise, branch to the next iteration's header.
if (CondBr->getTrueBB() == OrigHeader) {
SILBuilder(CondBr).createCondBranch(
CondBr->getLoc(), CondBr->getCondition(), NextIterationsHeader,
CondBr->getTrueArgs(), CondBr->getFalseBB(), CondBr->getFalseArgs());
} else {
SILBuilder(CondBr).createCondBranch(
CondBr->getLoc(), CondBr->getCondition(), CondBr->getTrueBB(),
CondBr->getTrueArgs(), NextIterationsHeader, CondBr->getFalseArgs());
}
CondBr->eraseFromParent();
}
/// Collect all the loop live out values in the map that maps original live out
/// value to live out value in the cloned loop.
void LoopCloner::collectLoopLiveOutValues(
DenseMap<SILValue, SmallVector<SILValue, 8>> &LoopLiveOutValues) {
for (auto *Block : Loop->getBlocks()) {
// Look at block arguments.
for (auto *Arg : Block->getArguments()) {
for (auto *Op : Arg->getUses()) {
// Is this use outside the loop?
if (!Loop->contains(Op->getUser())) {
auto ArgumentValue = SILValue(Arg);
if (!LoopLiveOutValues.count(ArgumentValue))
LoopLiveOutValues[ArgumentValue].push_back(
remapValue(ArgumentValue));
}
}
}
// And the instructions.
for (auto &Inst : *Block) {
for (SILValue result : Inst.getResults()) {
for (auto *Op : result->getUses()) {
// Ignore uses inside the loop.
if (Loop->contains(Op->getUser()))
continue;
auto UsedValue = Op->get();
assert(UsedValue == result && "Instructions must match");
if (!LoopLiveOutValues.count(UsedValue))
LoopLiveOutValues[UsedValue].push_back(remapValue(result));
}
}
}
}
}
static void
updateSSA(SILLoop *Loop,
DenseMap<SILValue, SmallVector<SILValue, 8>> &LoopLiveOutValues) {
SILSSAUpdater SSAUp;
for (auto &MapEntry : LoopLiveOutValues) {
// Collect out of loop uses of this value.
auto OrigValue = MapEntry.first;
SmallVector<UseWrapper, 16> UseList;
for (auto Use : OrigValue->getUses())
if (!Loop->contains(Use->getUser()->getParent()))
UseList.push_back(UseWrapper(Use));
// Update SSA of use with the available values.
SSAUp.Initialize(OrigValue->getType());
SSAUp.AddAvailableValue(OrigValue->getParentBlock(), OrigValue);
for (auto NewValue : MapEntry.second)
SSAUp.AddAvailableValue(NewValue->getParentBlock(), NewValue);
for (auto U : UseList) {
Operand *Use = U;
SSAUp.RewriteUse(*Use);
}
}
}
/// Try to fully unroll the loop if we can determine the trip count and the trip
/// count lis below a threshold.
static bool tryToUnrollLoop(SILLoop *Loop) {
assert(Loop->getSubLoops().empty() && "Expecting innermost loops");
auto *Preheader = Loop->getLoopPreheader();
if (!Preheader)
return false;
auto *Latch = Loop->getLoopLatch();
if (!Latch)
return false;
auto *Header = Loop->getHeader();
Optional<uint64_t> MaxTripCount =
getMaxLoopTripCount(Loop, Preheader, Header, Latch);
if (!MaxTripCount)
return false;
if (!canAndShouldUnrollLoop(Loop, MaxTripCount.getValue()))
return false;
// TODO: We need to split edges from non-condbr exits for the SSA updater. For
// now just don't handle loops containing such exits.
SmallVector<SILBasicBlock *, 16> ExitingBlocks;
Loop->getExitingBlocks(ExitingBlocks);
for (auto &Exit : ExitingBlocks)
if (!isa<CondBranchInst>(Exit->getTerminator()))
return false;
LLVM_DEBUG(llvm::dbgs() << "Unrolling loop in "
<< Header->getParent()->getName()
<< " " << *Loop << "\n");
SmallVector<SILBasicBlock *, 16> Headers;
Headers.push_back(Header);
SmallVector<SILBasicBlock *, 16> Latches;
Latches.push_back(Latch);
DenseMap<SILValue, SmallVector<SILValue, 8>> LoopLiveOutValues;
// Copy the body MaxTripCount-1 times.
for (uint64_t Cnt = 1; Cnt < *MaxTripCount; ++Cnt) {
// Clone the blocks in the loop.
LoopCloner cloner(Loop);
cloner.cloneLoop();
Headers.push_back(cloner.getOpBasicBlock(Header));
Latches.push_back(cloner.getOpBasicBlock(Latch));
// Collect values defined in the loop but used outside. On the first
// iteration we populate the map from original loop to cloned loop. On
// subsequent iterations we only need to update this map with the values
// from the new iteration's clone.
if (Cnt == 1)
cloner.collectLoopLiveOutValues(LoopLiveOutValues);
else {
for (auto &MapEntry : LoopLiveOutValues) {
// Look it up in the value map.
SILValue MappedValue = cloner.getOpValue(MapEntry.first);
MapEntry.second.push_back(MappedValue);
assert(MapEntry.second.size() == Cnt);
}
}
}
// Thread the loop clones by redirecting the loop latches to the successor
// iteration's header.
for (unsigned Iteration = 0, End = Latches.size(); Iteration != End;
++Iteration) {
auto *CurrentLatch = Latches[Iteration];
auto LastIteration = End - 1;
auto *OriginalHeader = Headers[0];
auto *NextIterationsHeader =
Iteration == LastIteration ? nullptr : Headers[Iteration + 1];
redirectTerminator(CurrentLatch, Iteration, LastIteration, OriginalHeader,
NextIterationsHeader);
}
// Fixup SSA form for loop values used outside the loop.
updateSSA(Loop, LoopLiveOutValues);
return true;
}
// =============================================================================
// Driver
// =============================================================================
namespace {
class LoopUnrolling : public SILFunctionTransform {
void run() override {
bool Changed = false;
auto *Fun = getFunction();
SILLoopInfo *LoopInfo = PM->getAnalysis<SILLoopAnalysis>()->get(Fun);
// Collect innermost loops.
SmallVector<SILLoop *, 16> InnermostLoops;
for (auto *Loop : *LoopInfo) {
SmallVector<SILLoop *, 8> Worklist;
Worklist.push_back(Loop);
for (unsigned i = 0; i < Worklist.size(); ++i) {
auto *L = Worklist[i];
for (auto *SubLoop : *L)
Worklist.push_back(SubLoop);
if (L->getSubLoops().empty())
InnermostLoops.push_back(L);
}
}
// Try to unroll innermost loops.
for (auto *Loop : InnermostLoops)
Changed |= tryToUnrollLoop(Loop);
if (Changed) {
invalidateAnalysis(SILAnalysis::InvalidationKind::FunctionBody);
}
}
};
} // end anonymous namespace
SILTransform *swift::createLoopUnroll() {
return new LoopUnrolling();
}