Files
swift-mirror/lib/SIL/Utils/OptimizationRemark.cpp
Michael Gottesman c54fb33911 [opt-remark] Infer the source loc retain, release even if they have non-inlined locs.
The reason why is that due to ARCCodeMotion, they could have moved enough that
the SourceLoc on them is incorrect. That is why you can see in the tests that I
had to update, I am moving the retain to the return statement from the body of
the function since the retain was now right before the return.

I also went in and cleaned up the logic here a little bit. What we do now is
that we have a notion of instructions that we /always/ infer SourceLocs for (rr)
and ones that if we have a valid non-inlined location we use (e.x.:
allocations).

This mucked a little bit with my ability to run SIL tests since the SIL tests
were relying on this not happening to rr so that we would emit remarks on the rr
instructions themselves. I added an option that disables the always infer
behavior for this test.

That being said at this point to me it seems like the SourceLoc inference stuff
is really tied to OptRemarkGenerator and I am going to see if I can move it to
there. But that is for a future commit on another day.
2020-09-04 20:13:24 -07:00

280 lines
9.5 KiB
C++

//===--- OptimizationRemark.cpp - Optimization diagnostics ------*- C++ -*-===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2014 - 2017 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//
//
/// \file
/// This file defines the remark type and the emitter class that passes can use
/// to emit optimization diagnostics.
//
//===----------------------------------------------------------------------===//
#include "swift/SIL/OptimizationRemark.h"
#include "swift/AST/DiagnosticEngine.h"
#include "swift/AST/DiagnosticsSIL.h"
#include "swift/AST/SemanticAttrs.h"
#include "swift/Demangling/Demangler.h"
#include "swift/SIL/DebugUtils.h"
#include "swift/SIL/InstructionUtils.h"
#include "swift/SIL/MemAccessUtils.h"
#include "swift/SIL/Projection.h"
#include "swift/SIL/SILArgument.h"
#include "swift/SIL/SILInstruction.h"
#include "swift/SIL/SILRemarkStreamer.h"
#include "llvm/ADT/StringExtras.h"
#include "llvm/Support/CommandLine.h"
#include "llvm/Support/raw_ostream.h"
using namespace swift;
using namespace OptRemark;
Argument::Argument(StringRef key, int n)
: key(ArgumentKeyKind::Default, key), val(llvm::itostr(n)) {}
Argument::Argument(StringRef key, long n)
: key(ArgumentKeyKind::Default, key), val(llvm::itostr(n)) {}
Argument::Argument(StringRef key, long long n)
: key(ArgumentKeyKind::Default, key), val(llvm::itostr(n)) {}
Argument::Argument(StringRef key, unsigned n)
: key(ArgumentKeyKind::Default, key), val(llvm::utostr(n)) {}
Argument::Argument(StringRef key, unsigned long n)
: key(ArgumentKeyKind::Default, key), val(llvm::utostr(n)) {}
Argument::Argument(StringRef key, unsigned long long n)
: key(ArgumentKeyKind::Default, key), val(llvm::utostr(n)) {}
Argument::Argument(ArgumentKey key, SILFunction *f) : key(key) {
auto options = Demangle::DemangleOptions::SimplifiedUIDemangleOptions();
// Enable module names so that we have a way of filtering out
// stdlib-related remarks.
options.DisplayModuleNames = true;
val = (Twine("\"") + Demangle::demangleSymbolAsString(f->getName(), options) +
"\"")
.str();
if (f->hasLocation())
loc = f->getLocation().getSourceLoc();
}
Argument::Argument(StringRef key, SILType ty)
: key(ArgumentKeyKind::Default, key) {
llvm::raw_string_ostream stream(val);
PrintOptions subPrinter = PrintOptions::printSIL();
ty.getASTType().print(stream, subPrinter);
}
Argument::Argument(StringRef key, CanType ty)
: key(ArgumentKeyKind::Default, key) {
llvm::raw_string_ostream stream(val);
ty.print(stream);
}
template <typename DerivedT>
std::string Remark<DerivedT>::getMsg() const {
std::string str;
llvm::raw_string_ostream stream(str);
// Go through our args and if we are not emitting for diagnostics *OR* we are
// emitting for diagnostics and this argument is not intended to be emitted as
// a diagnostic separate from our main remark, emit the arg value here.
for (const Argument &arg : args) {
if (arg.key.kind.isSeparateDiagnostic())
continue;
stream << arg.val;
}
return stream.str();
}
template <typename DerivedT>
std::string Remark<DerivedT>::getDebugMsg() const {
std::string str;
llvm::raw_string_ostream stream(str);
if (indentDebugWidth)
stream << std::string(" ", indentDebugWidth);
for (const Argument &arg : args)
stream << arg.val;
stream << "\n";
return stream.str();
}
static bool hasForceEmitSemanticAttr(SILFunction &fn, StringRef passName) {
return llvm::any_of(fn.getSemanticsAttrs(), [&](const std::string &str) {
auto ref = StringRef(str);
// First try to chomp the prefix.
if (!ref.consume_front(semantics::FORCE_EMIT_OPT_REMARK_PREFIX))
return false;
// Then see if we only have the prefix. Then always return true the user
// wants /all/ remarks.
if (ref.empty())
return true;
// Otherwise, lets try to chomp the '.' and then the passName.
if (!ref.consume_front(".") || !ref.consume_front(passName))
return false;
return ref.empty();
});
}
Emitter::Emitter(StringRef passName, SILFunction &fn)
: fn(fn), passName(passName),
passedEnabled(
hasForceEmitSemanticAttr(fn, passName) ||
(fn.getASTContext().LangOpts.OptimizationRemarkPassedPattern &&
fn.getASTContext().LangOpts.OptimizationRemarkPassedPattern->match(
passName))),
missedEnabled(
hasForceEmitSemanticAttr(fn, passName) ||
(fn.getASTContext().LangOpts.OptimizationRemarkMissedPattern &&
fn.getASTContext().LangOpts.OptimizationRemarkMissedPattern->match(
passName))) {}
/// The user has passed us an instruction that for some reason has a source loc
/// that can not be used. Search down the current block for an instruction with
/// a valid source loc and use that instead.
static SourceLoc inferOptRemarkSearchForwards(SILInstruction &i) {
for (auto &inst :
llvm::make_range(std::next(i.getIterator()), i.getParent()->end())) {
auto newLoc = inst.getLoc().getSourceLoc();
if (auto inlinedLoc = inst.getDebugScope()->getOutermostInlineLocation())
newLoc = inlinedLoc.getSourceLoc();
if (newLoc.isValid())
return newLoc;
}
return SourceLoc();
}
/// The user has passed us an instruction that for some reason has a source loc
/// that can not be used. Search up the current block for an instruction with
/// a valid SILLocation and use the end SourceLoc of the SourceRange for the
/// instruction.
static SourceLoc inferOptRemarkSearchBackwards(SILInstruction &i) {
for (auto &inst : llvm::make_range(std::next(i.getReverseIterator()),
i.getParent()->rend())) {
auto loc = inst.getLoc();
if (auto inlinedLoc = inst.getDebugScope()->getOutermostInlineLocation())
loc = inlinedLoc;
if (!loc.getSourceLoc().isValid())
continue;
auto range = loc.getSourceRange();
if (range.isValid())
return range.End;
}
return SourceLoc();
}
static llvm::cl::opt<bool> IgnoreAlwaysInferForTesting(
"sil-opt-remark-ignore-always-infer", llvm::cl::Hidden,
llvm::cl::init(false),
llvm::cl::desc(
"Disables always infer source loc behavior for testing purposes"));
// Attempt to infer a SourceLoc for \p i using heuristics specified by \p
// inferBehavior.
//
// NOTE: We distinguish in between situations where we always must infer
// (retain, release) and other situations where we are ok with original source
// locs if we are not inlined (alloc_ref, alloc_stack).
SourceLoc swift::OptRemark::inferOptRemarkSourceLoc(
SILInstruction &i, SourceLocInferenceBehavior inferBehavior) {
// If we are only supposed to infer in inline contexts, see if we have a valid
// loc and if that loc is an inlined call site.
auto loc = i.getLoc();
if (loc.getSourceLoc().isValid() &&
!(bool(inferBehavior & SourceLocInferenceBehavior::AlwaysInfer) &&
!IgnoreAlwaysInferForTesting) &&
!(i.getDebugScope() && i.getDebugScope()->InlinedCallSite))
return loc.getSourceLoc();
if (bool(inferBehavior & SourceLocInferenceBehavior::ForwardScan)) {
SourceLoc newLoc = inferOptRemarkSearchForwards(i);
if (newLoc.isValid())
return newLoc;
}
if (bool(inferBehavior & SourceLocInferenceBehavior::BackwardScan)) {
SourceLoc newLoc = inferOptRemarkSearchBackwards(i);
if (newLoc.isValid())
return newLoc;
}
if (bool(inferBehavior & SourceLocInferenceBehavior::ForwardScan2nd)) {
SourceLoc newLoc = inferOptRemarkSearchForwards(i);
if (newLoc.isValid())
return newLoc;
}
return SourceLoc();
}
template <typename RemarkT, typename... ArgTypes>
static void emitRemark(SILFunction &fn, const Remark<RemarkT> &remark,
Diag<ArgTypes...> id, bool diagEnabled) {
if (remark.getLocation().isInvalid())
return;
auto &module = fn.getModule();
if (auto *remarkStreamer = module.getSILRemarkStreamer())
remarkStreamer->emit(remark);
// If diagnostics are enabled, first emit the main diagnostic and then loop
// through our arguments and allow the arguments to add additional diagnostics
// if they want.
if (!diagEnabled && !fn.hasSemanticsAttrThatStartsWith(
semantics::FORCE_EMIT_OPT_REMARK_PREFIX))
return;
auto &de = module.getASTContext().Diags;
de.diagnoseWithNotes(
de.diagnose(remark.getLocation(), id, remark.getMsg()), [&]() {
for (auto &arg : remark.getArgs()) {
switch (arg.key.kind) {
case ArgumentKeyKind::Default:
continue;
case ArgumentKeyKind::Note:
de.diagnose(arg.loc, diag::opt_remark_note, arg.val);
continue;
case ArgumentKeyKind::ParentLocNote:
de.diagnose(remark.getLocation(), diag::opt_remark_note, arg.val);
continue;
}
llvm_unreachable("Unhandled case?!");
}
});
}
void Emitter::emit(const RemarkPassed &remark) {
emitRemark(fn, remark, diag::opt_remark_passed, isEnabled<RemarkPassed>());
}
void Emitter::emit(const RemarkMissed &remark) {
emitRemark(fn, remark, diag::opt_remark_missed, isEnabled<RemarkMissed>());
}
void Emitter::emitDebug(const RemarkPassed &remark) {
llvm::dbgs() << remark.getDebugMsg();
}
void Emitter::emitDebug(const RemarkMissed &remark) {
llvm::dbgs() << remark.getDebugMsg();
}