mirror of
https://github.com/apple/swift.git
synced 2025-12-21 12:14:44 +01:00
This reverts commit r23725. This time with fixes so we don't hit that assertion. Swift SVN r23762
865 lines
30 KiB
C++
865 lines
30 KiB
C++
//===-- FunctionSignatureOpts.cpp - Optimizes function signatures ---------===//
|
|
//
|
|
// This source file is part of the Swift.org open source project
|
|
//
|
|
// Copyright (c) 2014 - 2015 Apple Inc. and the Swift project authors
|
|
// Licensed under Apache License v2.0 with Runtime Library Exception
|
|
//
|
|
// See http://swift.org/LICENSE.txt for license information
|
|
// See http://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#define DEBUG_TYPE "sil-function-signature-opts"
|
|
#include "swift/SILPasses/Passes.h"
|
|
#include "swift/SILAnalysis/CallGraphAnalysis.h"
|
|
#include "swift/SILAnalysis/RCIdentityAnalysis.h"
|
|
#include "swift/SILAnalysis/ARCAnalysis.h"
|
|
#include "swift/SILPasses/Transforms.h"
|
|
#include "swift/SILPasses/Utils/Local.h"
|
|
#include "swift/Basic/LLVM.h"
|
|
#include "swift/Basic/BlotMapVector.h"
|
|
#include "swift/Basic/Range.h"
|
|
#include "swift/SIL/Projection.h"
|
|
#include "swift/SIL/SILFunction.h"
|
|
#include "swift/SIL/SILCloner.h"
|
|
#include "swift/SIL/SILArgument.h"
|
|
#include "swift/SIL/SILValue.h"
|
|
#include "swift/SIL/SILDebugScope.h"
|
|
#include "llvm/ADT/SmallBitVector.h"
|
|
#include "llvm/ADT/SmallString.h"
|
|
#include "llvm/ADT/Statistic.h"
|
|
#include "llvm/Support/Debug.h"
|
|
#include <type_traits>
|
|
|
|
using namespace swift;
|
|
using namespace swift::arc;
|
|
|
|
STATISTIC(NumFunctionSignaturesOptimized, "Total func sig optimized");
|
|
STATISTIC(NumDeadArgsEliminated, "Total dead args eliminated");
|
|
STATISTIC(NumOwnedConvertedToGuaranteed, "Total owned args -> guaranteed args");
|
|
STATISTIC(NumCallSitesOptimized, "Total call sites optimized");
|
|
STATISTIC(NumSROAArguments, "Total SROA argumments optimized");
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
// Argument Analysis
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
namespace {
|
|
|
|
/// A structure that maintains all of the information about a specific
|
|
/// SILArgument that we are tracking.
|
|
struct ArgumentDescriptor {
|
|
|
|
/// The argument that we are tracking original data for.
|
|
SILArgument *Arg;
|
|
|
|
/// The original index of this argument.
|
|
unsigned Index;
|
|
|
|
/// The original parameter info of this argument.
|
|
SILParameterInfo ParameterInfo;
|
|
|
|
/// The original decl of this Argument.
|
|
const ValueDecl *Decl;
|
|
|
|
/// Was this parameter originally dead?
|
|
bool IsDead;
|
|
|
|
/// If non-null, this is the release in the callee associated with this
|
|
/// parameter if it is @owned. If the parameter is not @owned or we could not
|
|
/// find such a release in the callee, this is null.
|
|
SILInstruction *CalleeRelease;
|
|
|
|
/// The projection tree of this arguments.
|
|
ProjectionTree ProjTree;
|
|
|
|
ArgumentDescriptor() = default;
|
|
|
|
/// Initialize this argument descriptor with all information from A that we
|
|
/// use in our optimization.
|
|
///
|
|
/// *NOTE* We cache a lot of data from the argument and maintain a reference
|
|
/// to the original argument. The reason why we do this is to make sure we
|
|
/// have access to the original argument's state if we modify the argument
|
|
/// when optimizing.
|
|
ArgumentDescriptor(SILArgument *A)
|
|
: Arg(A), Index(A->getIndex()), ParameterInfo(A->getParameterInfo()),
|
|
Decl(A->getDecl()), IsDead(A->use_empty()), CalleeRelease(),
|
|
ProjTree(A->getModule(), A->getType()) {
|
|
ProjTree.computeUsesAndLiveness(A);
|
|
}
|
|
|
|
/// \returns true if this argument's ParameterConvention is P.
|
|
bool hasConvention(ParameterConvention P) const {
|
|
return Arg->hasConvention(P);
|
|
}
|
|
|
|
/// Convert the potentially multiple interface params associated with this
|
|
/// argument.
|
|
void
|
|
computeOptimizedInterfaceParams(SmallVectorImpl<SILParameterInfo> &Out) const;
|
|
|
|
/// Add potentially multiple new arguments to NewArgs from the caller's apply
|
|
/// inst.
|
|
void addCallerArgs(SILBuilder &Builder, ApplyInst *AI,
|
|
SmallVectorImpl<SILValue> &NewArgs) const;
|
|
|
|
/// Add potentially multiple new arguments to NewArgs from the thunk's
|
|
/// function arguments.
|
|
void addThunkArgs(SILBuilder &Builder, SILBasicBlock *BB,
|
|
SmallVectorImpl<SILValue> &NewArgs) const;
|
|
|
|
/// Optimize the argument at ArgOffset and return the index of the next
|
|
/// argument to be optimized.
|
|
///
|
|
/// The return value makes it easy to SROA arguments since we can return the
|
|
/// amount of SROAed arguments we created.
|
|
unsigned
|
|
updateOptimizedBBArgs(SILBuilder &Builder, SILBasicBlock *BB,
|
|
unsigned ArgOffset);
|
|
|
|
bool canOptimizeLiveArg() const {
|
|
return ParameterInfo.getSILType().isObject();
|
|
}
|
|
|
|
bool canExplodeValue() const {
|
|
return ProjTree.canExplodeValue() && canOptimizeLiveArg();
|
|
}
|
|
};
|
|
|
|
} // end anonymous namespace
|
|
|
|
void
|
|
ArgumentDescriptor::
|
|
computeOptimizedInterfaceParams(SmallVectorImpl<SILParameterInfo> &Out) const {
|
|
DEBUG(llvm::dbgs() << " Computing Interface Params\n");
|
|
// If we have a dead argument, bail.
|
|
if (IsDead) {
|
|
DEBUG(llvm::dbgs() << " Dead!\n");
|
|
return;
|
|
}
|
|
|
|
// If this argument is live, but we can not optimize it.
|
|
if (!canOptimizeLiveArg()) {
|
|
DEBUG(llvm::dbgs() << " Can not optimize live arg!\n");
|
|
Out.push_back(ParameterInfo);
|
|
return;
|
|
}
|
|
|
|
// If we can not explode this value, handle callee release and return.
|
|
if (!canExplodeValue()) {
|
|
DEBUG(llvm::dbgs() << " ProjTree can not explode arg.\n");
|
|
// If we found a release in the callee in the last BB on an @owned
|
|
// parameter, change the parameter to @guaranteed and continue...
|
|
if (CalleeRelease) {
|
|
DEBUG(llvm::dbgs() << " Has callee release.\n");
|
|
assert(ParameterInfo.getConvention() == ParameterConvention::Direct_Owned &&
|
|
"Can only transform @owned => @guaranteed in this code path");
|
|
SILParameterInfo NewInfo(ParameterInfo.getType(),
|
|
ParameterConvention::Direct_Guaranteed);
|
|
Out.push_back(NewInfo);
|
|
return;
|
|
}
|
|
|
|
DEBUG(llvm::dbgs() << " Does not have callee release.\n");
|
|
// Otherwise just propagate through the parameter info.
|
|
Out.push_back(ParameterInfo);
|
|
return;
|
|
}
|
|
|
|
DEBUG(llvm::dbgs() << " ProjTree can explode arg.\n");
|
|
// Ok, we need to use the projection tree. Iterate over the leafs of the
|
|
// tree...
|
|
llvm::SmallVector<SILType, 8> LeafTypes;
|
|
ProjTree.getLeafTypes(LeafTypes);
|
|
DEBUG(llvm::dbgs() << " Leafs:\n");
|
|
for (SILType Ty : LeafTypes) {
|
|
DEBUG(llvm::dbgs() << " " << Ty << "\n");
|
|
// If Ty is trivial, just pass it directly.
|
|
if (Ty.isTrivial(Arg->getModule())) {
|
|
SILParameterInfo NewInfo(Ty.getSwiftRValueType(),
|
|
ParameterConvention::Direct_Unowned);
|
|
Out.push_back(NewInfo);
|
|
continue;
|
|
}
|
|
|
|
// If Ty is guaranteed, just pass it through.
|
|
ParameterConvention Conv = ParameterInfo.getConvention();
|
|
if (Conv == ParameterConvention::Direct_Guaranteed) {
|
|
assert(!CalleeRelease && "Guaranteed parameter should not have a callee "
|
|
"release.");
|
|
SILParameterInfo NewInfo(Ty.getSwiftRValueType(),
|
|
ParameterConvention::Direct_Guaranteed);
|
|
Out.push_back(NewInfo);
|
|
continue;
|
|
}
|
|
|
|
// If Ty is not trivial and we found a callee release, pass it as
|
|
// guaranteed.
|
|
assert(ParameterInfo.getConvention() == ParameterConvention::Direct_Owned
|
|
&& "Can only transform @owned => @guaranteed in this code path");
|
|
if (CalleeRelease) {
|
|
SILParameterInfo NewInfo(Ty.getSwiftRValueType(),
|
|
ParameterConvention::Direct_Guaranteed);
|
|
Out.push_back(NewInfo);
|
|
continue;
|
|
}
|
|
|
|
// Otherwise, just add Ty as an @owned parameter.
|
|
SILParameterInfo NewInfo(Ty.getSwiftRValueType(),
|
|
ParameterConvention::Direct_Owned);
|
|
Out.push_back(NewInfo);
|
|
}
|
|
}
|
|
|
|
void
|
|
ArgumentDescriptor::
|
|
addCallerArgs(SILBuilder &B, ApplyInst *AI,
|
|
llvm::SmallVectorImpl<SILValue> &NewArgs) const {
|
|
if (IsDead)
|
|
return;
|
|
|
|
if (!canExplodeValue()) {
|
|
NewArgs.push_back(AI->getArgument(Index));
|
|
return;
|
|
}
|
|
|
|
ProjTree.createTreeFromValue(B, AI->getLoc(), AI->getArgument(Index),
|
|
NewArgs);
|
|
}
|
|
|
|
void
|
|
ArgumentDescriptor::
|
|
addThunkArgs(SILBuilder &Builder, SILBasicBlock *BB,
|
|
llvm::SmallVectorImpl<SILValue> &NewArgs) const {
|
|
if (IsDead)
|
|
return;
|
|
|
|
if (!canExplodeValue()) {
|
|
NewArgs.push_back(BB->getBBArg(Index));
|
|
return;
|
|
}
|
|
|
|
ProjTree.createTreeFromValue(Builder, BB->getParent()->getLocation(),
|
|
BB->getBBArg(Index), NewArgs);
|
|
}
|
|
|
|
unsigned
|
|
ArgumentDescriptor::
|
|
updateOptimizedBBArgs(SILBuilder &Builder, SILBasicBlock *BB,
|
|
unsigned ArgOffset) {
|
|
// If this argument is dead delete this argument and return ArgOffset.
|
|
if (IsDead) {
|
|
BB->eraseBBArg(ArgOffset);
|
|
return ArgOffset;
|
|
}
|
|
|
|
// If this argument is not dead and we did not perform SROA, increment the
|
|
// offset and return.
|
|
if (!canExplodeValue()) {
|
|
return ArgOffset + 1;
|
|
}
|
|
|
|
// Create values for the leaf types.
|
|
llvm::SmallVector<SILValue, 8> LeafValues;
|
|
|
|
// Create a reference to the old arg offset and increment arg offset so we can
|
|
// create the new arguments.
|
|
unsigned OldArgOffset = ArgOffset++;
|
|
|
|
// We do this in the same order as leaf types since ProjTree expects that the
|
|
// order of leaf values matches the order of leaf types.
|
|
{
|
|
llvm::SmallVector<SILType, 8> LeafTypes;
|
|
ProjTree.getLeafTypes(LeafTypes);
|
|
for (auto Ty : LeafTypes) {
|
|
LeafValues.push_back(BB->insertBBArg(ArgOffset++, Ty, BB->getBBArg(OldArgOffset)->getDecl()));
|
|
}
|
|
}
|
|
|
|
// Then go through the projection tree constructing aggregates and replacing
|
|
// uses.
|
|
//
|
|
// TODO: What is the right location to use here?
|
|
ProjTree.replaceValueUsesWithLeafUses(Builder, BB->getParent()->getLocation(),
|
|
LeafValues);
|
|
|
|
// Replace all uses of the the original arg with undef so it does not have any
|
|
// uses.
|
|
SILValue OrigArg = SILValue(BB->getBBArg(OldArgOffset));
|
|
OrigArg.replaceAllUsesWith(SILUndef::get(OrigArg.getType(),
|
|
BB->getModule()));
|
|
|
|
// Now erase the old argument since it does not have any uses. We also
|
|
// decrement ArgOffset since we have one less argument now.
|
|
BB->eraseBBArg(OldArgOffset);
|
|
--ArgOffset;
|
|
|
|
return ArgOffset;
|
|
}
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
// Function Analyzer
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
namespace {
|
|
|
|
template <typename T1, typename T2>
|
|
inline T1 getFirstPairElt(const std::pair<T1, T2> &P) { return P.first; }
|
|
|
|
/// A class that contains all analysis information we gather about our
|
|
/// function. Also provides utility methods for creating the new empty function.
|
|
class FunctionAnalyzer {
|
|
RCIdentityAnalysis *RCIA;
|
|
|
|
/// The function that we are analyzing.
|
|
SILFunction *F;
|
|
|
|
/// Did we ascertain that we can optimize this function?
|
|
bool ShouldOptimize;
|
|
|
|
/// A list of structures which present a "view" of precompiled information on
|
|
/// an argument that we will use during our optimization.
|
|
llvm::SmallVector<ArgumentDescriptor, 8> ArgDescList;
|
|
|
|
public:
|
|
FunctionAnalyzer() = delete;
|
|
FunctionAnalyzer(const FunctionAnalyzer &) = delete;
|
|
FunctionAnalyzer(FunctionAnalyzer &&) = delete;
|
|
|
|
FunctionAnalyzer(RCIdentityAnalysis *RCIA, SILFunction *F)
|
|
: RCIA(RCIA), F(F), ShouldOptimize(false), ArgDescList() {}
|
|
|
|
/// Analyze the given function.
|
|
bool analyze();
|
|
|
|
/// Returns the managled name of the function that should be generated from
|
|
/// this function analyzer.
|
|
llvm::SmallString<64> getOptimizedName();
|
|
|
|
/// Create a new empty function with the optimized signature found by this
|
|
/// analysis.
|
|
///
|
|
/// *NOTE* This occurs in the same module as F.
|
|
SILFunction *createEmptyFunctionWithOptimizedSig(llvm::SmallString<64> &Name);
|
|
|
|
ArrayRef<ArgumentDescriptor> getArgDescList() const { return ArgDescList; }
|
|
MutableArrayRef<ArgumentDescriptor> getArgDescList() { return ArgDescList; }
|
|
|
|
private:
|
|
/// Compute the CanSILFunctionType for the optimized function.
|
|
CanSILFunctionType createOptimizedSILFunctionType();
|
|
};
|
|
|
|
} // end anonymous namespace
|
|
|
|
/// This function goes through the arguments of F and sees if we have anything
|
|
/// to optimize in which case it returns true. If we have nothing to optimize,
|
|
/// it returns false.
|
|
bool
|
|
FunctionAnalyzer::analyze() {
|
|
// For now ignore functions with indirect results.
|
|
if (F->getLoweredFunctionType()->hasIndirectResult())
|
|
return false;
|
|
|
|
ArrayRef<SILArgument *> Args = F->begin()->getBBArgs();
|
|
|
|
// A map from consumed SILArguments to the release associated with an
|
|
// argument.
|
|
ConsumedArgToEpilogueReleaseMatcher ArgToEpilogueReleaseMap(RCIA, F);
|
|
for (unsigned i = 0, e = Args.size(); i != e; ++i) {
|
|
ArgumentDescriptor A{Args[i]};
|
|
|
|
if (A.IsDead) {
|
|
ShouldOptimize = true;
|
|
++NumDeadArgsEliminated;
|
|
}
|
|
|
|
// See if we can find a ref count equivalent strong_release or release_value
|
|
// at the end of this function if our argument is an @owned parameter.
|
|
if (A.hasConvention(ParameterConvention::Direct_Owned)) {
|
|
if (auto *Release = ArgToEpilogueReleaseMap.releaseForArgument(A.Arg)) {
|
|
A.CalleeRelease = Release;
|
|
ShouldOptimize = true;
|
|
++NumOwnedConvertedToGuaranteed;
|
|
}
|
|
}
|
|
|
|
if (A.ProjTree.canExplodeValue()) {
|
|
ShouldOptimize = true;
|
|
++NumSROAArguments;
|
|
}
|
|
|
|
// Add the argument to our list.
|
|
ArgDescList.push_back(A);
|
|
}
|
|
|
|
return ShouldOptimize;
|
|
}
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
// Creating the New Function
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
CanSILFunctionType
|
|
FunctionAnalyzer::createOptimizedSILFunctionType() {
|
|
const ASTContext &Ctx = F->getModule().getASTContext();
|
|
CanSILFunctionType FTy = F->getLoweredFunctionType();
|
|
|
|
// The only way that we modify the arity of function parameters is here for
|
|
// dead arguments. Doing anything else is unsafe since by definition non-dead
|
|
// arguments will have SSA uses in the function. We would need to be smarter
|
|
// in our moving to handle such cases.
|
|
llvm::SmallVector<SILParameterInfo, 8> InterfaceParams;
|
|
for (auto &ArgDesc : ArgDescList) {
|
|
ArgDesc.computeOptimizedInterfaceParams(InterfaceParams);
|
|
}
|
|
|
|
SILResultInfo InterfaceResult = FTy->getResult();
|
|
|
|
return SILFunctionType::get(FTy->getGenericSignature(),
|
|
FTy->getExtInfo(),
|
|
FTy->getCalleeConvention(),
|
|
InterfaceParams, InterfaceResult, Ctx);
|
|
}
|
|
|
|
SILFunction *
|
|
FunctionAnalyzer::
|
|
createEmptyFunctionWithOptimizedSig(llvm::SmallString<64> &NewFName) {
|
|
SILModule &M = F->getModule();
|
|
|
|
// Create the new optimized function type.
|
|
CanSILFunctionType NewFTy = createOptimizedSILFunctionType();
|
|
|
|
// Create the new function.
|
|
auto *NewDebugScope = new (M) SILDebugScope(*F->getDebugScope());
|
|
SILFunction *NewF = SILFunction::create(
|
|
M, F->getLinkage(), NewFName, NewFTy, nullptr, F->getLocation(),
|
|
F->isBare(), F->isTransparent(), F->isFragile(),
|
|
F->getInlineStrategy(), F->getEffectsInfo(), 0,
|
|
NewDebugScope, F->getDeclContext());
|
|
NewF->setSemanticsAttr(F->getSemanticsAttr());
|
|
NewDebugScope->SILFn = NewF;
|
|
|
|
return NewF;
|
|
}
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
// Mangling
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
static bool isSpecializedFunction(SILFunction &F) {
|
|
return F.getName().startswith("_TTOS");
|
|
}
|
|
|
|
llvm::SmallString<64> FunctionAnalyzer::getOptimizedName() {
|
|
llvm::SmallString<64> Name;
|
|
|
|
{
|
|
llvm::raw_svector_ostream buffer(Name);
|
|
// OS for optimized signature.
|
|
buffer << "_TTOS_";
|
|
|
|
// For every argument, put in what we are going to do to that arg in the
|
|
// signature. The key is:
|
|
//
|
|
// 'n' => We did nothing to the argument.
|
|
// 'd' => The argument was dead and will be removed.
|
|
// 'a2v' => Was a loadable address and we promoted it to a value.
|
|
// 'o2g' => Was an @owned argument, but we changed it to be a guaranteed
|
|
// parameter.
|
|
// 's' => Was a loadable value that we exploded into multiple arguments.
|
|
// 'a2s' => Was a loadable address and we promoted it to a value which we
|
|
// exploded into multiple arguments.
|
|
//
|
|
// Currently we only emit functions that use:
|
|
//
|
|
// 1. 'n',
|
|
// 2. 'd',
|
|
// 3. 'o2g'
|
|
//
|
|
// since we do not perform any other of the optimizations.
|
|
//
|
|
// *NOTE* The guaranteed optimization requires knowledge to be taught to the
|
|
// ARC optimizer among other passes in order to guarantee safety. That or
|
|
// you need to insert a fix_lifetime call to make sure we do not eliminate
|
|
// the retain, release surrounding the call site in the caller.
|
|
//
|
|
// Additionally we use a packed signature since at this point we don't need
|
|
// any '_'. The fact that we can run this optimization multiple times makes
|
|
// me worried about long symbol names so I am trying to keep the symbol
|
|
// names as short as possible especially in light of this being applied to
|
|
// specialized functions.
|
|
|
|
for (const ArgumentDescriptor &Arg : ArgDescList) {
|
|
// If this arg is dead, add 'd' to the packed signature and continue.
|
|
if (Arg.IsDead) {
|
|
buffer << 'd';
|
|
continue;
|
|
}
|
|
|
|
bool WillOptimize = false;
|
|
// If we have an @owned argument and found a callee release for it,
|
|
// convert the argument to guaranteed.
|
|
if (Arg.CalleeRelease) {
|
|
WillOptimize = true;
|
|
buffer << "o2g";
|
|
}
|
|
|
|
if (Arg.ProjTree.canExplodeValue()) {
|
|
WillOptimize = true;
|
|
buffer << "s";
|
|
}
|
|
|
|
if (WillOptimize)
|
|
continue;
|
|
|
|
// Otherwise we are doing nothing so add 'n' to the packed signature.
|
|
buffer << 'n';
|
|
}
|
|
|
|
buffer << '_' << F->getName();
|
|
}
|
|
|
|
return Name;
|
|
}
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
// Main Routine
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
/// This function takes in OldF and all callsites of OldF and rewrites the
|
|
/// callsites to call the new function.
|
|
static void
|
|
rewriteApplyInstToCallNewFunction(FunctionAnalyzer &Analyzer, SILFunction *NewF,
|
|
CallGraphNode::CallerCallSiteList CallSites) {
|
|
for (ApplyInst *AI : CallSites) {
|
|
SILBuilderWithScope<16> Builder(AI);
|
|
|
|
FunctionRefInst *FRI = Builder.createFunctionRef(AI->getLoc(), NewF);
|
|
|
|
// Create the args for the new apply, ignoring any dead arguments.
|
|
llvm::SmallVector<SILValue, 8> NewArgs;
|
|
ArrayRef<ArgumentDescriptor> ArgDescs = Analyzer.getArgDescList();
|
|
for (auto &ArgDesc : ArgDescs) {
|
|
ArgDesc.addCallerArgs(Builder, AI, NewArgs);
|
|
}
|
|
|
|
// We are ignoring generic functions and functions with out parameters for
|
|
// now.
|
|
SILType LoweredType = NewF->getLoweredType();
|
|
SILType ResultType = LoweredType.getFunctionInterfaceResultType();
|
|
SILLocation Loc = AI->getLoc();
|
|
|
|
// Create the new apply.
|
|
ApplyInst *NewAI = Builder.createApply(Loc, FRI, LoweredType, ResultType,
|
|
ArrayRef<Substitution>(), NewArgs,
|
|
NewF->isTransparent());
|
|
|
|
// Replace all uses of the old apply with the new apply.
|
|
AI->replaceAllUsesWith(NewAI);
|
|
|
|
// If we have any arguments that were consumed but are now guaranteed,
|
|
// insert a fix lifetime instruction and a release_value.
|
|
for (auto &ArgDesc : ArgDescs) {
|
|
if (!ArgDesc.CalleeRelease)
|
|
continue;
|
|
|
|
Builder.createFixLifetime(Loc, AI->getArgument(ArgDesc.Index));
|
|
Builder.createReleaseValue(Loc, AI->getArgument(ArgDesc.Index));
|
|
}
|
|
|
|
// Erase the old apply and its callee.
|
|
recursivelyDeleteTriviallyDeadInstructions(AI, true,
|
|
[](SILInstruction *){});
|
|
|
|
++NumCallSitesOptimized;
|
|
}
|
|
}
|
|
|
|
static void createThunkBody(SILBasicBlock *BB, SILFunction *NewF,
|
|
FunctionAnalyzer &Analyzer) {
|
|
// TODO: What is the proper location to use here?
|
|
SILLocation Loc = BB->getParent()->getLocation();
|
|
SILBuilderWithScope<16> Builder(BB,
|
|
BB->getParent()->getDebugScope());
|
|
|
|
FunctionRefInst *FRI = Builder.createFunctionRef(Loc, NewF);
|
|
|
|
// Create the args for the thunk's apply, ignoring any dead arguments.
|
|
llvm::SmallVector<SILValue, 8> ThunkArgs;
|
|
ArrayRef<ArgumentDescriptor> ArgDescs = Analyzer.getArgDescList();
|
|
for (auto &ArgDesc : ArgDescs) {
|
|
ArgDesc.addThunkArgs(Builder, BB, ThunkArgs);
|
|
}
|
|
|
|
// We are ignoring generic functions and functions with out parameters for
|
|
// now.
|
|
SILType LoweredType = NewF->getLoweredType();
|
|
SILType ResultType = LoweredType.getFunctionInterfaceResultType();
|
|
SILValue ReturnValue = Builder.createApply(Loc, FRI, LoweredType, ResultType,
|
|
ArrayRef<Substitution>(),
|
|
ThunkArgs, NewF->isTransparent());
|
|
|
|
// If we have any arguments that were consumed but are now guaranteed,
|
|
// insert a fix lifetime instruction and a release_value.
|
|
for (auto &ArgDesc : ArgDescs) {
|
|
if (!ArgDesc.CalleeRelease)
|
|
continue;
|
|
|
|
Builder.createFixLifetime(Loc, BB->getBBArg(ArgDesc.Index));
|
|
Builder.createReleaseValue(Loc, BB->getBBArg(ArgDesc.Index));
|
|
}
|
|
|
|
Builder.createReturn(Loc, ReturnValue);
|
|
}
|
|
|
|
static SILFunction *
|
|
moveFunctionBodyToNewFunctionWithName(SILFunction *F,
|
|
llvm::SmallString<64> &NewFName,
|
|
FunctionAnalyzer &Analyzer) {
|
|
// First we create an empty function (i.e. no BB) whose function signature has
|
|
// had its arity modified.
|
|
//
|
|
// We only do this to remove dead arguments. All other function signature
|
|
// optimization is done later by modifying the function signature elements
|
|
// themselves.
|
|
SILFunction *NewF = Analyzer.createEmptyFunctionWithOptimizedSig(NewFName);
|
|
|
|
// Then we transfer the body of F to NewF. At this point, the arguments of the
|
|
// first BB will not match.
|
|
NewF->spliceBody(F);
|
|
|
|
// Then perform any updates to the arguments of NewF.
|
|
SILBasicBlock *NewFEntryBB = &*NewF->begin();
|
|
MutableArrayRef<ArgumentDescriptor> ArgDescs = Analyzer.getArgDescList();
|
|
unsigned ArgOffset = 0;
|
|
SILBuilderWithScope<16> Builder(NewFEntryBB->begin(),
|
|
NewFEntryBB->getParent()->getDebugScope());
|
|
for (auto &ArgDesc : ArgDescs) {
|
|
DEBUG(llvm::dbgs() << "Updating arguments at ArgOffset: " << ArgOffset
|
|
<< " for: " << *ArgDesc.Arg);
|
|
ArgOffset = ArgDesc.updateOptimizedBBArgs(Builder, NewFEntryBB, ArgOffset);
|
|
}
|
|
|
|
// Otherwise generate the thunk body just in case.
|
|
SILBasicBlock *ThunkBody = F->createBasicBlock();
|
|
for (auto &ArgDesc : ArgDescs) {
|
|
ThunkBody->createBBArg(ArgDesc.ParameterInfo.getSILType(),
|
|
ArgDesc.Decl);
|
|
}
|
|
createThunkBody(ThunkBody, NewF, Analyzer);
|
|
|
|
return NewF;
|
|
}
|
|
|
|
/// This function takes in a SILFunction F and its callsites in the current
|
|
/// module and produces a new SILFunction that has the body of F but with
|
|
/// optimized function arguments. F is changed to be a thunk that calls NewF to
|
|
/// reduce code duplication in cases where we missed a callsite to F. The
|
|
/// function returns true if we were successful in creating the new function and
|
|
/// returns false otherwise.
|
|
static bool
|
|
optimizeFunctionSignature(RCIdentityAnalysis *RCIA,
|
|
SILFunction *F,
|
|
CallGraphNode::CallerCallSiteList CallSites,
|
|
bool CallerSetIsComplete,
|
|
std::vector<SILFunction *> &DeadFunctions) {
|
|
DEBUG(llvm::dbgs() << "Optimizing Function Signature of " << F->getName()
|
|
<< "\n");
|
|
|
|
// An array containing our ArgumentDescriptor objects that contain information
|
|
// from our analysis.
|
|
llvm::SmallVector<ArgumentDescriptor, 8> Arguments;
|
|
|
|
// Analyze function arguments. If there is no work to be done, exit early.
|
|
FunctionAnalyzer Analyzer(RCIA, F);
|
|
if (!Analyzer.analyze()) {
|
|
DEBUG(llvm::dbgs() << " Has no optimizable arguments... "
|
|
"bailing...\n");
|
|
return false;
|
|
}
|
|
|
|
DEBUG(llvm::dbgs() << " Has optimizable arguments... Performing "
|
|
"optimizations...\n");
|
|
|
|
++NumFunctionSignaturesOptimized;
|
|
|
|
DEBUG(for (auto *AI : CallSites) {
|
|
llvm::dbgs() << " CALLSITE: " << *AI;
|
|
});
|
|
|
|
llvm::SmallString<64> NewFName = Analyzer.getOptimizedName();
|
|
|
|
// If we already have a specialized version of this function, do not
|
|
// respecialize. For now just bail.
|
|
//
|
|
// TODO: Improve this. I do not expect this to occur often so I am fine for
|
|
// now avoiding this issue. The main things I am worried about are assumptions
|
|
// that we make about the callee and caller being violated. That said, this is
|
|
// just a fear.
|
|
if (F->getModule().lookUpFunction(NewFName))
|
|
return false;
|
|
|
|
// Otherwise, move F over to NewF.
|
|
SILFunction *NewF =
|
|
moveFunctionBodyToNewFunctionWithName(F, NewFName, Analyzer);
|
|
|
|
// And remove all Callee releases that we found and made redundent via owned
|
|
// to guaranteed conversion.
|
|
//
|
|
// TODO: If more stuff needs to be placed here, refactor into its own method.
|
|
for (auto &A : Analyzer.getArgDescList()) {
|
|
if (A.CalleeRelease) {
|
|
A.CalleeRelease->eraseFromParent();
|
|
}
|
|
}
|
|
|
|
// Rewrite all apply insts calling F to call NewF. Update each call site as
|
|
// appropriate given the form of function signature optimization performed.
|
|
rewriteApplyInstToCallNewFunction(Analyzer, NewF, CallSites);
|
|
|
|
// Now that we have rewritten all apply insts that referenced the old
|
|
// function, if the caller set was complete, delete the old function.
|
|
if (CallerSetIsComplete) {
|
|
DeadFunctions.push_back(F);
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
// Top Level Driver
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
static bool isSpecializableCC(AbstractCC CC) {
|
|
switch (CC) {
|
|
case AbstractCC::Method:
|
|
case AbstractCC::Freestanding:
|
|
case AbstractCC::C:
|
|
return true;
|
|
case AbstractCC::WitnessMethod:
|
|
case AbstractCC::ObjCMethod:
|
|
return false;
|
|
}
|
|
}
|
|
|
|
/// Returns true if F is a function which the pass know show to specialize
|
|
/// function signatures for.
|
|
static bool canSpecializeFunction(SILFunction &F) {
|
|
// Do not specialize the signature of SILFunctions that are external
|
|
// declarations since there is no body to optimize.
|
|
if (F.isExternalDeclaration())
|
|
return false;
|
|
|
|
// Do not specialize functions that are available externally. If an external
|
|
// function was able to be specialized, it would have been specialized in its
|
|
// own module. We will inline the original function as a thunk. The thunk will
|
|
// call the specialized function.
|
|
if (F.isAvailableExternally())
|
|
return false;
|
|
|
|
// Do not specialize functions that we already specialized.
|
|
if (isSpecializedFunction(F))
|
|
return false;
|
|
|
|
// Do not specialize the signature of transparent functions or always inline
|
|
// functions, we will just inline them and specialize each one of the
|
|
// individual functions that these sorts of functions are inlined into.
|
|
if (F.isTransparent() || F.getInlineStrategy() == Inline_t::AlwaysInline)
|
|
return false;
|
|
|
|
// For now ignore generic functions to keep things simple...
|
|
if (F.getLoweredFunctionType()->isPolymorphic())
|
|
return false;
|
|
|
|
// Make sure F has a linkage that we can optimize.
|
|
if (!isSpecializableCC(F.getAbstractCC()))
|
|
return false;
|
|
|
|
return true;
|
|
}
|
|
|
|
namespace {
|
|
|
|
class FunctionSignatureOpts : public SILModuleTransform {
|
|
public:
|
|
FunctionSignatureOpts() {}
|
|
|
|
void run() {
|
|
SILModule *M = getModule();
|
|
auto *CGA = getAnalysis<CallGraphAnalysis>();
|
|
auto *RCIA = getAnalysis<RCIdentityAnalysis>();
|
|
|
|
DEBUG(llvm::dbgs() << "**** Optimizing Function Signatures ****\n\n");
|
|
|
|
CallGraph &CG = CGA->getCallGraph();
|
|
|
|
// Construct a map from Callee -> Call Site Set.
|
|
|
|
// Process each function in the callgraph that we are able to optimize.
|
|
//
|
|
// TODO: Determine if it is profitable to always perform this optimization
|
|
// even if a function is not called locally. As far as we can tell. Down the
|
|
// line more calls may be exposed and the inliner might be able to handle
|
|
// those calls.
|
|
bool Changed = false;
|
|
|
|
std::vector<SILFunction *> DeadFunctions;
|
|
DeadFunctions.reserve(128);
|
|
|
|
for (auto &F : *M) {
|
|
// Check the signature of F to make sure that it is a function that we can
|
|
// specialize. These are conditions independent of the call graph.
|
|
if (!canSpecializeFunction(F))
|
|
continue;
|
|
|
|
// Then try and grab F's call graph node.
|
|
CallGraphNode *FNode = CG.getCallGraphNode(&F);
|
|
|
|
// If we don't have any call graph information for F, skip F.
|
|
if (!FNode)
|
|
continue;
|
|
|
|
// Now that we have our call graph, grab the CallSites of F.
|
|
auto CallSites = FNode->getKnownCallerCallSites();
|
|
|
|
// If this function is not called anywhere, for now don't do anything.
|
|
//
|
|
// TODO: If it is public, it may still make sense to specialize since if
|
|
// we link in the public function in another module, we may be able to
|
|
// inline it and access the specialized version.
|
|
if (CallSites.empty())
|
|
continue;
|
|
|
|
// Check if we know the callgraph is complete with respect to this
|
|
// function. In such a case, we don't need to generate the thunk.
|
|
bool CallerSetIsComplete = FNode->isCallerSetComplete();
|
|
|
|
// Otherwise, try to optimize the function signature of F.
|
|
Changed |= optimizeFunctionSignature(RCIA, &F, CallSites,
|
|
CallerSetIsComplete,
|
|
DeadFunctions);
|
|
}
|
|
|
|
while (!DeadFunctions.empty()) {
|
|
SILFunction *F = DeadFunctions.back();
|
|
if (F->canBeDeleted())
|
|
M->eraseFunction(F);
|
|
DeadFunctions.pop_back();
|
|
}
|
|
|
|
// If we changed anything, invalidate the call graph.
|
|
if (Changed)
|
|
invalidateAnalysis(SILAnalysis::InvalidationKind::CallGraph);
|
|
}
|
|
|
|
StringRef getName() override { return "Function Signature Optimization"; }
|
|
};
|
|
} // end anonymous namespace
|
|
|
|
SILTransform *swift::createFunctionSignatureOpts() {
|
|
return new FunctionSignatureOpts();
|
|
}
|