mirror of
https://github.com/apple/swift.git
synced 2025-12-14 20:36:38 +01:00
ce70727e6f
47b068d445 output a diagnostic if a
deserialized decl was invalid (checking `Decl::isInvalid`). It had two
major issues:
1. It incorrectly output diagnostics for valid modules
2. It did not catch call invalid declarations
(1) is caused by `isInvalid` falling back to checking the storage for
accessors when the interface type hasn't already been computed (a
fallback to prevent a cycle due to `SimpleDidSetRequest` typechecking
the body). Since the `VarDecl` hasn't finished deserializing, it returns
`true` for its `isInvalid` check (even though it would later return
`false`).
For (2), only `ValueDecl`s would ever be invalid, since other
declarations use a bit in `Decl` to check for validity. As that's not
serialized, those would always be valid in deserialization.
To avoid both these issues, instead output a flag for each declaration
representing whether it is invalid (or not). Read that during
deserialization and output a diagnostic if it is invalid. To be extra
sure that a diagnostic is always output on an error, also output one
when deserializing any `ErrorType`. This ensures that SILGen does not
run when allowing errors (and an error is present), as it is likely to
crash when presented with an invalid AST.
Resolves rdar://74541834
119 lines
5.3 KiB
Swift
119 lines
5.3 KiB
Swift
// RUN: %empty-directory(%t)
|
|
|
|
// The module should be generated regardless of errors and diagnostic should still be output
|
|
// RUN: %target-swift-frontend -verify -emit-module -o %t/errors.swiftmodule -experimental-allow-module-with-compiler-errors -D ERROR_MODULE %s
|
|
// RUN: llvm-bcanalyzer %t/errors.swiftmodule | %FileCheck -check-prefix=CHECK-BC %s
|
|
// CHECK-BC-NOT: UnknownCode
|
|
#if ERROR_MODULE
|
|
public struct ValidStructInvalidMember {
|
|
public var member: String
|
|
public let memberMissingType: undefined // expected-error {{cannot find type 'undefined'}}
|
|
|
|
public var memberMissingTypeValidSets: undefined { // expected-error {{cannot find type 'undefined'}}
|
|
willSet {
|
|
print("Setting value \(newValue)")
|
|
}
|
|
didSet {
|
|
print("Set value \(oldValue)")
|
|
}
|
|
}
|
|
public var memberInvalidSets: Int {
|
|
willSet {
|
|
undefined // expected-error {{cannot find 'undefined'}}
|
|
}
|
|
didSet {
|
|
undefined // expected-error {{cannot find 'undefined'}}
|
|
}
|
|
}
|
|
|
|
public lazy var lazyMemberMissingTypeValidBody: undefined = { // expected-error {{cannot find type 'undefined'}}
|
|
return ""
|
|
}()
|
|
public lazy var lazyMemberInvalidBody: String = {
|
|
return undefined // expected-error {{cannot find 'undefined'}}
|
|
}()
|
|
|
|
public var memberMissingTypeValidGetSets: String {
|
|
get { member }
|
|
set { member = "" }
|
|
}
|
|
public var memberInvalidGetSet: String {
|
|
get { undefined } // expected-error {{cannot find 'undefined'}}
|
|
set { undefined = "" } // expected-error {{cannot find 'undefined'}}
|
|
}
|
|
|
|
public func funcBadArg(_ arg: undefined? = nil) {} // expected-error {{cannot find type 'undefined'}}
|
|
}
|
|
|
|
public func validFunc() -> String { "" }
|
|
|
|
public func invalidFuncBody() -> ValidStructInvalidMember {
|
|
ret // expected-error {{cannot find 'ret'}}
|
|
}
|
|
|
|
public func invalidFunc() -> undefined {} // expected-error {{cannot find type 'undefined'}}
|
|
#endif
|
|
|
|
// RUN: %target-swift-frontend -emit-module -o %t/validUses.swiftmodule -experimental-allow-module-with-compiler-errors -I%t -D VALID_USES %s 2>&1 | %FileCheck -check-prefix=CHECK-VALID %s
|
|
// RUN: llvm-bcanalyzer %t/validUses.swiftmodule | %FileCheck -check-prefix=CHECK-BC %s
|
|
#if VALID_USES
|
|
import errors
|
|
func test(s: ValidStructInvalidMember) {
|
|
print(s.member)
|
|
print(validFunc())
|
|
print(invalidFuncBody())
|
|
}
|
|
|
|
// Check SIL diagnostics are still output (no reason not to output SIL since
|
|
// there were no errors)
|
|
func other() -> Int {}
|
|
// CHECK-VALID: allow-errors.swift:[[@LINE-1]]:22: error: missing return in a function expected to return 'Int'
|
|
func other2() -> Bool {}
|
|
// CHECK-VALID: allow-errors.swift:[[@LINE-1]]:24: error: missing return in a function expected to return 'Bool'
|
|
#endif
|
|
|
|
// All invalid uses should have no errors in the file itself, all referenced
|
|
// invalid declarations should have an error elsewhere (but we don't care what
|
|
// that location is)
|
|
|
|
// RUN: %target-swift-frontend -emit-module -o %t/invalidTopUse.swiftmodule -experimental-allow-module-with-compiler-errors -I%t -D INVALID_TOP_LEVEL_USE %s 2>&1 | %FileCheck -check-prefix=CHECK-INVALID-TOP %s
|
|
// RUN: llvm-bcanalyzer %t/invalidTopUse.swiftmodule | %FileCheck -check-prefix=CHECK-BC %s
|
|
#if INVALID_TOP_LEVEL_USE
|
|
import errors
|
|
func test() {
|
|
invalidFunc()
|
|
}
|
|
// CHECK-INVALID-TOP-NOT: allow-errors.swift:{{.*}} error:
|
|
// CHECK-INVALID-TOP: error: allowing deserialization of error type '<null>' in module 'errors'
|
|
// CHECK-INVALID-TOP: error: allowing deserialization of invalid declaration 'invalidFunc()' (global function) in module 'errors'
|
|
// CHECK-INVALID-TOP-NOT: allow-errors.swift:{{.*}} error:
|
|
#endif
|
|
|
|
// RUN: %target-swift-frontend -emit-module -o %t/invalidMemberUse.swiftmodule -experimental-allow-module-with-compiler-errors -I%t -D INVALID_MEMBER_USE %s 2>&1 | %FileCheck -check-prefix=CHECK-INVALID-MEMBER %s
|
|
// RUN: llvm-bcanalyzer %t/invalidMemberUse.swiftmodule | %FileCheck -check-prefix=CHECK-BC %s
|
|
#if INVALID_MEMBER_USE
|
|
import errors
|
|
func test(s: ValidStructInvalidMember) {
|
|
print(s.memberMissingType)
|
|
}
|
|
// CHECK-INVALID-MEMBER-NOT: allow-errors.swift:{{.*}} error:
|
|
// CHECK-INVALID-MEMBER: error: allowing deserialization of error type '<null>' in module 'errors'
|
|
// CHECK-INVALID-MEMBER: error: allowing deserialization of invalid declaration '_' (getter) in module 'errors'
|
|
// CHECK-INVALID-MEMBER: error: allowing deserialization of invalid declaration 'memberMissingType' (property) in module 'errors'
|
|
// CHECK-INVALID-MEMBER-NOT: allow-errors.swift:{{.*}} error:
|
|
#endif
|
|
|
|
// RUN: %target-swift-frontend -emit-module -o %t/invalidMethodUse.swiftmodule -experimental-allow-module-with-compiler-errors -I%t -D INVALID_METHOD_USE %s 2>&1 | %FileCheck -check-prefix=CHECK-INVALID-METHOD %s
|
|
// RUN: llvm-bcanalyzer %t/invalidMethodUse.swiftmodule | %FileCheck -check-prefix=CHECK-BC %s
|
|
#if INVALID_METHOD_USE
|
|
import errors
|
|
func test(s: ValidStructInvalidMember) {
|
|
s.funcBadArg()
|
|
}
|
|
// CHECK-INVALID-METHOD-NOT: allow-errors.swift:{{.*}} error:
|
|
// CHECK-INVALID-METHOD: error: allowing deserialization of error type '<null>' in module 'errors'
|
|
// CHECK-INVALID-METHOD: error: allowing deserialization of invalid declaration 'arg' (parameter) in module 'errors'
|
|
// CHECK-INVALID-METHOD: error: allowing deserialization of invalid declaration 'funcBadArg' (instance method) in module 'errors'
|
|
// CHECK-INVALID-METHOD-NOT: allow-errors.swift:{{.*}} error:
|
|
#endif
|