mirror of
https://github.com/apple/swift.git
synced 2026-06-20 15:42:51 +02:00
Konrad `ktoso` Malawski
791f0796e2
Dead code elimination is not aware of the fact that distributed function accessors and witnesses are actually used by the runtime, and therefore may remove them. 🧟 This seems to have flown under the radar however when whole module optimization is enabled in release mode this can trigger reliably and result in pointing at deleted witnesses. This PR mades a few cleanups in the way we mark and handle distributed accessors so they don't get optimized away. This is an additional fix on top of https://github.com/swiftlang/swift/pull/87453 Resolves rdar://168881945
88 lines
4.0 KiB
Swift
88 lines
4.0 KiB
Swift
// RUN: %target-swift-emit-silgen %s -enable-experimental-distributed -target %target-swift-5.7-abi-triple | %FileCheck %s
|
|
// REQUIRES: concurrency
|
|
// REQUIRES: distributed
|
|
|
|
import Distributed
|
|
|
|
distributed actor DA {
|
|
typealias ActorSystem = LocalTestingDistributedActorSystem
|
|
}
|
|
|
|
extension DA {
|
|
// CHECK-LABEL: sil hidden [thunk] [distributed] [ref_adhoc_requirement_witness "$s11Distributed29LocalTestingInvocationDecoderC18decodeNextArgumentxyKSeRzSERzlF"] [ossa] @$s17distributed_thunk2DAC1fyyYaKFTE : $@convention(method) @async (@guaranteed DA) -> @error any Error {
|
|
// CHECK: function_ref @swift_distributed_actor_is_remote
|
|
|
|
// Call the actor function
|
|
// CHECK: function_ref @$s17distributed_thunk2DAC1fyyF : $@convention(method) (@sil_isolated @guaranteed DA) -> ()
|
|
|
|
distributed func f() { }
|
|
}
|
|
|
|
protocol ServerProto {
|
|
func doSomething() async throws
|
|
}
|
|
|
|
extension DA: ServerProto {
|
|
// CHECK-LABEL: sil private [transparent] [thunk] [ossa] @$s17distributed_thunk2DACAA11ServerProtoA2aDP11doSomethingyyYaKFTW : $@convention(witness_method: ServerProto) @async (@in_guaranteed DA) -> @error any Error
|
|
// TODO: we do hop here actually; ...-NOT: hop_to_executor
|
|
// CHECK: function_ref @$s17distributed_thunk2DAC11doSomethingyyYaKFTE
|
|
// CHECK: return
|
|
distributed func doSomething() { }
|
|
}
|
|
|
|
distributed actor DA2: ServerProto {
|
|
typealias ActorSystem = LocalTestingDistributedActorSystem
|
|
|
|
// CHECK-LABEL: sil private [transparent] [thunk] [ossa] @$s17distributed_thunk3DA2CAA11ServerProtoA2aDP11doSomethingyyYaKFTW : $@convention(witness_method: ServerProto) @async (@in_guaranteed DA2) -> @error any Error
|
|
// CHECK-NOT: hop_to_executor
|
|
// CHECK-NOT: return
|
|
// CHECK: function_ref @$s17distributed_thunk3DA2C11doSomethingyyYaKFTE
|
|
distributed func doSomething() async { }
|
|
}
|
|
|
|
distributed actor DA3: ServerProto {
|
|
typealias ActorSystem = LocalTestingDistributedActorSystem
|
|
|
|
// CHECK-LABEL: sil private [transparent] [thunk] [ossa] @$s17distributed_thunk3DA3CAA11ServerProtoA2aDP11doSomethingyyYaKFTW
|
|
// CHECK-NOT: hop_to_executor
|
|
// CHECK-NOT: return
|
|
// CHECK: function_ref @$s17distributed_thunk3DA3C11doSomethingyyYaKFTE
|
|
distributed func doSomething() async throws { }
|
|
}
|
|
|
|
distributed actor DA4: ServerProto {
|
|
typealias ActorSystem = LocalTestingDistributedActorSystem
|
|
|
|
// CHECK-LABEL: sil private [transparent] [thunk] [ossa] @$s17distributed_thunk3DA4CAA11ServerProtoA2aDP11doSomethingyyYaKFTW
|
|
// TODO: we do hop here actually; ...-NOT: hop_to_executor
|
|
// CHECK-NOT: return
|
|
// CHECK: function_ref @$s17distributed_thunk3DA4C11doSomethingyyYaKFTE
|
|
distributed func doSomething() throws { }
|
|
}
|
|
|
|
protocol Server2: DistributedActor {
|
|
distributed func sayHello()
|
|
}
|
|
|
|
extension Server2 where ActorSystem == LocalTestingDistributedActorSystem {
|
|
// CHECK-LABEL: sil hidden [thunk] [distributed] [ref_adhoc_requirement_witness "$s11Distributed29LocalTestingInvocationDecoderC18decodeNextArgumentxyKSeRzSERzlF"] [ossa] @$s17distributed_thunk7Server2PAA11Distributed012LocalTestingD11ActorSystemC0gH0RtzrlE8sayHelloyyYaKFTE
|
|
// CHECK-NOT: return
|
|
// CHECK: function_ref @swift_distributed_actor_is_remote
|
|
distributed func sayHello() { /* default impl */ }
|
|
|
|
// CHECK-LABEL: sil hidden [distributed] [ossa] @$s17distributed_thunk7Server2PAA11Distributed012LocalTestingD11ActorSystemC0gH0RtzrlE8sayHelloyyF
|
|
// CHECK-NOT: swift_distributed_actor_is_remote
|
|
// CHECK: return
|
|
}
|
|
|
|
distributed actor DA5: Server2 {
|
|
typealias ActorSystem = LocalTestingDistributedActorSystem
|
|
// uses default impl
|
|
|
|
// CHECK-LABEL: sil private [transparent] [thunk] [ossa] @$s17distributed_thunk3DA5CAA7Server2A2aDP8sayHelloyyFTW
|
|
// CHECK: function_ref @$s17distributed_thunk7Server2PAA11Distributed012LocalTestingD11ActorSystemC0gH0RtzrlE8sayHelloyyF
|
|
|
|
// CHECK-LABEL: sil private [transparent] [distributed_thunk] [ossa] @$s17distributed_thunk3DA5CAA7Server2A2aDP8sayHelloyyYaKFTWTE
|
|
// CHECK: function_ref @$s17distributed_thunk7Server2PAA11Distributed012LocalTestingD11ActorSystemC0gH0RtzrlE8sayHelloyyYaKFTE
|
|
}
|