Files
swift-mirror/lib/SILOptimizer/Mandatory/MoveOnlyDiagnostics.h
Kavon Farvardin bd253c602f prevent reinitialization of self after discard
The value `self` is mutable (i.e., var-bound) in
a `consuming` method. Since you're allowed to
reinitialize a var after consuming, that means
you were also naturally allowed to reinitialize
self after `discard self`. But that capability was
not intended; after you discard self you shouldn't
be reinitializing it, as that's probably a mistake.

This change makes reinitialization of `self`
reachable from a `discard self` statement an error.

rdar://106098163
2023-06-05 19:25:50 -07:00

192 lines
8.0 KiB
C++

//===--- MoveOnlyDiagnostics.h --------------------------------------------===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2014 - 2022 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//
///
/// Shared diagnostic code used by both the move only address checker and move
/// only object checker.
///
///
//===----------------------------------------------------------------------===//
#ifndef SWIFT_SILOPTIMIZER_MANDATORY_MOVEONLYDIAGNOSTICS_H
#define SWIFT_SILOPTIMIZER_MANDATORY_MOVEONLYDIAGNOSTICS_H
#include "MoveOnlyObjectCheckerUtils.h"
#include "swift/Basic/NullablePtr.h"
#include "swift/SIL/FieldSensitivePrunedLiveness.h"
#include "swift/SIL/SILInstruction.h"
namespace swift {
class FieldSensitivePrunedLivenessBoundary;
namespace siloptimizer {
class DiagnosticEmitter {
SILFunction *fn;
/// The canonicalizer that contains the final consuming uses and consuming
/// uses needing copy for object level diagnostics.
NullablePtr<OSSACanonicalizer> canonicalizer = nullptr;
/// Any mark must check inst that we have emitted diagnostics for are placed
/// here.
SmallPtrSet<MarkMustCheckInst *, 4> valuesWithDiagnostics;
/// Track any violating uses we have emitted a diagnostic for so we don't emit
/// multiple diagnostics for the same use.
SmallPtrSet<SILInstruction *, 8> useWithDiagnostic;
/// A count of the total diagnostics emitted so that callers of routines that
/// take a diagnostic emitter can know if the emitter emitted additional
/// diagnosics while running a callee.
unsigned diagnosticCount = 0;
bool emittedCheckerDoesntUnderstandDiagnostic = false;
/// This is incremented every time that the checker determines that an earlier
/// pass emitted a diagnostic while processing a mark_must_check. In such a
/// case, we want to suppress:
///
/// 1. Emitting the compiler doesn't understand how to check error for the
/// specific mark_must_check.
///
/// 2. The "copy of noncopyable type" error over the entire function since us
/// stopping processing at some point may have left copies.
///
/// We use a counter rather than a boolean here so that a caller that is
/// processing an individual mark_must_check can determine if the checker
/// identified such an earlier pass diagnostic for the specific allocation so
/// that we can still emit "compiler doesn't understand" errors for other
/// allocations.
unsigned diagnosticEmittedByEarlierPassCount = 0;
public:
DiagnosticEmitter(SILFunction *inputFn) : fn(inputFn) {}
void initCanonicalizer(OSSACanonicalizer *inputCanonicalizer) {
canonicalizer = inputCanonicalizer;
}
/// Clear our cache of uses that we have diagnosed for a specific
/// mark_must_check.
void clearUsesWithDiagnostic() { useWithDiagnostic.clear(); }
const OSSACanonicalizer &getCanonicalizer() const {
return *canonicalizer.get();
}
/// Returns true if when processing any allocation in the current function:
///
/// 1. This diagnostic emitter emitted a diagnostic.
/// 2. The user of the diagnostic emitter signaled to the diagnostic emitter
/// that it detected an earlier diagnostic was emitted that prevented it
/// from performing checking.
///
/// DISCUSSION: This is used by the checker to decide whether or not it should
/// emit "found copy of a noncopyable type" error. If the checker emitted one
/// of these diagnostics, then the checker may have stopped processing early
/// and left copies since it was no longer able to check. In such a case, we
/// want the user to fix the pre-existing errors and re-run.
bool emittedDiagnostic() const {
return getDiagnosticCount() || getDiagnosticEmittedByEarlierPassCount();
}
unsigned getDiagnosticCount() const { return diagnosticCount; }
bool didEmitCheckerDoesntUnderstandDiagnostic() const {
return emittedCheckerDoesntUnderstandDiagnostic;
}
bool getDiagnosticEmittedByEarlierPassCount() const {
return diagnosticEmittedByEarlierPassCount;
}
void emitEarlierPassEmittedDiagnostic(MarkMustCheckInst *mmci) {
++diagnosticEmittedByEarlierPassCount;
registerDiagnosticEmitted(mmci);
}
/// Used at the end of the MoveOnlyAddressChecker to tell the user in a nice
/// way to file a bug.
void emitCheckedMissedCopyError(SILInstruction *copyInst);
/// Given a drop_deinit of self and an instruction reinitializing self,
/// emits an error saying that you cannot reinitialize self after a discard.
void emitReinitAfterDiscardError(SILInstruction *badReinit,
SILInstruction *dropDeinit);
/// Assuming the given instruction represents the implicit destruction of
/// 'self', emits an error saying that you needed to explicitly 'consume self'
/// here because you're in a discarding context.
void emitMissingConsumeInDiscardingContext(SILInstruction *leftoverDestroy,
SILInstruction *dropDeinit);
void emitCheckerDoesntUnderstandDiagnostic(MarkMustCheckInst *markedValue);
void emitObjectGuaranteedDiagnostic(MarkMustCheckInst *markedValue);
void emitObjectOwnedDiagnostic(MarkMustCheckInst *markedValue);
bool emittedDiagnosticForValue(MarkMustCheckInst *markedValue) const {
return valuesWithDiagnostics.count(markedValue);
}
void emitAddressDiagnostic(MarkMustCheckInst *markedValue,
SILInstruction *lastLiveUse,
SILInstruction *violatingUse, bool isUseConsuming,
bool isInOutEndOfFunction = false);
void emitInOutEndOfFunctionDiagnostic(MarkMustCheckInst *markedValue,
SILInstruction *violatingUse);
void emitAddressDiagnosticNoCopy(MarkMustCheckInst *markedValue,
SILInstruction *consumingUse);
void emitAddressExclusivityHazardDiagnostic(MarkMustCheckInst *markedValue,
SILInstruction *consumingUse);
void emitObjectDestructureNeededWithinBorrowBoundary(
MarkMustCheckInst *markedValue, SILInstruction *destructureNeedingUse,
TypeTreeLeafTypeRange destructureNeededBits,
FieldSensitivePrunedLivenessBoundary &boundary);
void emitObjectInstConsumesValueTwice(MarkMustCheckInst *markedValue,
Operand *firstConsumingUse,
Operand *secondConsumingUse);
void emitObjectInstConsumesAndUsesValue(MarkMustCheckInst *markedValue,
Operand *consumingUse,
Operand *nonConsumingUse);
void emitAddressEscapingClosureCaptureLoadedAndConsumed(
MarkMustCheckInst *markedValue);
void emitPromotedBoxArgumentError(MarkMustCheckInst *markedValue,
SILFunctionArgument *arg);
void emitCannotDestructureDeinitNominalError(MarkMustCheckInst *markedValue,
StringRef pathString,
NominalTypeDecl *deinitedNominal,
SILInstruction *consumingUser);
private:
/// Emit diagnostics for the final consuming uses and consuming uses needing
/// copy. If filter is non-null, allow for the caller to pre-process operands
/// and emit their own diagnostic. If filter returns true, then we assume that
/// the caller processed it correctly. false, then we continue to process it.
void
emitObjectDiagnosticsForGuaranteedUses(bool ignorePartialApply = false) const;
void emitObjectDiagnosticsForPartialApplyUses(StringRef capturedVarName) const;
void registerDiagnosticEmitted(MarkMustCheckInst *value) {
++diagnosticCount;
valuesWithDiagnostics.insert(value);
}
};
} // namespace siloptimizer
} // namespace swift
#endif