mirror of
https://github.com/apple/swift.git
synced 2025-12-14 20:36:38 +01:00
e7e9b57051
Instead of a new attribute `@completionHandlerAsync`, allow the use of the existing `renamed` parameter of `@available` to specify the asynchronous alternative of a synchronous function. No errors will be output from invalid names as `@completionHandlerAsync` had, but if a function is correctly matched then it will be used to output warnings when using the synchronous function in an asynchronous context (as before). Resolves rdar://80612731
48 lines
2.2 KiB
Swift
48 lines
2.2 KiB
Swift
// REQUIRES: concurrency
|
|
|
|
// RUN: %empty-directory(%t)
|
|
|
|
// RUN: %refactor-check-compiles -add-async-alternative -dump-text -source-filename %s -pos=%(line+1):1 -enable-experimental-concurrency | %FileCheck -check-prefix=SIMPLE %s
|
|
func simple(completion: @escaping (String) -> Void) { }
|
|
// SIMPLE: async_attribute_added.swift [[# @LINE-1]]:1 -> [[# @LINE-1]]:1
|
|
// SIMPLE-NEXT: @available(*, renamed: "simple()")
|
|
// SIMPLE-EMPTY:
|
|
// SIMPLE-NEXT: async_attribute_added.swift [[# @LINE-4]]:53 -> [[# @LINE-4]]:56
|
|
// SIMPLE-NEXT: {
|
|
// SIMPLE-NEXT: Task {
|
|
// SIMPLE-NEXT: let result = await simple()
|
|
// SIMPLE-NEXT: completion(result)
|
|
// SIMPLE-NEXT: }
|
|
// SIMPLE-NEXT: }
|
|
// SIMPLE-EMPTY:
|
|
// SIMPLE-NEXT: async_attribute_added.swift [[# @LINE-12]]:56 -> [[# @LINE-12]]:56
|
|
// SIMPLE-EMPTY:
|
|
// SIMPLE-EMPTY:
|
|
// SIMPLE-EMPTY:
|
|
// SIMPLE-NEXT: async_attribute_added.swift [[# @LINE-16]]:56 -> [[# @LINE-16]]:56
|
|
// SIMPLE-NEXT: func simple() async -> String { }
|
|
|
|
// RUN: %refactor-check-compiles -add-async-alternative -dump-text -source-filename %s -pos=%(line+1):5 -enable-experimental-concurrency | %FileCheck -check-prefix=OTHER-ARGS %s
|
|
func otherArgs(first: Int, second: String, completion: @escaping (String) -> Void) { }
|
|
// OTHER-ARGS: @available(*, renamed: "otherArgs(first:second:)")
|
|
|
|
// RUN: %refactor-check-compiles -add-async-alternative -dump-text -source-filename %s -pos=%(line+1):5 -enable-experimental-concurrency | %FileCheck -check-prefix=EMPTY-NAMES %s
|
|
func emptyNames(first: Int, _ second: String, completion: @escaping (String) -> Void) { }
|
|
// EMPTY-NAMES: @available(*, renamed: "emptyNames(first:_:)")
|
|
|
|
// Not a completion handler named parameter, but should still be converted
|
|
// during function conversion since it has been attributed
|
|
@available(*, renamed: "otherName()")
|
|
func otherName(notHandlerName: @escaping (String) -> (Void)) {}
|
|
func otherName() async -> String {}
|
|
|
|
// RUN: %refactor-check-compiles -convert-to-async -dump-text -source-filename %s -pos=%(line+1):5 -enable-experimental-concurrency | %FileCheck -check-prefix=OTHER-CONVERTED %s
|
|
func otherStillConverted() {
|
|
otherName { str in
|
|
print(str)
|
|
}
|
|
}
|
|
// OTHER-CONVERTED: func otherStillConverted() async {
|
|
// OTHER-CONVERTED-NEXT: let str = await otherName()
|
|
// OTHER-CONVERTED-NEXT: print(str)
|