Files
swift-mirror/lib/Parse/Scope.cpp
Dmitri Hrybenko efffe5c065 Don't add names to non-resolvable scopes
Currently not only we insert names in non-resolvable scopes, but every
overloaded name gets stored only once (the last one wins).  Everything just
happens to work, because we never do name lookup in these scopes.

I also added a ScopeKind to every Scope (instead of just adding the bit --
isResolvableScope), because this provides a better debugging experience, and
centralizes knowledge about what scope kind is resolvable in the function
isResolvableScope(ScopeKind).


Swift SVN r5822
2013-06-26 21:44:11 +00:00

117 lines
3.9 KiB
C++

//===--- Scope.cpp - Scope Implementation ---------------------------------===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2014 - 2015 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See http://swift.org/LICENSE.txt for license information
// See http://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//
//
// This file implements semantic analysis for Swift declarations.
//
//===----------------------------------------------------------------------===//
#include "swift/AST/Attr.h"
#include "Scope.h"
#include "Parser.h"
#include "llvm/ADT/Twine.h"
using namespace swift;
//===----------------------------------------------------------------------===//
// Scope Implementation
//===----------------------------------------------------------------------===//
static bool isResolvableScope(ScopeKind SK) {
switch (SK) {
case ScopeKind::Extension:
case ScopeKind::OneofBody:
case ScopeKind::StructBody:
case ScopeKind::ClassBody:
case ScopeKind::ProtocolBody:
case ScopeKind::TopLevel:
return false;
case ScopeKind::FunctionBody:
case ScopeKind::Generics:
case ScopeKind::ConstructorBody:
case ScopeKind::DestructorBody:
case ScopeKind::Brace:
case ScopeKind::ForVars:
case ScopeKind::ForeachVars:
case ScopeKind::ClosureParams:
return true;
}
}
Scope::Scope(Parser *P, ScopeKind SC):
SI(P->ScopeInfo),
ValueHTScope(SI.ValueScopeHT),
PrevScope(SI.CurScope),
PrevResolvableDepth(SI.ResolvableDepth),
Kind(SC) {
if (SI.CurScope)
Depth = SI.CurScope->Depth+1;
else
Depth = 0;
SI.CurScope = this;
if (!isResolvableScope(SC))
SI.ResolvableDepth = Depth + 1;
}
bool Scope::isResolvable() const {
return isResolvableScope(Kind);
}
//===----------------------------------------------------------------------===//
// ScopeInfo Implementation
//===----------------------------------------------------------------------===//
/// checkValidOverload - Check whether it is ok for D1 and D2 to be declared at
/// the same scope. This check is a transitive relationship, so if "D1 is a
/// valid overload of D2" and "D2 is a valid overload of D3" then we know that
/// D1/D3 are valid overloads and we don't have to check all permutations.
static bool checkValidOverload(const ValueDecl *D1, const ValueDecl *D2,
Parser &P) {
// Currently, there is no restriction on overloading.
return false;
}
/// addToScope - Register the specified decl as being in the current lexical
/// scope.
void ScopeInfo::addToScope(ValueDecl *D) {
if (!CurScope->isResolvable())
return;
assert(CurScope->getDepth() >= ResolvableDepth &&
"inserting names into a non-resolvable scope");
// If we have a shadowed variable definition, check to see if we have a
// redefinition: two definitions in the same scope with the same name.
ValueScopeHTTy::iterator EntryI = ValueScopeHT.begin(D->getName());
// A redefinition is a hit in the scoped table at the same depth.
if (EntryI != ValueScopeHT.end() && EntryI->first == CurScope->getDepth()) {
ValueDecl *PrevDecl = EntryI->second;
// If this is in a resolvable scope, diagnose redefinitions. Later
// phases will handle scopes like module-scope, etc.
if (CurScope->getDepth() >= ResolvableDepth)
return TheParser.diagnoseRedefinition(PrevDecl, D);
// If this is at top-level scope, validate that the members of the overload
// set all agree.
// Check to see if D and PrevDecl are valid in the same overload set.
if (checkValidOverload(D, PrevDecl, TheParser))
return;
// Note: we don't check whether all of the elements of the overload set have
// different argument types. This is checked later.
}
ValueScopeHT.insert(D->getName(), std::make_pair(CurScope->getDepth(), D));
}