Files
swift-mirror/lib/SILOptimizer/Transforms/SILCleanup.cpp
Andrew Trick be1881aa1f Remove redundant Transform.getName() definitions.
At some point, pass definitions were heavily macro-ized. Pass
descriptive names were added in two places. This is not only redundant
but a source of confusion. You could waste a lot of time grepping for
the wrong string. I removed all the getName() overrides which, at
around 90 passes, was a fairly significant amount of code bloat.

Any pass that we want to be able to invoke by name from a tool
(sil-opt) or pipeline plan *should* have unique type name, enum value,
commend-line string, and name string. I removed a comment about the
various inliner passes that contradicted that.

Side note: We should be consistent with the policy that a pass is
identified by its type. We have a couple passes, LICM and CSE, which
currently violate that convention.
2017-04-09 15:20:28 -07:00

74 lines
2.3 KiB
C++

//===--- SILCleanup.cpp - Removes diagnostics instructions ----------------===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2014 - 2017 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//
//
// Cleanup SIL to make it suitable for IRGen. Specifically, removes the calls to
// Builtin.staticReport(), which are not needed post SIL.
//
// FIXME: This pass is mandatory so should probably be in
// SILOptimizer/Mandatory.
//
//===----------------------------------------------------------------------===//
#include "swift/SILOptimizer/PassManager/Passes.h"
#include "swift/SIL/SILFunction.h"
#include "swift/SIL/SILInstruction.h"
#include "swift/SIL/SILModule.h"
#include "swift/SILOptimizer/Utils/Local.h"
#include "swift/SILOptimizer/PassManager/Transforms.h"
using namespace swift;
static void cleanFunction(SILFunction &Fn) {
for (auto &BB : Fn) {
auto I = BB.begin(), E = BB.end();
while (I != E) {
// Make sure there is no iterator invalidation if the inspected
// instruction gets removed from the block.
SILInstruction *Inst = &*I;
++I;
// Remove calls to Builtin.staticReport().
if (BuiltinInst *BI = dyn_cast<BuiltinInst>(Inst)) {
const BuiltinInfo &B = BI->getBuiltinInfo();
if (B.ID == BuiltinValueKind::StaticReport) {
// The call to the builtin should get removed before we reach
// IRGen.
recursivelyDeleteTriviallyDeadInstructions(BI, /* Force */true);
}
}
}
}
// Rename functions with public_external linkage to prevent symbol conflict
// with stdlib.
if (Fn.isDefinition() && Fn.getLinkage() == SILLinkage::PublicExternal) {
Fn.setLinkage(SILLinkage::SharedExternal);
}
}
namespace {
class SILCleanup : public swift::SILFunctionTransform {
/// The entry point to the transformation.
void run() override {
cleanFunction(*getFunction());
invalidateAnalysis(SILAnalysis::InvalidationKind::FunctionBody);
}
};
} // end anonymous namespace
SILTransform *swift::createSILCleanup() {
return new SILCleanup();
}