mirror of
https://github.com/apple/swift.git
synced 2025-12-14 20:36:38 +01:00
We previously penalized bindings to Any, and that resulted in
inappropriately rejecting solutions where we bind a decl that is
explicitly typed Any. That penalty was removed in
170dc8acd7, but that has led to a variety
of source compatibility issues.
So now, we'll reintroduce a penalty for Any-typed things, but instead of
penalizing bindings (which happen both because of explicitly-typed
values in the source, and implicitly due to attempting various types for
a particular type variable), penalize casts, which are always present in
some form in the source.
Thanks go to John for the suggestion.
Fixes
SR-3817 (aka rdar://problem/30311052)
SR-3786 (aka rdar://problem/30268529)
rdar://problem/29907555
55 lines
1.7 KiB
Swift
55 lines
1.7 KiB
Swift
// RUN: %target-typecheck-verify-swift
|
|
|
|
func f0(_ i: Int, _ d: Double) {} // expected-note{{found this candidate}}
|
|
func f0(_ d: Double, _ i: Int) {} // expected-note{{found this candidate}}
|
|
|
|
f0(1, 2) // expected-error{{ambiguous use of 'f0'}}
|
|
|
|
func f1(_ i: Int16) {} // expected-note{{found this candidate}}
|
|
func f1(_ i: Int32) {} // expected-note{{found this candidate}}
|
|
|
|
f1(0) // expected-error{{ambiguous use of 'f1'}}
|
|
|
|
infix operator +++
|
|
|
|
func +++(i: Int, d: Double) {} // expected-note{{found this candidate}}
|
|
func +++(d: Double, i: Int) {} // expected-note{{found this candidate}}
|
|
|
|
1 +++ 2 // expected-error{{ambiguous use of operator '+++'}}
|
|
|
|
class C {
|
|
init(_ action: (Int) -> ()) {} // expected-note{{found this candidate}}
|
|
init(_ action: (Int, Int) -> ()) {} // expected-note{{found this candidate}}
|
|
}
|
|
|
|
func g(_ x: Int) -> () {} // expected-note{{found this candidate}}
|
|
func g(_ x: Int, _ y: Int) -> () {} // expected-note{{found this candidate}}
|
|
C(g) // expected-error{{ambiguous use of 'g'}}
|
|
|
|
func h<T>(_ x: T) -> () {}
|
|
C(h) // expected-error{{ambiguous use of 'init'}}
|
|
|
|
func rdar29691909_callee(_ o: AnyObject?) -> Any? { return o } // expected-note {{found this candidate}}
|
|
func rdar29691909_callee(_ o: AnyObject) -> Any { return o } // expected-note {{found this candidate}}
|
|
|
|
func rdar29691909(o: AnyObject) -> Any? {
|
|
return rdar29691909_callee(o) // expected-error{{ambiguous use of 'rdar29691909_callee'}}
|
|
}
|
|
|
|
func rdar29907555(_ value: Any!) -> String {
|
|
return "\(value)" // no error
|
|
}
|
|
|
|
struct SR3715 {
|
|
var overloaded: Int!
|
|
|
|
func overloaded(_ x: Int) {}
|
|
func overloaded(_ x: Float) {}
|
|
|
|
func take(_ a: [Any]) {}
|
|
|
|
func test() {
|
|
take([overloaded]) // no error
|
|
}
|
|
}
|