mirror of
https://github.com/apple/swift.git
synced 2025-12-14 20:36:38 +01:00
f3ff561c6f
This is phase-1 of switching from llvm::Optional to std::optional in the
next rebranch. llvm::Optional was removed from upstream LLVM, so we need
to migrate off rather soon. On Darwin, std::optional, and llvm::Optional
have the same layout, so we don't need to be as concerned about ABI
beyond the name mangling. `llvm::Optional` is only returned from one
function in
```
getStandardTypeSubst(StringRef TypeName,
bool allowConcurrencyManglings);
```
It's the return value, so it should not impact the mangling of the
function, and the layout is the same as `std::optional`, so it should be
mostly okay. This function doesn't appear to have users, and the ABI was
already broken 2 years ago for concurrency and no one seemed to notice
so this should be "okay".
I'm doing the migration incrementally so that folks working on main can
cherry-pick back to the release/5.9 branch. Once 5.9 is done and locked
away, then we can go through and finish the replacement. Since `None`
and `Optional` show up in contexts where they are not `llvm::None` and
`llvm::Optional`, I'm preparing the work now by going through and
removing the namespace unwrapping and making the `llvm` namespace
explicit. This should make it fairly mechanical to go through and
replace llvm::Optional with std::optional, and llvm::None with
std::nullopt. It's also a change that can be brought onto the
release/5.9 with minimal impact. This should be an NFC change.
109 lines
3.7 KiB
C++
109 lines
3.7 KiB
C++
//===--- CompileJobCacheKey.cpp - compile cache key methods ---------------===//
|
|
//
|
|
// This source file is part of the Swift.org open source project
|
|
//
|
|
// Copyright (c) 2014 - 2020 Apple Inc. and the Swift project authors
|
|
// Licensed under Apache License v2.0 with Runtime Library Exception
|
|
//
|
|
// See https://swift.org/LICENSE.txt for license information
|
|
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file contains utility methods for creating compile job cache keys.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include <swift/Frontend/CompileJobCacheKey.h>
|
|
#include <swift/Basic/Version.h>
|
|
#include <llvm/ADT/SmallString.h>
|
|
#include "llvm/ADT/STLExtras.h"
|
|
#include "llvm/CAS/HierarchicalTreeBuilder.h"
|
|
#include "llvm/CAS/ObjectStore.h"
|
|
#include "llvm/Support/Error.h"
|
|
#include "llvm/Support/MemoryBuffer.h"
|
|
|
|
using namespace swift;
|
|
|
|
// TODO: Rewrite this into CASNodeSchema.
|
|
llvm::Expected<llvm::cas::ObjectRef> swift::createCompileJobBaseCacheKey(
|
|
llvm::cas::ObjectStore &CAS, ArrayRef<const char *> Args) {
|
|
SmallString<256> CommandLine;
|
|
|
|
// TODO: Improve this list.
|
|
static const std::vector<std::string> removeArgAndNext = {
|
|
"-o",
|
|
"-output-filelist",
|
|
"-supplementary-output-file-map",
|
|
"-index-unit-output-path",
|
|
"-index-unit-output-path-filelist",
|
|
"-serialize-diagnostics-path",
|
|
"-num-threads",
|
|
"-cas-path"};
|
|
|
|
// Don't count the `-frontend` in the first location since only frontend
|
|
// invocation can have a cache key.
|
|
if (Args.size() > 1 && StringRef(Args.front()) == "-frontend")
|
|
Args = Args.drop_front();
|
|
|
|
for (unsigned I = 0, IE =Args.size(); I < IE; ++I) {
|
|
StringRef Arg = Args[I];
|
|
if (llvm::is_contained(removeArgAndNext, Arg)) {
|
|
++I;
|
|
continue;
|
|
}
|
|
// FIXME: Use a heuristic to remove all the flags that affect output paths.
|
|
// Those should not affect compile cache key.
|
|
if (Arg.startswith("-emit-")) {
|
|
if (Arg.endswith("-path"))
|
|
++I;
|
|
continue;
|
|
}
|
|
// Handle -file-list option. Need to drop the option but adds the file
|
|
// content instead.
|
|
// FIXME: will be nice if the same list of files gets the same key no matter
|
|
// going through command-line or filelist.
|
|
if (Arg == "-filelist" || Arg == "-primary-filelist") {
|
|
auto FileList = llvm::MemoryBuffer::getFile(Args[++I]);
|
|
if (!FileList)
|
|
return llvm::errorCodeToError(FileList.getError());
|
|
CommandLine.append(Arg);
|
|
CommandLine.push_back(0);
|
|
CommandLine.append((*FileList)->getBuffer());
|
|
CommandLine.push_back(0);
|
|
continue;
|
|
}
|
|
CommandLine.append(Arg);
|
|
CommandLine.push_back(0);
|
|
}
|
|
|
|
llvm::cas::HierarchicalTreeBuilder Builder;
|
|
auto CMD = CAS.storeFromString(llvm::None, CommandLine);
|
|
if (!CMD)
|
|
return CMD.takeError();
|
|
Builder.push(*CMD, llvm::cas::TreeEntry::Regular, "command-line");
|
|
|
|
// FIXME: The version is maybe insufficient...
|
|
auto Version = CAS.storeFromString(llvm::None, version::getSwiftFullVersion());
|
|
if (!Version)
|
|
return Version.takeError();
|
|
Builder.push(*Version, llvm::cas::TreeEntry::Regular, "version");
|
|
|
|
if (auto Out = Builder.create(CAS))
|
|
return Out->getRef();
|
|
else
|
|
return Out.takeError();
|
|
}
|
|
|
|
llvm::Expected<llvm::cas::ObjectRef> swift::createCompileJobCacheKeyForOutput(
|
|
llvm::cas::ObjectStore &CAS, llvm::cas::ObjectRef BaseKey,
|
|
StringRef ProducingInput, file_types::ID OutputType) {
|
|
SmallString<256> OutputInfo;
|
|
|
|
// Encode the OutputType as first byte, then append the input file path.
|
|
OutputInfo.emplace_back((char)OutputType);
|
|
OutputInfo.append(ProducingInput);
|
|
|
|
return CAS.storeFromString({BaseKey}, OutputInfo);
|
|
}
|