mirror of
https://github.com/apple/swift.git
synced 2025-12-21 12:14:44 +01:00
a7e51721ce
The various 'isExplicit' checks were wrong -- they should apply to protocol requirements only, not protocol extension members. Also, we weren't performing this check for type aliases in protocols, so you would get a misleading diagnostic telling you the type alias must be declared private/internal, when in fact type aliases in protocols cannot have their own access control. Finally, the "should be declared <X>" diagnostics (the !isExplicit case) need to state the most visible access level that will work, and in a few cases we would say private instead of fileprivate here.
53 lines
2.3 KiB
Swift
53 lines
2.3 KiB
Swift
// RUN: %target-typecheck-verify-swift -swift-version 4
|
|
|
|
fileprivate struct FilePrivateStruct {}
|
|
// expected-note@-1 4{{type declared here}}
|
|
|
|
private struct PrivateStruct {}
|
|
// expected-note@-1 4{{type declared here}}
|
|
|
|
internal struct InternalStruct {}
|
|
// expected-note@-1 4{{type declared here}}
|
|
|
|
public protocol P {
|
|
typealias TFP = FilePrivateStruct
|
|
// expected-error@-1 {{type alias cannot be declared public because its underlying type uses a fileprivate type}}
|
|
|
|
typealias TP = PrivateStruct
|
|
// expected-error@-1 {{type alias cannot be declared public because its underlying type uses a private type}}
|
|
|
|
typealias TI = InternalStruct
|
|
// expected-error@-1 {{type alias cannot be declared public because its underlying type uses an internal type}}
|
|
}
|
|
|
|
extension P {
|
|
func usesFilePrivateStructFunc(_: FilePrivateStruct) {}
|
|
// expected-error@-1 {{method must be declared fileprivate because its parameter uses a fileprivate type}}
|
|
|
|
typealias UsesFilePrivateStructAlias = FilePrivateStruct
|
|
// expected-error@-1 {{type alias must be declared fileprivate because its underlying type uses a fileprivate type}}
|
|
|
|
var usesFilePrivateStructProp: FilePrivateStruct { get { } set { } }
|
|
// expected-error@-1 {{property must be declared fileprivate because its type uses a fileprivate type}}
|
|
|
|
|
|
func usesPrivateStructFunc(_: PrivateStruct) {}
|
|
// expected-error@-1 {{method must be declared fileprivate because its parameter uses a private type}}
|
|
|
|
typealias UsesPrivateStructAlias = PrivateStruct
|
|
// expected-error@-1 {{type alias must be declared fileprivate because its underlying type uses a private type}}
|
|
|
|
var usesPrivateStructProp: PrivateStruct { get { } set { } }
|
|
// expected-error@-1 {{property must be declared fileprivate because its type uses a private type}}
|
|
|
|
|
|
public func usesInternalStruct(_: InternalStruct) {}
|
|
// expected-error@-1 {{method cannot be declared public because its parameter uses an internal type}}
|
|
|
|
public typealias UsesInternalStructAlias = InternalStruct
|
|
// expected-error@-1 {{type alias cannot be declared public because its underlying type uses an internal type}}
|
|
|
|
public var usesInternalStructProp: InternalStruct { get { } set { } }
|
|
// expected-error@-1 {{property cannot be declared public because its type uses an internal type}}
|
|
}
|