Nicholas Velten 794216d540 refactor: collapse is_martian_addr() into is_valid_for_peers() (#9096) ...

* refactor: collapse is_martian_addr() into is_valid_for_peers()

is_martian_addr() was a separate function for historical reasons: it
started out as an LTEP-only check and was folded into the peer address
validation later. Keeping it apart split one decision across two places,
with the loopback rule in the helper and the rest at the call site.

Inline the checks and keep the attribution comment. No behavior change;
the new test covers the current rules, including which peer sources may
name a loopback address.

Fixes #7848

* refactor: drop is_martian_addr() attribution comment

None of Juliusz Chroboczek's original isMartianAddr() remains after the
overhaul, so the MIT attribution no longer applies to this code.

2026-09-03 23:07:14 -05:00

..

.clang-tidy

fix: performance-move-const-arg (#8788)

2026-05-25 14:04:52 -05:00

announce-list.cc

fix: enable modernize-use-ranges (#8626)

2026-02-26 08:22:29 -06:00

announce-list.h

refactor: use char8_t as underlying type of tr_interned_string (#8556)

2026-02-25 09:07:01 -06:00

announcer-common.h

refactor: compare_failed spaceship (#8634)

2026-03-04 16:04:10 -06:00

announcer-http.cc

fix: don't process failed HTTP announce response if one the same group succeeded (#8631)

2026-03-01 21:16:20 -06:00

announcer-udp.cc

refactor: add libtransmission/types.h (#8449)

2026-02-11 16:52:29 -06:00

announcer.cc

refactor: replace char* with std::string_view (#8898)

2026-06-14 16:21:14 -05:00

announcer.h

refactor: add libtransmission/types.h (#8449)

2026-02-11 16:52:29 -06:00

api-compat.cc

refactor: migrate settings to reuse RPC keys for seed ratio settings (#8821)

2026-05-28 13:24:34 -05:00

api-compat.h

refactor: rename our namespace to tr (#8256)

2026-01-28 18:11:34 -06:00

bandwidth.cc

refactor: add libtransmission/types.h (#8449)

2026-02-11 16:52:29 -06:00

bandwidth.h

refactor: add libtransmission/types.h (#8449)

2026-02-11 16:52:29 -06:00

benc.h

fix: fail when encountering invalid benc character. (#8573)

2026-02-19 13:53:01 -06:00

bep55-holepunch.cc

feat: add BEP 55 uTP hole punching (#8884)

2026-08-23 17:46:41 -05:00

bep55-holepunch.h

feat: add BEP 55 uTP hole punching (#8884)

2026-08-23 17:46:41 -05:00

bep55-introducer-store.h

feat: add BEP 55 uTP hole punching (#8884)

2026-08-23 17:46:41 -05:00

bitfield.cc

refactor: remove tr-popcount.h (#8234)

2026-01-27 12:15:08 -06:00

bitfield.h

fix(core): bugprone-narrowing-conversions (#8714)

2026-03-29 21:41:10 -05:00

block-info.cc

fix: implicit conversion loses integer precision (#6466)

2023-12-31 14:04:26 -06:00

block-info.h

refactor: async file IO prep (#8740)

2026-03-29 21:31:12 -05:00

blocklist.cc

refactor: remove some of the unused C-style tr_variantFooBar() methods (#8878)

2026-06-08 13:39:21 -05:00

blocklist.h

refactor: remove some of the unused C-style tr_variantFooBar() methods (#8878)

2026-06-08 13:39:21 -05:00

clients.cc

fix: enable modernize-use-ranges (#8626)

2026-02-26 08:22:29 -06:00

clients.h

refactor: add libtransmission/types.h (#8449)

2026-02-11 16:52:29 -06:00

CMakeLists.txt

feat: add BEP 55 uTP hole punching (#8884)

2026-08-23 17:46:41 -05:00

completion.cc

fix(core): bugprone-narrowing-conversions (#8714)

2026-03-29 21:41:10 -05:00

completion.h

refactor: use std tools for the log message queue (#8897)

2026-06-11 13:04:49 -05:00

config-dir-lock.cc

feat: hold a lock on the session's config dir (#9022)

2026-08-03 09:57:37 -05:00

config-dir-lock.h

feat: hold a lock on the session's config dir (#9022)

2026-08-03 09:57:37 -05:00

constants.h

refactor: async file IO prep (#8740)

2026-03-29 21:31:12 -05:00

crypto-utils-ccrypto.cc

refactor: add libtransmission/types.h (#8449)

2026-02-11 16:52:29 -06:00

crypto-utils-fallback.cc

fix(core): bugprone-narrowing-conversions (#8714)

2026-03-29 21:41:10 -05:00

crypto-utils-mbedtls.cc

refactor: add libtransmission/types.h (#8449)

2026-02-11 16:52:29 -06:00

crypto-utils-openssl.cc

fix(core): bugprone-narrowing-conversions (#8714)

2026-03-29 21:41:10 -05:00

crypto-utils-wolfssl.cc

refactor: add libtransmission/types.h (#8449)

2026-02-11 16:52:29 -06:00

crypto-utils.cc

fix(core): bugprone-narrowing-conversions (#8714)

2026-03-29 21:41:10 -05:00

crypto-utils.h

fix(core): bugprone-narrowing-conversions (#8714)

2026-03-29 21:41:10 -05:00

env.cc

refactor: string-utils, file-utils, env (#8417)

2026-02-11 11:21:45 -06:00

env.h

refactor: string-utils, file-utils, env (#8417)

2026-02-11 11:21:45 -06:00

error-types.h

fix: bugprone-narrowing-conversions surrounding error codes (#8716)

2026-03-23 09:12:38 -05:00

error.cc

fix: bugprone-narrowing-conversions surrounding error codes (#8716)

2026-03-23 09:12:38 -05:00

error.h

fix: bugprone-narrowing-conversions surrounding error codes (#8716)

2026-03-23 09:12:38 -05:00

file-piece-map.cc

fix(core): bugprone-narrowing-conversions (#8714)

2026-03-29 21:41:10 -05:00

file-piece-map.h

fix: enable modernize-use-ranges (#8626)

2026-02-26 08:22:29 -06:00

file-posix.cc

fix(core): bugprone-narrowing-conversions (#8714)

2026-03-29 21:41:10 -05:00

file-utils.cc

refactor: string-utils, file-utils, env (#8417)

2026-02-11 11:21:45 -06:00

file-utils.h

refactor: string-utils, file-utils, env (#8417)

2026-02-11 11:21:45 -06:00

file-win32.cc

fix(core): bugprone-narrowing-conversions (#8714)

2026-03-29 21:41:10 -05:00

file.cc

refactor: don't expose <filesystem> in file.h (#8889)

2026-06-14 14:02:14 -05:00

file.h

refactor: don't expose <filesystem> in file.h (#8889)

2026-06-14 14:02:14 -05:00

handshake.cc

refactor: add libtransmission/types.h (#8449)

2026-02-11 16:52:29 -06:00

handshake.h

refactor: add libtransmission/types.h (#8449)

2026-02-11 16:52:29 -06:00

history.h

Update outdated Doxygen params refs for tr_recentHistory (#6791)

2024-05-24 10:31:50 -05:00

inout.cc

refactor: public session settings (#8814)

2026-05-26 15:22:53 -05:00

inout.h

refactor: async file IO prep (#8740)

2026-03-29 21:31:12 -05:00

interned-string.h

refactor: remove char8_t support from quarks and interned strings (#8890)

2026-06-10 10:36:23 -05:00

ip-cache.cc

ci: support visual studio 2026 (#8912)

2026-06-14 10:47:39 -05:00

ip-cache.h

docs: document the global ip cache behaviour in quirky networking environments (#8696)

2026-03-19 18:01:27 -05:00

libt.dox

docs: fix various typos and misspellings (#2955)

2022-04-21 09:28:38 -05:00

local-data.cc

refactor: add LocalData facade (#8743)

2026-03-31 09:13:45 -05:00

local-data.h

refactor: add LocalData facade (#8743)

2026-03-31 09:13:45 -05:00

log.cc

refactor: use std tools for the log message queue (#8897)

2026-06-11 13:04:49 -05:00

log.h

refactor: use std tools for the log message queue (#8897)

2026-06-11 13:04:49 -05:00

lru-cache.h

build: bump clang tools to 20 (#7573)

2025-12-01 23:18:02 -06:00

magnet-metainfo.cc

fix: revert percent-encoding announce urls and webseeds (#8620)

2026-02-25 08:48:34 -06:00

magnet-metainfo.h

refactor: remove TR_CONSTEXPR20 (#8228)

2026-01-26 14:36:04 -06:00

makemeta.cc

refactor: add libtransmission/types.h (#8449)

2026-02-11 16:52:29 -06:00

makemeta.h

refactor: add libtransmission/types.h (#8449)

2026-02-11 16:52:29 -06:00

mime-types.h

fix: modernize-use-designated-initializers in core and tests (#8186)

2026-01-23 21:50:08 -06:00

mime-types.js

fix: modernize-use-designated-initializers in core and tests (#8186)

2026-01-23 21:50:08 -06:00

net.cc

refactor: collapse is_martian_addr() into is_valid_for_peers() (#9096)

2026-09-03 23:07:14 -05:00

net.h

ci: support visual studio 2026 (#8912)

2026-06-14 10:47:39 -05:00

open-files.cc

refactor: public session settings (#8814)

2026-05-26 15:22:53 -05:00

open-files.h

refactor: public session settings (#8814)

2026-05-26 15:22:53 -05:00

peer-common.h

refactor: add libtransmission/types.h (#8449)

2026-02-11 16:52:29 -06:00

peer-io.cc

feat: add BEP 55 uTP hole punching (#8884)

2026-08-23 17:46:41 -05:00

peer-io.h

feat: add BEP 55 uTP hole punching (#8884)

2026-08-23 17:46:41 -05:00

peer-mgr-wishlist.cc

feat: skip closer pieces preference in sequential mode (#8804)

2026-05-25 09:29:18 -05:00

peer-mgr-wishlist.h

feat: skip closer pieces preference in sequential mode (#8804)

2026-05-25 09:29:18 -05:00

peer-mgr.cc

feat: add BEP 55 uTP hole punching (#8884)

2026-08-23 17:46:41 -05:00

peer-mgr.h

feat: add BEP 55 uTP hole punching (#8884)

2026-08-23 17:46:41 -05:00

peer-mse.cc

refactor: add libtransmission/types.h (#8449)

2026-02-11 16:52:29 -06:00

peer-mse.h

refactor: add libtransmission/types.h (#8449)

2026-02-11 16:52:29 -06:00

peer-msgs.cc

feat: add BEP 55 uTP hole punching (#8884)

2026-08-23 17:46:41 -05:00

peer-msgs.h

feat: add BEP 55 uTP hole punching (#8884)

2026-08-23 17:46:41 -05:00

peer-socket-tcp.cc

ci: support visual studio 2026 (#8912)

2026-06-14 10:47:39 -05:00

peer-socket-tcp.h

refactor: put libutp behind BSD-like abstraction (#8060)

2026-05-27 13:38:05 -05:00

peer-socket-utp.cc

ci: support visual studio 2026 (#8912)

2026-06-14 10:47:39 -05:00

peer-socket-utp.h

refactor: put libutp behind BSD-like abstraction (#8060)

2026-05-27 13:38:05 -05:00

peer-socket.cc

refactor: put libutp behind BSD-like abstraction (#8060)

2026-05-27 13:38:05 -05:00

peer-socket.h

refactor: put libutp behind BSD-like abstraction (#8060)

2026-05-27 13:38:05 -05:00

platform.cc

fix: enable modernize-use-ranges (#8626)

2026-02-26 08:22:29 -06:00

platform.h

build: lint header files with clang-tidy (#7527)

2025-05-07 22:10:16 +01:00

port-forwarding-natpmp.cc

refactor: add libtransmission/types.h (#8449)

2026-02-11 16:52:29 -06:00

port-forwarding-natpmp.h

refactor: add libtransmission/types.h (#8449)

2026-02-11 16:52:29 -06:00

port-forwarding-upnp.cc

refactor: add libtransmission/types.h (#8449)

2026-02-11 16:52:29 -06:00

port-forwarding-upnp.h

refactor: add libtransmission/types.h (#8449)

2026-02-11 16:52:29 -06:00

port-forwarding.cc

refactor: add libtransmission/types.h (#8449)

2026-02-11 16:52:29 -06:00

port-forwarding.h

refactor: add libtransmission/types.h (#8449)

2026-02-11 16:52:29 -06:00

quark.cc

feat: add BEP 55 uTP hole punching (#8884)

2026-08-23 17:46:41 -05:00

quark.h

feat: add BEP 55 uTP hole punching (#8884)

2026-08-23 17:46:41 -05:00

resume.cc

refactor: migrate settings to reuse RPC keys for seed ratio settings (#8821)

2026-05-28 13:24:34 -05:00

resume.h

refactor: add libtransmission/types.h (#8449)

2026-02-11 16:52:29 -06:00

rpc-server.cc

ci: support visual studio 2026 (#8912)

2026-06-14 10:47:39 -05:00

rpc-server.h

refactor: public session settings (#8814)

2026-05-26 15:22:53 -05:00

rpcimpl.cc

feat: add BEP 55 uTP hole punching (#8884)

2026-08-23 17:46:41 -05:00

rpcimpl.h

feat: accommodate empty but valid blocklists (#8817)

2026-05-27 09:10:50 -05:00

serializer.cc

refactor: remove u8string-related serializers (#8916)

2026-06-15 09:44:10 -05:00

serializer.h

refactor: migrate Prefs to tr::serializer (#8820)

2026-06-02 14:36:01 -05:00

session-alt-speeds.cc

refactor: add libtransmission/types.h (#8449)

2026-02-11 16:52:29 -06:00

session-alt-speeds.h

refactor: public session settings (#8814)

2026-05-26 15:22:53 -05:00

session-id.cc

build: bump to C++20 (#7191)

2026-01-20 16:27:34 -06:00

session-id.h

build: bump to C++20 (#7191)

2026-01-20 16:27:34 -06:00

session-settings.h

refactor: use std tools for the log message queue (#8897)

2026-06-11 13:04:49 -05:00

session-thread.cc

introduce 3 priority levels to session event loop, set peer traffic t… (#7140)

2026-01-31 15:07:05 -06:00

session-thread.h

refactor: simplify session-thread.h with std::bind_front (#8262)

2026-01-29 08:06:23 -06:00

session.cc

feat: hold a lock on the session's config dir (#9022)

2026-08-03 09:57:37 -05:00

session.h

feat: hold a lock on the session's config dir (#9022)

2026-08-03 09:57:37 -05:00

stats.cc

daemon: avoid periodic idle stats.json rewrites (#8679)

2026-03-23 09:19:44 -05:00

stats.h

fix: bugprone-narrowing-conversions surrounding tr_session_stats::uploadedBytes (#8725)

2026-03-29 14:01:13 -05:00

string-utils.cc

refactor: remove u8string-related serializers (#8916)

2026-06-15 09:44:10 -05:00

string-utils.h

refactor: remove u8string-related serializers (#8916)

2026-06-15 09:44:10 -05:00

string-utils.mm

refactor: string-utils, file-utils, env (#8417)

2026-02-11 11:21:45 -06:00

subprocess-posix.cc

fix: potential fd leak when running scripts (#8524)

2026-02-15 23:06:49 -06:00

subprocess-win32.cc

ci: support visual studio 2026 (#8912)

2026-06-14 10:47:39 -05:00

subprocess.h

refactor: remove the tr_error** idiom (#6198)

2023-11-04 11:39:41 -05:00

timer-ev.cc

fix(core): bugprone-narrowing-conversions (#8714)

2026-03-29 21:41:10 -05:00

timer-ev.h

refactor: rename our namespace to tr (#8256)

2026-01-28 18:11:34 -06:00

timer.h

refactor: rename our namespace to tr (#8256)

2026-01-28 18:11:34 -06:00

torrent-ctor.cc

refactor: remove unused tr_ctorSetFilePriorities() (#8667)

2026-03-09 17:01:03 -05:00

torrent-ctor.h

refactor: add libtransmission/types.h (#8449)

2026-02-11 16:52:29 -06:00

torrent-files.cc

fix(core): bugprone-narrowing-conversions (#8714)

2026-03-29 21:41:10 -05:00

torrent-files.h

fix: enable modernize-use-ranges (#8626)

2026-02-26 08:22:29 -06:00

torrent-magnet.cc

fix: use static_cast to cast from void pointers (#8724)

2026-03-29 14:00:49 -05:00

torrent-magnet.h

build: bump to C++20 (#7191)

2026-01-20 16:27:34 -06:00

torrent-metainfo.cc

fix: reset metainfo before parsing new benc (#8590)

2026-02-23 09:07:26 -06:00

torrent-metainfo.h

refactor: add libtransmission/types.h (#8449)

2026-02-11 16:52:29 -06:00

torrent-queue.cc

fix(core): bugprone-narrowing-conversions (#8714)

2026-03-29 21:41:10 -05:00

torrent-queue.h

fix: preserve relative order in queue_move_up and queue_move_down (#8685)

2026-04-29 19:45:28 -05:00

torrent.cc

fix: performance-move-const-arg (#8788)

2026-05-25 14:04:52 -05:00

torrent.h

feat: add BEP 55 uTP hole punching (#8884)

2026-08-23 17:46:41 -05:00

torrents.cc

fix: enable modernize-use-ranges (#8626)

2026-02-26 08:22:29 -06:00

torrents.h

fix: enable modernize-use-ranges (#8626)

2026-02-26 08:22:29 -06:00

tr-arc4.h

fix: use static_cast to cast from void pointers (#8724)

2026-03-29 14:00:49 -05:00

tr-assert.cc

ci: support visual studio 2026 (#8912)

2026-06-14 10:47:39 -05:00

tr-assert.h

ci: support visual studio 2026 (#8912)

2026-06-14 10:47:39 -05:00

tr-buffer.h

refactor: put libutp behind BSD-like abstraction (#8060)

2026-05-27 13:38:05 -05:00

tr-dht.cc

ci: support visual studio 2026 (#8912)

2026-06-14 10:47:39 -05:00

tr-dht.h

refactor: add libtransmission/types.h (#8449)

2026-02-11 16:52:29 -06:00

tr-getopt.cc

refactor: string-utils, file-utils, env (#8417)

2026-02-11 11:21:45 -06:00

tr-getopt.h

feat: allow optional arguments in tr_getopt() (#7510)

2025-10-15 12:08:11 -05:00

tr-lpd.cc

ci: support visual studio 2026 (#8912)

2026-06-14 10:47:39 -05:00

tr-lpd.h

refactor: add libtransmission/types.h (#8449)

2026-02-11 16:52:29 -06:00

tr-macros.h

refactor: add libtransmission/types.h (#8449)

2026-02-11 16:52:29 -06:00

tr-strbuf.h

fix: FTBFS with fmt 12.2.0 (#8942) (#8948)

2026-06-27 07:56:22 -05:00

tr-udp.cc

ci: support visual studio 2026 (#8912)

2026-06-14 10:47:39 -05:00

tr-utp.cc

refactor: put libutp behind BSD-like abstraction (#8060)

2026-05-27 13:38:05 -05:00

tr-utp.h

feat: µTP delayed ack (#6586)

2024-03-24 20:48:23 -05:00

transmission.h

feat: hold a lock on the session's config dir (#9022)

2026-08-03 09:57:37 -05:00

types.h

feat: add BEP 55 uTP hole punching (#8884)

2026-08-23 17:46:41 -05:00

utils-ev.cc

introduce 3 priority levels to session event loop, set peer traffic t… (#7140)

2026-01-31 15:07:05 -06:00

utils-ev.h

introduce 3 priority levels to session event loop, set peer traffic t… (#7140)

2026-01-31 15:07:05 -06:00

utils.cc

ci: support visual studio 2026 (#8912)

2026-06-14 10:47:39 -05:00

utils.h

ci(gtk): run clang-tidy (#8251)

2026-02-17 17:53:01 -06:00

values.h

refactor: use spaceship operator in tr::Values (#8518)

2026-02-15 23:06:02 -06:00

variant-benc.cc

refactor: remove some of the unused C-style tr_variantFooBar() methods (#8878)

2026-06-08 13:39:21 -05:00

variant-json.cc

refactor: remove some of the unused C-style tr_variantFooBar() methods (#8878)

2026-06-08 13:39:21 -05:00

variant.cc

refactor: add tr_variant::Map::merge(), tr_variant::Map::clone() (#8907)

2026-06-14 16:19:24 -05:00

variant.h

refactor: add tr_variant::Map::merge(), tr_variant::Map::clone() (#8907)

2026-06-14 16:19:24 -05:00

verify.cc

refactor: add libtransmission/types.h (#8449)

2026-02-11 16:52:29 -06:00

verify.h

refactor: add libtransmission/types.h (#8449)

2026-02-11 16:52:29 -06:00

version.h.in

build: lint header files with clang-tidy (#7527)

2025-05-07 22:10:16 +01:00

watchdir-base.h

refactor: rename our namespace to tr (#8256)

2026-01-28 18:11:34 -06:00

watchdir-generic.cc

refactor: rename our namespace to tr (#8256)

2026-01-28 18:11:34 -06:00

watchdir-inotify.cc

refactor: string-utils, file-utils, env (#8417)

2026-02-11 11:21:45 -06:00

watchdir-kqueue.cc

refactor: add libtransmission/types.h (#8449)

2026-02-11 16:52:29 -06:00

watchdir-win32.cc

ci: support visual studio 2026 (#8912)

2026-06-14 10:47:39 -05:00

watchdir.cc

fix: readability-container-contains (#8656)

2026-03-05 10:00:29 -06:00

watchdir.h

refactor: rename our namespace to tr (#8256)

2026-01-28 18:11:34 -06:00

web-utils.cc

fix: parse magnet links that carry an empty authority (#9020)

2026-08-02 15:51:26 -05:00

web-utils.h

refactor: add libtransmission/types.h (#8449)

2026-02-11 16:52:29 -06:00

web.cc

fix: lost wakeup that could hang tr_web shutdown (#9001)

2026-08-21 07:06:55 -05:00

web.h

refactor: make tr_web use std::chrono for deadline computation (#8224)

2026-01-26 19:14:13 -06:00

webseed.cc

refactor: async file IO prep (#8740)

2026-03-29 21:31:12 -05:00

webseed.h

refactor: add libtransmission/types.h (#8449)

2026-02-11 16:52:29 -06:00