* ensure l:bufferlines is defined when using preview window
previously, when using the preview window to show signatures, the code
failed with an stacktrace like:
"s:on_stdout client request on_notification() error",
"Vim(return):E121: Undefined variable: l:bufferlines",
"function <SNR>118_out_cb[2]..
<SNR>107_on_stdout[79]..
<SNR>92_request_on_notification[3]..
<SNR>93_createNext[1]..
<SNR>93_subscribeSourceCallback[2]..
<lambda>738[1]..
<SNR>94_handle_signature_help[48]..
lsp#ui#vim#output#preview[39]..
lsp#ui#vim#output#get_size_info, line 22"
This commit ensures that the required variable is properly defined in
all the situations (popup, nvim, preview window)
* removed superfluous return statement
* Show documentation in Vim popup
* Use timer
* Reuse logic from output.vim
* Change default text
* Rename functions
* Refactor
* Use v:event
* Add comment
* Remove log
* Refactor
* Implement documentation in Neovim
* Cleanup Neovim popup
* Let Neovim float take all available space
* Extract get_size_info
* Reuse sizing logic from output.vim
* Fix Neovim positioning being reset
* Update autoload/lsp/ui/vim/documentation.vim
Co-Authored-By: Christian Clason <christian.clason@uni-due.de>
* Make vint happy
* Retrigger Travis CI
* add g:lsp_documentation_float flag
* fix lint issues
Co-authored-by: Christian Clason <christian.clason@uni-due.de>
Co-authored-by: Prabir Shrestha <mail@prabir.me>
If g:lsp_preview_float is enabled there is no reason to close the
preview window on LspHover and LspSignatureHelp. Moreover the preview
window may be in use by other plugins or by the user.
Co-authored-by: mattn <mattn.jp@gmail.com>
* Improve signature help with lexima.vim
* Fix buffer change problem
* Display signature help after cursor jumped
* Fix event
* Add _ prefix for inner functions
* Add LspPeekDefinition
* Add documentation
* Add lsp-peek-definition mapping to documentation
* Add link to Vim preview-window help
* Rewrite LspPeekDefinition using preview window
* Implement peek for Vim popup window
* Make LspPeekDefinition work in Neovim
* Support align in Neovim
* Fix linter errors
* Extract duplicate code to s:align_preview function
* Merge setlocal settings in one line
* Remove suppress_close
* Clean up cursor movement for preview window
* Move Neovim cursor code to separate function
* Allow customising peek alignment
* Move Vim alignment code to separate function
* Implement Vim alignment of popup window
* Cleanup
* Remove extraneous lines
* Move set_cursor logic
* Move scrolloff setting
* Make function calls a bit more consistent
* Vim popup window fixes
* Remove extraneous call
* Fix Vim alignment
* Remove hardcoded width
* Add abort to closure function
* Fix artifacts
* Fix wrong height if popup above cursor
* Add remaining Peek commands
Add LspPeekImplementation, LspPeekTypeDefinition and LspPeekDeclaration.
* Fix wrong positioning of Vim popup
* Allow setting max width of popup window in Vim
* Allow setting max width of popup window in Neovim
* Add documentation
* Uses spaces instead of tabs for indent in help
* Move Neovim logic to s:setcontent
* Rename setting to g:lsp_preview_max_width
* Replace 'popup' with 'preview'
* Save/restore cursor position
* Cosmetic change
* selection should be inclusive
Because exclusive doesn't select fisrt character with 1GvG0
* Remove last extra \n
* Be graceful
* Use winsaveview/winrestoreview
* Create preview window instead of using quickfix list
This removes from us burden of providing formatting for content as this
is now simple as setting proper filetype.
* Create custom filetype for preview window
This will allow users to provide their own mappings and features in
hover window easily.
* Add proper statusline for LSP Hover
* Guard and undo_ftplugin
* Support all LSP hover syntaxes
