The augroup/au! wrapper was needed when registration was done with
':autocmd User lsp_setup', to avoid stacking duplicate autocmds on
re-source. Now that registration is a plain function call, augroup has
no effect on it. Drop the wrapper where it only enclosed the
registration, and keep augroups only around real autocmds, moving the
registration call out in front of them (the original order, call then
autocmd, is preserved).
The LspRegisterServer user command was introduced to hide the
version-dependent ':autocmd User lsp_setup ++once' boilerplate (#7),
but registration has been immediate since loading became lazy per
filetype. A user command's argument is evaluated in the script context
where the command was defined, so settings files could not use
script-local helpers. Calling the function directly evaluates the
argument in each settings file's own context, which allows the global
Vim_lsp_settings_* helper functions to become script-local. The
LspRegisterServer command itself is kept for backward compatibility.
Yasuhiro Matsumoto