From 28e75c5f3151a900db8bd91744aa4c7f4deb38e9 Mon Sep 17 00:00:00 2001 From: Yasuhiro Matsumoto Date: Fri, 3 Apr 2026 08:39:11 +0000 Subject: [PATCH] patch 9.2.0286: still some unnecessary (int) casts in alloc() Problem: still some unnecessary (int) casts in alloc() Solution: Remove more unnecessary (int) casts before alloc() calls (Yasuhiro Matsumoto). Follow-up to patch 9.2.0283. Remove remaining (int) casts in vim9script.c and netbeans.c. vim9script.c: lengths are derived from STRLEN() on file paths, bounded by PATH_MAX. netbeans.c: all operands are already int, so the (int) cast is redundant and no truncation can occur. related: #19888 closes: #19893 Signed-off-by: Yasuhiro Matsumoto Signed-off-by: Christian Brabandt --- src/netbeans.c | 2 +- src/version.c | 2 ++ src/vim9script.c | 6 +++--- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/netbeans.c b/src/netbeans.c index 976a2574a1..66f563c6cb 100644 --- a/src/netbeans.c +++ b/src/netbeans.c @@ -937,7 +937,7 @@ nb_partialremove(linenr_T lnum, colnr_T first, colnr_T last) return; if (lastbyte >= oldlen) lastbyte = oldlen - 1; - newtext = alloc(oldlen - (int)(lastbyte - first)); + newtext = alloc(oldlen - (lastbyte - first)); if (newtext == NULL) return; diff --git a/src/version.c b/src/version.c index ce87898c7f..65518999e5 100644 --- a/src/version.c +++ b/src/version.c @@ -734,6 +734,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ +/**/ + 286, /**/ 285, /**/ diff --git a/src/vim9script.c b/src/vim9script.c index f9868ee0e6..4babbeea2a 100644 --- a/src/vim9script.c +++ b/src/vim9script.c @@ -460,7 +460,7 @@ handle_import( { // Relative to current script: "./name.vim", "../../name.vim". len = STRLEN(si->sn_name) - STRLEN(tail) + STRLEN(tv.vval.v_string) + 2; - from_name = alloc((int)len); + from_name = alloc(len); if (from_name == NULL) goto erret; vim_strncpy(from_name, si->sn_name, tail - si->sn_name); @@ -485,7 +485,7 @@ handle_import( char_u *from_name; // Find file in "autoload" subdirs in 'runtimepath'. - from_name = alloc((int)len); + from_name = alloc(len); if (from_name == NULL) goto erret; vim_snprintf((char *)from_name, len, "autoload/%s", tv.vval.v_string); @@ -512,7 +512,7 @@ handle_import( char_u *from_name; // Find file in "import" subdirs in 'runtimepath'. - from_name = alloc((int)len); + from_name = alloc(len); if (from_name == NULL) goto erret; vim_snprintf((char *)from_name, len, "import/%s", tv.vval.v_string);