apply CLion inspection hints

.gitignore

@@ -5,4 +5,3 @@ Cargo.lock
 target/
 .DS_Store
 cmake-build-debug/
-Output/

source/.clang-format

@@ -12,7 +12,7 @@ AlignTrailingComments: false
 AllowAllArgumentsOnNextLine: true
 AllowAllConstructorInitializersOnNextLine: true
 AllowAllParametersOfDeclarationOnNextLine: true
-AllowShortBlocksOnASingleLine: false
+AllowShortBlocksOnASingleLine: "Empty"
 AllowShortCaseLabelsOnASingleLine: false
 AllowShortFunctionsOnASingleLine: All
 AllowShortLambdasOnASingleLine: All
@@ -27,7 +27,7 @@ BinPackParameters: true
 BraceWrapping:
   AfterCaseLabel:  false
   AfterClass:      false
-  AfterControlStatement: false
+  AfterControlStatement: "false"
   AfterEnum:       false
   AfterFunction:   true
   AfterNamespace:  false
@@ -117,7 +117,7 @@ SpacesInContainerLiterals: true
 SpacesInCStyleCastParentheses: false
 SpacesInParentheses: false
 SpacesInSquareBrackets: false
-Standard: Cpp11
+Standard: "c++17"
 StatementMacros:
   - Q_UNUSED
   - QT_REQUIRE_VERSION

source/bear/source/bear.py

@@ -757,7 +757,8 @@ class CompilationDatabase:
         """ Saves compilations to given file.
 
         :param filename: the destination file name
-        :param iterator: iterator of Compilation objects. """
+        :param iterator: iterator of Compilation objects.
+        :param field_output: request to emit "output" field. """
 
         entries = [entry.as_db_entry(field_output) for entry in iterator]
         with open(filename, 'w') as handle:

source/intercept-library/library/lib.cc

@@ -34,13 +34,13 @@ namespace {
         while (va_arg(args, const char*) != nullptr)
             ++arg_count;
         return arg_count;
-    };
+    }
 
     void va_copy_n(va_list& args, char* argv[], size_t const argc)
     {
         for (size_t idx = 0; idx <= argc; ++idx)
             argv[idx] = va_arg(args, char*);
-    };
+    }
 }
 
 /**

test/bin/assert_compilation

@@ -79,4 +79,4 @@ def to_string(args):
 
 
 if __name__ == "__main__":
-    sys.exit(main())
+    sys.exit(main())

test/bin/assert_intercepted

@@ -77,4 +77,4 @@ def to_string(args):
 
 
 if __name__ == "__main__":
-    sys.exit(main())
+    sys.exit(main())

test/lit.cfg

@@ -202,14 +202,13 @@ if is_windows:
 
 # check for library preload is available
 def is_preload_disabled():
-    # type: (str) -> bool
+    # type: () -> bool
     """ Library-based interposition will fail silently if SIP is enabled,
     so this should be detected. You can detect whether SIP is enabled on
     Darwin by checking whether (1) there is a binary called 'csrutil' in
     the path and, if so, (2) whether the output of executing 'csrutil status'
     contains 'System Integrity Protection status: enabled'.
 
-    :param platform: name of the platform (returned by sys.platform),
     :return: True if library preload will fail by the dynamic linker. """
 
     if is_windows:
@@ -231,4 +230,4 @@ if not is_preload_disabled():
 
 print(config.substitutions)
 print(config.environment)
-print(config.available_features)
+print(config.available_features)