averello/bitcoin-mirror
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-28 18:25:48 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
master
bitcoin-mirror/src
History
Ava Chow 5a6dd7c693 Merge bitcoin/bitcoin#34661: ipc mining: Prevent `Assertion m_node.chainman' failed`` errors on early startup 
bbc8f1e0a7 ipc mining: Prevent ``Assertion `m_node.chainman' failed`` errors on early startup (Ryan Ofsky)
a7cabf92e4 init refactor: Only initialize node.notifications one time (Ryan Ofsky)
c8e332cb33 init refactor: Remove node.init accesss in AppInitInterfaces (Ryan Ofsky)

Pull request description:

  This fixes ``Assertion `m_node.chainman' failed`` errors first reported https://github.com/bitcoin/bitcoin/issues/33994#issuecomment-3602551596 when IPC mining methods are called before ChainstateManager is loaded.

  The fix works by making the `Init.makeMining` method wait until chainstate data is loaded. It's probably the simplest possible fix but other alternatives like moving the wait to `Mining.createNewBlock` were discussed in the thread https://github.com/bitcoin/bitcoin/pull/34661#discussion_r2848176298 and could be implemented later without changes to clients.

ACKs for top commit:
  Sjors:
    utACK bbc8f1e0a7
  ismaelsadeeq:
    ACK bbc8f1e0a7
  achow101:
    ACK bbc8f1e0a7

Tree-SHA512: 3e2e4e28ccff364b2303efd06ce337a229c28609076638500acb29559f716a15ad99409c6970ce9ad91776d53e3f9d959f1bbbd144ea9a4a2fb578ddbf2da267
2026-02-27 15:07:57 -08:00
..
bench
clusterlin: use 'cost' terminology instead of 'iters' (refactor)
2026-02-24 10:08:47 -05:00
common
Merge bitcoin/bitcoin#34093: netif: fix compilation warning in QueryDefaultGatewayImpl()
2026-02-27 11:59:03 +00:00
compat
refactor: Use static_cast<decltype(...)> to suppress integer sanitizer warning
2026-02-18 21:29:07 +01:00
consensus
consensus/doc: explain GetValueOut() precondition
2026-02-02 19:32:14 +01:00
crc32c
Update crc32c subtree to latest upstream master
2025-08-07 09:27:25 +01:00
crypto
iwyu: Add temporary mapping to work around upstream bug
2026-01-30 11:50:17 +00:00
index
Merge bitcoin/bitcoin#29770: index: Check all necessary block data is available before starting to sync
2026-02-20 15:58:48 -08:00
init
log: Print warning about privacy-sensitive log info unconditionally
2026-01-27 13:08:50 +01:00
interfaces
ipc mining: Prevent `Assertion m_node.chainman' failed`` errors on early startup
2026-02-24 10:15:14 -05:00
ipc
test: refactor, decouple HasReason from test framework machinery
2026-02-26 11:28:55 -03:00
kernel
Merge bitcoin/bitcoin#34546: kernel: Avoid duplicating symbols in the kernel library
2026-02-13 11:11:14 +00:00
leveldb
Bump leveldb subtree
2026-02-03 11:19:01 +01:00
logging
logging: use util/log.h where possible
2026-02-02 17:22:31 +00:00
minisketch
Update minisketch subtree to latest upstream
2025-10-13 12:33:23 +01:00
node
ipc mining: Prevent `Assertion m_node.chainman' failed`` errors on early startup
2026-02-24 10:15:14 -05:00
policy
Merge bitcoin/bitcoin#33616: policy: don't CheckEphemeralSpends on reorg
2026-02-25 17:38:13 +01:00
primitives
txgraph: pass fallback_order to TxGraph (preparation)
2026-02-09 15:55:58 -05:00
qt
qt: Update src/qt/locale/bitcoin_en.xlf after string freeze
2026-02-20 10:31:10 +00:00
rpc
Merge bitcoin/bitcoin#34184: mining: add cooldown to createNewBlock() immediately after IBD
2026-02-24 06:54:17 -05:00
script
Merge bitcoin/bitcoin#34141: miniscript: Use Func and Expr when parsing keys, hashes, and locktimes
2026-02-21 12:18:56 +01:00
secp256k1
Update secp256k1 subtree to latest master
2026-02-02 15:21:14 +00:00
support
kernel: avoid potential duplicate object in shared library/binary
2026-02-13 08:50:50 +01:00
test
Merge bitcoin/bitcoin#34661: ipc mining: Prevent `Assertion m_node.chainman' failed`` errors on early startup
2026-02-27 15:07:57 -08:00
univalue
ci, iwyu: Fix warnings in src/univalue and treat them as errors
2026-01-31 10:41:50 +00:00
util
Merge bitcoin/bitcoin#34562: ThreadPool follow-ups, proactive shutdown and HasReason dependency cleanup
2026-02-26 12:44:11 -08:00
wallet
Merge bitcoin/bitcoin#34562: ThreadPool follow-ups, proactive shutdown and HasReason dependency cleanup
2026-02-26 12:44:11 -08:00
zmq
ci, iwyu: Fix warnings in src/zmq and treat them as errors
2026-01-29 14:38:35 +00:00
.clang-format
ci, iwyu: Fix warnings in src/zmq and treat them as errors
2026-01-29 14:38:35 +00:00
.clang-tidy
doc: Clarify why performance-move-const-arg.CheckTriviallyCopyableMove=false
2026-02-06 08:37:19 +01:00
addrdb.cpp
log: Properly log warnings with warn loglevel in addrdb
2025-07-10 11:24:40 +02:00
addrdb.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
addresstype.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
addresstype.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
addrman_impl.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
addrman.cpp
refactor: Unify asmap version calculation and naming
2026-01-20 23:45:29 +01:00
addrman.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
arith_uint256.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
arith_uint256.h
refactor(headerssync): Extract test constants ahead of breakup into functions
2025-09-12 22:28:41 +02:00
attributes.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
banman.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
banman.h
doc: remove For ... comments
2025-05-19 16:40:33 +01:00
base58.cpp
clang-tidy: Apply modernize-deprecated-headers
2025-06-03 15:13:54 +02:00
base58.h
…
bech32.cpp
scripted-diff: Bump copyright headers after include changes
2025-06-03 15:13:57 +02:00
bech32.h
scripted-diff: Bump copyright headers after include changes
2025-06-03 15:13:57 +02:00
bip324.cpp
refactor: Sort includes of touched source files
2025-06-03 19:56:55 +02:00
bip324.h
…
bitcoin-chainstate.cpp
kernel: Add Handle/View pattern for BlockValidationState
2026-01-21 19:40:25 +05:30
bitcoin-cli-res.rc
doc, windows: CompanyName "Bitcoin" => "Bitcoin Core project"
2025-06-10 15:14:24 +02:00
bitcoin-cli.cpp
wallet, rpc:remove settxfee and paytxfee
2026-02-13 10:52:25 +01:00
bitcoin-res.rc
doc, windows: CompanyName "Bitcoin" => "Bitcoin Core project"
2025-06-10 15:14:24 +02:00
bitcoin-tx-res.rc
doc, windows: CompanyName "Bitcoin" => "Bitcoin Core project"
2025-06-10 15:14:24 +02:00
bitcoin-tx.cpp
Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers
2025-12-19 16:56:02 +00:00
bitcoin-util-res.rc
doc, windows: CompanyName "Bitcoin" => "Bitcoin Core project"
2025-06-10 15:14:24 +02:00
bitcoin-util.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
bitcoin-wallet-res.rc
doc, windows: CompanyName "Bitcoin" => "Bitcoin Core project"
2025-06-10 15:14:24 +02:00
bitcoin-wallet.cpp
Remove no longer necessary WinCmdLineArgs class
2025-10-06 19:41:35 +01:00
bitcoin.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
bitcoind-res.rc
doc, windows: CompanyName "Bitcoin" => "Bitcoin Core project"
2025-06-10 15:14:24 +02:00
bitcoind.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
blockencodings.cpp
log,blocks: avoid ComputeTotalSize and GetHash work when logging is disabled
2026-01-19 20:20:13 +01:00
blockencodings.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
blockfilter.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
blockfilter.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
chain.cpp
Merge bitcoin/bitcoin#32740: refactor: Header sync optimisations & simplifications
2026-01-14 11:38:07 -08:00
chain.h
validation: remove BLOCK_FAILED_MASK
2026-02-17 21:40:46 +05:30
chainparams.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
chainparams.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
chainparamsbase.cpp
scripted-diff: Bump copyright headers after include changes
2025-06-03 15:13:57 +02:00
chainparamsbase.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
chainparamsseeds.h
contrib: update fixed seeds
2025-09-03 11:23:30 +01:00
checkqueue.h
logging: use util/log.h where possible
2026-02-02 17:22:31 +00:00
clientversion.cpp
refactor: Avoid -W*-whitespace in git archive
2025-11-13 09:33:36 +01:00
clientversion.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
cluster_linearize.h
clusterlin: adopt trained cost model (feature)
2026-02-24 12:05:17 -05:00
CMakeLists.txt
Merge bitcoin/bitcoin#24539: Add a "tx output spender" index
2026-02-20 09:27:17 +01:00
coins.cpp
util: introduce TrySub to prevent unsigned underflow
2026-02-23 15:56:25 +01:00
coins.h
util: introduce TrySub to prevent unsigned underflow
2026-02-23 15:56:25 +01:00
compressor.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
compressor.h
…
core_io.cpp
Merge bitcoin/bitcoin#34524: refactor: [rpc] Remove confusing and brittle integral casts (take 2)
2026-02-09 13:32:28 +00:00
core_io.h
refactor: [move-only] Merge core_io module
2026-01-19 12:57:16 +01:00
core_memusage.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
cuckoocache.h
doc: remove For ... comments
2025-05-19 16:40:33 +01:00
dbwrapper.cpp
logging: use util/log.h where possible
2026-02-02 17:22:31 +00:00
dbwrapper.h
refactor: Use SpanReader over DataStream
2026-02-02 18:42:44 +01:00
deploymentinfo.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
deploymentinfo.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
deploymentstatus.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
deploymentstatus.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
dummywallet.cpp
wallet, rpc:remove settxfee and paytxfee
2026-02-13 10:52:25 +01:00
external_signer.cpp
util: Remove brittle and confusing sp::Popen(std::string)
2026-02-17 12:55:26 +01:00
external_signer.h
util: Remove brittle and confusing sp::Popen(std::string)
2026-02-17 12:55:26 +01:00
flatfile.cpp
logging: use util/log.h where possible
2026-02-02 17:22:31 +00:00
flatfile.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
hash.cpp
…
hash.h
…
headerssync.cpp
refactor: Use reference for chain_start in HeadersSyncState
2025-11-20 11:34:21 +09:00
headerssync.h
refactor: Use reference for chain_start in HeadersSyncState
2025-11-20 11:34:21 +09:00
httprpc.cpp
Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers
2025-12-19 16:56:02 +00:00
httprpc.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
httpserver.cpp
Merge bitcoin/bitcoin#34577: http: fix submission during shutdown race
2026-02-19 12:41:12 -08:00
httpserver.h
http: replace WorkQueue and threads handling for ThreadPool
2026-01-30 16:17:12 -05:00
i2p.cpp
log: Remove brittle and confusing LogPrintLevel
2025-12-13 13:43:24 +01:00
i2p.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
indirectmap.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
init.cpp
ipc mining: Prevent `Assertion m_node.chainman' failed`` errors on early startup
2026-02-24 10:15:14 -05:00
init.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
key_io.cpp
scripted-diff: Bump copyright headers after include changes
2025-06-03 15:13:57 +02:00
key_io.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
key.cpp
Merge bitcoin/bitcoin#29675: wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys
2025-10-14 16:25:52 -04:00
key.h
sign: Add CreateMuSig2PartialSig
2025-09-30 11:06:43 -07:00
logging.cpp
logging: Move message formatting to util/log.h
2026-02-02 17:22:31 +00:00
logging.h
logging: Move message formatting to util/log.h
2026-02-02 17:22:31 +00:00
mapport.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
mapport.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
memusage.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
merkleblock.cpp
Merge bitcoin/bitcoin#32740: refactor: Header sync optimisations & simplifications
2026-01-14 11:38:07 -08:00
merkleblock.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
musig.cpp
musig: Move MUSIG_CHAINCODE to musig.cpp
2025-11-24 18:48:43 +01:00
musig.h
musig: Move MUSIG_CHAINCODE to musig.cpp
2025-11-24 18:48:43 +01:00
net_permissions.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
net_permissions.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
net_processing.cpp
Merge bitcoin/bitcoin#34054: net processing: Add ibd check before processing block for txdownloadman
2026-02-26 10:33:29 +00:00
net_processing.h
rpc: Add abortprivatebroadcast
2026-02-11 19:46:19 -05:00
net_types.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
net_types.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
net.cpp
Merge bitcoin/bitcoin#34483: refactor: Use SpanReader over DataStream
2026-02-06 18:00:18 -08:00
net.h
Merge bitcoin/bitcoin#34511: test: fully reset the state of CConnman in tests
2026-02-13 11:17:26 +00:00
netaddress.cpp
refactor: increase string_view usage
2025-10-02 12:53:55 +01:00
netaddress.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
netbase.cpp
Modernize GetBindAddress()
2026-01-22 10:35:14 -05:00
netbase.h
Merge bitcoin/bitcoin#34242: Prepare string and net utils for future HTTP operations
2026-01-23 13:25:42 +01:00
netgroup.cpp
refactor: Use span instead of vector for data in util/asmap
2026-01-20 23:59:41 +01:00
netgroup.h
refactor: Use span instead of vector for data in util/asmap
2026-01-20 23:59:41 +01:00
netmessagemaker.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
noui.cpp
noui: Remove always empty caption while formatting
2026-01-14 19:39:01 +01:00
noui.h
refactor: Remove empty caption from ThreadSafeMessageBox
2026-01-14 19:36:14 +01:00
outputtype.cpp
refactor: increase string_view usage
2025-10-02 12:53:55 +01:00
outputtype.h
refactor: increase string_view usage
2025-10-02 12:53:55 +01:00
pow.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
pow.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
prevector.h
refactor: Prefer <=> over multiple relational operators
2025-11-03 14:39:50 +01:00
private_broadcast.cpp
net: Add PrivateBroadcast::GetBroadcastInfo
2026-02-11 19:46:12 -05:00
private_broadcast.h
net: Add PrivateBroadcast::GetBroadcastInfo
2026-02-11 19:46:12 -05:00
protocol.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
protocol.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
psbt.cpp
refactor: Use SpanReader over DataStream
2026-02-06 07:56:57 +01:00
psbt.h
refactor: Avoid copies by using const references or by move-construction
2026-01-14 23:03:47 +01:00
pubkey.cpp
pubkey: Return tweaks from BIP32 derivation
2025-09-30 11:06:09 -07:00
pubkey.h
refactor: Remove all operator!= definitions
2025-11-03 14:39:48 +01:00
random.cpp
logging: use util/log.h where possible
2026-02-02 17:22:31 +00:00
random.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
randomenv.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
randomenv.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
rest.cpp
Merge bitcoin/bitcoin#34524: refactor: [rpc] Remove confusing and brittle integral casts (take 2)
2026-02-09 13:32:28 +00:00
rest.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
scheduler.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
scheduler.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
semaphore_grant.h
threading: semaphore: move CountingSemaphoreGrant to its own header
2025-05-10 03:31:30 +00:00
serialize.h
refactor: Use empty() over eof() in the streams interface
2026-02-02 17:55:10 +01:00
signet.cpp
logging: use util/log.h where possible
2026-02-02 17:22:31 +00:00
signet.h
kernel: Remove some unnecessary non-kernel includes
2025-12-21 10:24:09 +01:00
span.h
…
streams.cpp
refactor: Add AutoFile::size
2025-11-14 01:17:38 +02:00
streams.h
Merge bitcoin/bitcoin#34465: refactor: separate log generation from log handling
2026-02-07 23:01:17 +01:00
sync.cpp
logging: use util/log.h where possible
2026-02-02 17:22:31 +00:00
sync.h
logging: use util/log.h where possible
2026-02-02 17:22:31 +00:00
threadsafety.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
tinyformat.h
…
torcontrol.cpp
refactor: Use std::bind_front over std::bind
2026-01-20 15:30:46 +01:00
torcontrol.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
txdb.cpp
validation: Use dirty entry count in flush warnings and disk space checks
2026-02-08 08:23:37 +01:00
txdb.h
Merge bitcoin/bitcoin#33866: refactor: Let CCoinsViewCache::BatchWrite return void
2026-01-02 16:49:23 -08:00
txgraph.cpp
clusterlin: use 'cost' terminology instead of 'iters' (refactor)
2026-02-24 10:08:47 -05:00
txgraph.h
clusterlin: use 'cost' terminology instead of 'iters' (refactor)
2026-02-24 10:08:47 -05:00
txmempool.cpp
clusterlin: use 'cost' terminology instead of 'iters' (refactor)
2026-02-24 10:08:47 -05:00
txmempool.h
clusterlin: rescale costs (preparation)
2026-02-24 10:45:49 -05:00
txrequest.cpp
Fix compilation for old Boost versions
2025-12-18 22:38:02 +01:00
txrequest.h
doc: fix double-word typos in comments
2025-12-30 12:12:26 -08:00
uint256.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
uint256.h
refactor: Remove all operator!= definitions
2025-11-03 14:39:48 +01:00
undo.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
validation.cpp
Merge bitcoin/bitcoin#33616: policy: don't CheckEphemeralSpends on reorg
2026-02-25 17:38:13 +01:00
validation.h
mining: add cooldown argument to createNewBlock()
2026-02-20 16:49:15 +01:00
validationinterface.cpp
logging: use util/log.h where possible
2026-02-02 17:22:31 +00:00
validationinterface.h
refactor: Convert ChainstateRole enum to struct
2025-12-12 06:49:59 -04:00
versionbits_impl.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
versionbits.cpp
Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers
2025-12-19 16:56:02 +00:00
versionbits.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
walletinitinterface.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00