Files
Ryan Ofsky f839ee1afb Merge bitcoin/bitcoin#35887: ipc: use std::optional for checkSpawned(), add tests and rename arg -ipcfd to -ipcchild
05e7d57318 ipc, test: add checkSpawned() unit tests (ViniciusCestarii)
8bca7555f8 ipc, refactor: rename arg -ipcfd to -ipcchild (ViniciusCestarii)
bd3a38f10a ipc, refactor: return std::optional<mp::SocketId> from checkSpawned() (ViniciusCestarii)

Pull request description:

  Implement proposed follow-ups on dicussion https://github.com/bitcoin/bitcoin/pull/35084#discussion_r3664894660:

  - Add unit test for checkSpawned().
  - Make checkSpawned() return std::optional<mp::SocketId>.
  - Rename -ipcfd to -ipcchild.

ACKs for top commit:
  jeanpablojp:
    ACK 05e7d57318
  enirox001:
    utACK https://github.com/bitcoin/bitcoin/pull/35887/changes/05e7d573184079720e11d933d24b9c9228477a14
  ryanofsky:
    Code review ACK 05e7d57318. Thanks for the followup!

Tree-SHA512: b91d94cbd7c5feb090fd8fac040d731cbc4dfb2b129f79fbb632deca92ae97a08e8b023b3a00f316702bc6e0d94668b1205baacabbc2b39a07b9e397fb4c76f2
2026-09-21 15:35:21 -04:00
..
…
…