averello/git-mirror
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2026-03-26 10:53:27 +01:00
Code Issues Packages Projects Releases Wiki Activity

t9123: use test_when_finished for cleanup

Browse Source 
Move the setup logic into a 'test_expect_success' block.
This ensures that the code is properly tracked by the test harness.

Additionally, we use the 'test_when_finished' helper at the start of
the block to ensure that the 'import' directory is removed even if the
test fails.
This is cleaner than the previous manual 'rm -rf import' approach.

Signed-off-by: Siddharth Shrimali <r.siddharth.shrimali@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Siddharth Shrimali
2026-03-05 18:24:08 +05:30
committed by Junio C Hamano
parent 67ad42147a
commit 63c00a677b
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
t/t9123-git-svn-rebuild-with-rewriteroot.sh
View File

@@ -7,12 +7,15 @@ test_description='git svn respects rewriteRoot during rebuild'
. ./lib-git-svn.sh
mkdir import
(cd import
touch foo
svn_cmd import -m 'import for git svn' . "$svnrepo" >/dev/null
)
rm -rf import
test_expect_success 'setup svn repository' '
test_when_finished "rm -rf import" &&
mkdir import &&
(
cd import &&
touch foo &&
svn_cmd import -m "import for git svn" . "$svnrepo" >/dev/null
)
'
test_expect_success 'init, fetch and checkout repository' '
git svn init --rewrite-root=http://invalid.invalid/ "$svnrepo" &&