averello/git-mirror
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2026-05-31 11:19:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

submodule-config: fix reading submodule.fetchJobs

Browse Source 
update_clone_config_from_gitmodules() passes &max_jobs to
config_from_gitmodules(), but max_jobs is already a pointer. This causes
the config value to be written to the wrong address and get dropped.

Pass max_jobs directly.

Signed-off-by: Saagar Jha <saagar@saagarjha.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Saagar Jha
2026-05-10 03:50:22 +00:00
committed by Junio C Hamano
parent 67ad42147a
commit aa45a5902f
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
submodule-config.c
+1 -1
View File
@@ -1037,5 +1037,5 @@ static int gitmodules_update_clone_config(const char *var, const char *value,
void update_clone_config_from_gitmodules(int *max_jobs)
{
config_from_gitmodules(gitmodules_update_clone_config, the_repository, &max_jobs);
config_from_gitmodules(gitmodules_update_clone_config, the_repository, max_jobs);
}
t/t7406-submodule-update.sh
+8
View File
@@ -1055,6 +1055,14 @@ test_expect_success 'submodule update can be run in parallel' '
)
'
test_expect_success 'submodule update honors fetch jobs config from .gitmodules' '
test_when_finished "rm -rf super3" &&
git clone cloned super3 &&
git -C super3 config -f .gitmodules submodule.fetchJobs 67 &&
GIT_TRACE="$(pwd)/trace.out" git -C super3 submodule update --init &&
test_grep "67 tasks" trace.out
'
test_expect_success 'git clone passes the parallel jobs config on to submodules' '
test_when_finished "rm -rf super4" &&
GIT_TRACE=$(pwd)/trace.out git clone --recurse-submodules --jobs 7 . super4 &&