mirror of
https://github.com/git/git.git
synced 2026-10-02 19:57:11 +02:00
Michael Montalbo
47f79f6198
Replace bare grep with test_grep in test assertions across the
suite, including sourced test helpers (lib-*.sh, *-tests.sh).
test_grep prints the contents of the file being searched on
failure, making debugging easier than a bare grep which fails
silently.
Only assertion-style greps are converted: grep used as a filter
in pipelines, command substitutions, conditionals, or with
redirected I/O is left as-is with a "# lint-ok" annotation.
Existing '! test_grep' calls are rewritten to 'test_grep !' so
that the diagnostic output is preserved on failure.
test_grep requires the file it reads to exist, so '! grep'
assertions that inspect a file whose presence is conditional need
care. In t5537 the '.git/shallow' file is still present after the
repack (the client remains shallow), so the assertion is
converted like any other. In t1400 the '.git/packed-refs' file
exists only with the files backend, so its check is guarded with a
REFFILES prerequisite; the backend-agnostic 'git show-ref' check
that follows still runs under every backend. In t7450 'git~2' is
the NTFS 8.3 short name of a '..git' file and only exists
when 8.3 short-name generation is enabled, so its check is guarded
with a 'test -f' on the path and uses test_grep inside the guard,
the same shape as t1400 (a plain test_grep would BUG when the
short name is absent).
The conversion was generated using a grep-assertion linter
(greplint.pl, added in the following commit) to identify bare
grep calls at command position. To reproduce, from the t/
directory:
# Step 1: annotate the two data-filter greps (grep produces
# data, not a verdict) so the linter skips them.
sed -i '/grep -vf before commits\.raw/s/$/ # lint-ok: data filter/' \
t5326-multi-pack-bitmaps.sh
sed -i '/grep -E "^\[0-9a-f\].*|| :/s/$/ # lint-ok: data filter/' \
t5702-protocol-v2.sh
# Step 1b: two '! grep' assertions need more than a mechanical
# conversion; handle them by hand before the linter-driven steps
# below so it leaves them alone.
#
# t1400: '.git/packed-refs' is absent under reftable, so guard the
# check with REFFILES (a plain test_grep would BUG on the missing
# file):
#
# git update-ref -d HEAD $B &&
# - ! grep "$m" .git/packed-refs &&
# + if test_have_prereq REFFILES
# + then
# + test_grep ! "$m" .git/packed-refs
# + fi &&
# test_must_fail git show-ref --verify -q $m
#
# t7450: git~2 is an NTFS 8.3 short name that exists only when
# short-name generation is enabled, so guard the check on its
# presence with 'test -f' and note in a comment why the path can
# be absent (a plain test_grep would BUG when it is):
#
# - ! grep gitdir squatting-clone/d/a/git~2
# + if test -f squatting-clone/d/a/git~2
# + then
# + test_grep ! gitdir squatting-clone/d/a/git~2
# + fi
# Step 2: reorder pre-existing '! test_grep' to 'test_grep !'
# (must come before steps 3-4 so greplint does not see them)
sed -i 's/! test_grep/test_grep !/' t0031-lockfile-pid.sh
sed -i 's/! test_grep/test_grep !/' t5300-pack-object.sh
sed -i 's/! test_grep/test_grep !/' t5319-multi-pack-index.sh
# Step 3: convert '! grep' -> 'test_grep !'
perl greplint.pl *.sh 2>&1 | cut -d: -f1,2 |
while IFS=: read f l; do
sed -i "${l}s/! *grep/test_grep !/" "$f"
done
# Step 4: convert remaining 'grep' -> 'test_grep'
perl greplint.pl *.sh 2>&1 | cut -d: -f1,2 |
while IFS=: read f l; do
sed -i "${l}s/grep/test_grep/" "$f"
done
To verify, run: make -C t test-greplint
Signed-off-by: Michael Montalbo <mmontalbo@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
62 lines
1.7 KiB
Bash
Executable File
62 lines
1.7 KiB
Bash
Executable File
#!/bin/sh
|
|
|
|
test_description='git-diff check diffstat filepaths length when containing UTF-8 chars'
|
|
|
|
. ./test-lib.sh
|
|
|
|
|
|
create_files () {
|
|
mkdir -p "d你好" &&
|
|
touch "d你好/f再见"
|
|
}
|
|
|
|
test_expect_success 'setup' '
|
|
git init &&
|
|
git config core.quotepath off &&
|
|
git commit -m "Initial commit" --allow-empty &&
|
|
create_files &&
|
|
git add . &&
|
|
git commit -m "Added files"
|
|
'
|
|
|
|
test_expect_success 'test name-width long enough for filepath' '
|
|
git diff HEAD~1 HEAD --stat --stat-name-width=12 >out &&
|
|
test_grep "d你好/f再见 |" out &&
|
|
git diff HEAD~1 HEAD --stat --stat-name-width=11 >out &&
|
|
test_grep "d你好/f再见 |" out
|
|
'
|
|
|
|
test_expect_success 'test name-width not long enough for dir name' '
|
|
git diff HEAD~1 HEAD --stat --stat-name-width=10 >out &&
|
|
test_grep ".../f再见 |" out &&
|
|
git diff HEAD~1 HEAD --stat --stat-name-width=9 >out &&
|
|
test_grep ".../f再见 |" out
|
|
'
|
|
|
|
test_expect_success 'test name-width not long enough for slash' '
|
|
git diff HEAD~1 HEAD --stat --stat-name-width=8 >out &&
|
|
test_grep "...f再见 |" out
|
|
'
|
|
|
|
test_expect_success 'test name-width not long enough for file name' '
|
|
git diff HEAD~1 HEAD --stat --stat-name-width=7 >out &&
|
|
test_grep "...再见 |" out &&
|
|
git diff HEAD~1 HEAD --stat --stat-name-width=6 >out &&
|
|
test_grep "...见 |" out &&
|
|
git diff HEAD~1 HEAD --stat --stat-name-width=5 >out &&
|
|
test_grep "...见 |" out &&
|
|
git diff HEAD~1 HEAD --stat --stat-name-width=4 >out &&
|
|
test_grep "... |" out
|
|
'
|
|
|
|
test_expect_success 'test name-width minimum length' '
|
|
git diff HEAD~1 HEAD --stat --stat-name-width=3 >out &&
|
|
test_grep "... |" out &&
|
|
git diff HEAD~1 HEAD --stat --stat-name-width=2 >out &&
|
|
test_grep "... |" out &&
|
|
git diff HEAD~1 HEAD --stat --stat-name-width=1 >out &&
|
|
test_grep "... |" out
|
|
'
|
|
|
|
test_done
|