Johannes Schindelin 116d1fa6c6 vreportf(): avoid relying on stdio buffering
The MSVC runtime behavior differs from glibc's with respect to
`fprintf(stderr, ...)` in that the former writes out the message
character by character.

In t5516, this leads to a funny problem where a `git fetch` process as
well as the `git upload-pack` process spawned by it _both_ call `die()`
at the same time. The output can look like this:

	fatal: git uploadfata-lp: raemcokte :error:  upload-pnot our arcef k6: n4ot our ea4cr1e3f 36d45ea94fca1398e86a771eda009872d63adb28598f6a9
	8e86a771eda009872d6ab2886

Let's avoid this predicament altogether by rendering the entire message,
including the prefix and the trailing newline, into the buffer we
already have (and which is still fixed size) and then write it out via
`write_in_full()`.

We still clip the message to at most 4095 characters.

The history of `vreportf()` with regard to this issue includes the
following commits:

d048a96e (2007-11-09) - 'char msg[256]' is introduced to avoid interleaving
389d1767 (2009-03-25) - Buffer size increased to 1024 to avoid truncation
625a860c (2009-11-22) - Buffer size increased to 4096 to avoid truncation
f4c3edc0 (2015-08-11) - Buffer removed to avoid truncation
b5a9e435 (2017-01-11) - Reverts f4c3edc0 to be able to replace control
                        chars before sending to stderr
9ac13ec9 (2006-10-11) - Another attempt to solve interleaving.
                        This is seemingly related to d048a96e.
137a0d0e (2007-11-19) - Addresses out-of-order for display()
34df8aba (2009-03-10) - Switches xwrite() to fprintf() in recv_sideband()
                        to support UTF-8 emulation
eac14f89 (2012-01-14) - Removes the need for fprintf() for UTF-8 emulation,
                        so it's safe to use xwrite() again
5e5be9e2 (2016-06-28) - recv_sideband() uses xwrite() again

Note that we print nothing if the `vsnprintf()` call failed to render
the error message; There is little we can do in that case, and it should
not happen anyway.

The process may have written to `stderr` and there may be something left
in the buffer kept in the stdio layer. Call `fflush(stderr)` before
writing the message we prepare in this function.

Helped-by: Jeff King <peff@peff.net>
Helped-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
Helped-by: SZEDER Gábor <szeder.dev@gmail.com>
Helped-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2019-11-02 15:20:21 +09:00
2019-07-29 12:39:13 -07:00
2019-08-02 13:12:02 -07:00
2019-08-02 13:12:02 -07:00
2019-08-11 17:41:39 -07:00
2019-04-01 11:57:39 +09:00
2019-04-01 11:57:39 +09:00
2019-05-14 16:45:01 +09:00
2019-05-30 10:50:45 -07:00
2019-08-02 13:12:02 -07:00
2019-01-02 10:19:05 -08:00
2019-07-19 11:30:21 -07:00
2019-07-19 11:30:20 -07:00
2019-07-09 15:25:44 -07:00
2019-07-09 15:25:44 -07:00
2019-07-25 13:59:20 -07:00
2019-07-09 15:25:43 -07:00
2019-05-05 15:20:10 +09:00
2019-07-09 15:25:43 -07:00
2019-05-13 23:50:32 +09:00
2019-07-19 11:30:20 -07:00
2019-07-25 13:59:20 -07:00
2019-08-16 10:28:23 -07:00
2019-08-02 13:12:02 -07:00
2019-06-13 13:19:42 -07:00
2019-05-05 15:20:10 +09:00
2019-04-22 11:14:43 +09:00
2019-08-02 13:12:02 -07:00
2019-01-14 12:13:04 -08:00
2019-06-11 10:34:40 -07:00
2019-07-09 15:25:43 -07:00
2019-07-19 11:30:19 -07:00
2019-07-19 11:30:20 -07:00
2019-07-19 11:30:20 -07:00
2019-05-05 15:20:10 +09:00
2019-05-05 15:20:10 +09:00
2019-02-06 22:05:23 -08:00
2019-06-17 18:15:04 -07:00
2019-02-05 14:26:09 -08:00
2019-07-11 15:16:49 -07:00
2019-05-05 15:20:10 +09:00
2019-04-01 11:57:39 +09:00
2019-01-14 12:13:04 -08:00
2019-05-05 15:20:10 +09:00
2019-02-05 14:26:11 -08:00
2019-05-05 15:20:10 +09:00
2019-05-13 23:50:35 +09:00
2019-05-05 15:20:10 +09:00
2019-06-21 11:24:08 -07:00

Build Status

Git - fast, scalable, distributed revision control system

Git is a fast, scalable, distributed revision control system with an unusually rich command set that provides both high-level operations and full access to internals.

Git is an Open Source project covered by the GNU General Public License version 2 (some parts of it are under different licenses, compatible with the GPLv2). It was originally written by Linus Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

Many Git online resources are accessible from https://git-scm.com/ including full documentation and Git related tools.

See Documentation/gittutorial.txt to get started, then see Documentation/giteveryday.txt for a useful minimum set of commands, and Documentation/git-<commandname>.txt for documentation of each command. If git has been correctly installed, then the tutorial can also be read with man gittutorial or git help tutorial, and the documentation of each command with man git-<commandname> or git help <commandname>.

CVS users may also want to read Documentation/gitcvs-migration.txt (man gitcvs-migration or git help cvs-migration if git is installed).

The user discussion and development of Git take place on the Git mailing list -- everyone is welcome to post bug reports, feature requests, comments and patches to git@vger.kernel.org (read Documentation/SubmittingPatches for instructions on patch submission). To subscribe to the list, send an email with just "subscribe git" in the body to majordomo@vger.kernel.org. The mailing list archives are available at https://public-inbox.org/git/, http://marc.info/?l=git and other archival sites.

Issues which are security relevant should be disclosed privately to the Git Security mailing list git-security@googlegroups.com.

The maintainer frequently sends the "What's cooking" reports that list the current status of various development topics to the mailing list. The discussion following them give a good reference for project status, development direction and remaining tasks.

The name "git" was given by Linus Torvalds when he wrote the very first version. He described the tool as "the stupid content tracker" and the name as (depending on your mood):

  • random three-letter combination that is pronounceable, and not actually used by any common UNIX command. The fact that it is a mispronunciation of "get" may or may not be relevant.
  • stupid. contemptible and despicable. simple. Take your pick from the dictionary of slang.
  • "global information tracker": you're in a good mood, and it actually works for you. Angels sing, and a light suddenly fills the room.
  • "goddamn idiotic truckload of sh*t": when it breaks
Description
Git Source Code Mirror - This is a publish-only repository but pull requests can be turned into patches to the mailing list via GitGitGadget (https://gitgitgadget.github.io/). Please follow Documentation/SubmittingPatches procedure for any of your improvements.
Readme 734 MiB
Languages
C 50.5%
Shell 38.7%
Perl 4.5%
Tcl 3.2%
Python 0.8%
Other 2.1%