Ævar Arnfjörð Bjarmason 2139bd0200 http-backend.c: fix cmd_main() memory leak, refactor reg{exec,free}() ...

Fix a memory leak that's been with us ever since
2f4038ab33 (Git-aware CGI to provide dumb HTTP transport,
2009-10-30). In this case we're not calling regerror() after a failed
regexec(), and don't otherwise use "re" afterwards.

We can therefore simplify this code by calling regfree() right after
the regexec(). An alternative fix would be to add a regfree() to both
the "return" and "break" path in this for-loop.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

2023-02-06 15:34:38 -08:00

19 KiB

Raw Blame History

View Raw