Emily Shaffer de99eb0c24 grep: fail if call could output and name is null
grep_source(), which performs much of the work for Git's grep library,
allows passing an arbitrary struct grep_source which represents the text
which grep_source() should search to match a pattern in the provided
struct grep_opt. In most callers, the grep_source::name field is set to
an appropriate prefix to print before a colon when a result matches:

	README:Git is an Open Source project covered by the GNU General

One caller, grep_buffer(), leaves the grep_source::name field set to
NULL because there isn't enough context to determine an appropriate name
for this kind of output line. In practice, this has been fine: the only
caller of grep_buffer() is "git log --grep", and that caller sets
grep_opt::status_only, which disables output and only checks whether a
match exists. But this is brittle: a future caller can call
grep_buffer() without grep_opt::status_only set, and as soon as it hits
a match, grep_source() will try to print the match and segfault:

	(null):Git is an Open Source project covered by the GNU General

For example, a future caller might want to print all matching lines from
commits which match a regex.

Futureproof by diagnosing early a use of the API that could trigger that
condition, before we know whether the pattern matches:

	BUG: grep.c:1783: grep call which could print a name requires
		grep_source.name be non-NULL
	Aborted

This way, the caller's author gets an indication of how to fix the issue
- by providing grep_source::name or setting grep_opt::status_only - and
they are warned of the potential for a segfault unconditionally, rather
than only if there is a match.

Noticed while adding such a call to a tutorial on revision walks.

Signed-off-by: Emily Shaffer <emilyshaffer@google.com>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2019-05-28 10:57:07 -07:00
2019-03-02 19:12:58 +01:00
2019-02-22 21:20:19 -08:00
2018-08-20 12:41:32 -07:00
2018-12-09 12:37:32 +09:00
2019-01-14 15:29:32 -08:00
2019-02-06 22:05:23 -08:00
2018-09-12 15:15:34 -07:00
2019-01-02 10:19:05 -08:00
2019-01-14 12:13:04 -08:00
2018-11-02 11:04:53 +09:00
2019-02-05 14:26:09 -08:00
2019-02-05 14:26:09 -08:00
2018-11-19 16:24:41 +09:00
2018-08-20 12:41:32 -07:00
2019-02-06 22:05:24 -08:00
2019-02-05 14:26:17 -08:00
2018-10-19 13:34:02 +09:00
2018-10-19 13:34:02 +09:00
2019-02-06 22:05:23 -08:00
2019-01-14 15:29:29 -08:00
2019-02-24 07:55:19 -08:00
2019-02-06 22:05:23 -08:00
2018-11-05 13:42:11 +09:00
2018-12-12 17:18:29 +09:00
2018-08-29 13:05:35 -07:00
2019-01-14 12:13:04 -08:00
2019-01-04 13:33:32 -08:00
2018-11-13 22:37:19 +09:00
2019-02-07 13:02:28 -08:00
2018-10-04 11:12:14 -07:00
2018-10-04 11:12:14 -07:00
2019-02-05 14:26:09 -08:00
2019-02-05 14:26:09 -08:00
2019-01-04 13:33:31 -08:00
2018-10-19 13:34:02 +09:00
2019-01-04 13:33:32 -08:00
2019-02-06 22:05:23 -08:00
2019-02-05 14:26:09 -08:00
2019-02-05 14:26:09 -08:00
2018-11-02 12:14:21 +09:00
2018-11-02 12:14:21 +09:00
2018-12-09 12:37:32 +09:00
2018-08-15 15:08:23 -07:00
2018-09-17 13:53:52 -07:00
2019-02-06 22:05:23 -08:00
2019-02-06 22:05:23 -08:00
2019-01-14 12:13:04 -08:00
2018-08-20 15:31:40 -07:00
2019-02-05 14:26:11 -08:00
2018-11-02 11:04:54 +09:00
2018-11-02 11:04:54 +09:00
2019-02-06 22:05:23 -08:00
2018-12-09 12:37:32 +09:00
2019-01-29 12:47:56 -08:00
2019-02-06 22:05:23 -08:00
2018-08-15 11:52:09 -07:00
2018-10-19 13:34:02 +09:00

Build Status

Git - fast, scalable, distributed revision control system

Git is a fast, scalable, distributed revision control system with an unusually rich command set that provides both high-level operations and full access to internals.

Git is an Open Source project covered by the GNU General Public License version 2 (some parts of it are under different licenses, compatible with the GPLv2). It was originally written by Linus Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

Many Git online resources are accessible from https://git-scm.com/ including full documentation and Git related tools.

See Documentation/gittutorial.txt to get started, then see Documentation/giteveryday.txt for a useful minimum set of commands, and Documentation/git-.txt for documentation of each command. If git has been correctly installed, then the tutorial can also be read with man gittutorial or git help tutorial, and the documentation of each command with man git-<commandname> or git help <commandname>.

CVS users may also want to read Documentation/gitcvs-migration.txt (man gitcvs-migration or git help cvs-migration if git is installed).

The user discussion and development of Git take place on the Git mailing list -- everyone is welcome to post bug reports, feature requests, comments and patches to git@vger.kernel.org (read Documentation/SubmittingPatches for instructions on patch submission). To subscribe to the list, send an email with just "subscribe git" in the body to majordomo@vger.kernel.org. The mailing list archives are available at https://public-inbox.org/git/, http://marc.info/?l=git and other archival sites.

Issues which are security relevant should be disclosed privately to the Git Security mailing list git-security@googlegroups.com.

The maintainer frequently sends the "What's cooking" reports that list the current status of various development topics to the mailing list. The discussion following them give a good reference for project status, development direction and remaining tasks.

The name "git" was given by Linus Torvalds when he wrote the very first version. He described the tool as "the stupid content tracker" and the name as (depending on your mood):

  • random three-letter combination that is pronounceable, and not actually used by any common UNIX command. The fact that it is a mispronunciation of "get" may or may not be relevant.
  • stupid. contemptible and despicable. simple. Take your pick from the dictionary of slang.
  • "global information tracker": you're in a good mood, and it actually works for you. Angels sing, and a light suddenly fills the room.
  • "goddamn idiotic truckload of sh*t": when it breaks
Description
Git Source Code Mirror - This is a publish-only repository but pull requests can be turned into patches to the mailing list via GitGitGadget (https://gitgitgadget.github.io/). Please follow Documentation/SubmittingPatches procedure for any of your improvements.
Readme 734 MiB
Languages
C 50.5%
Shell 38.7%
Perl 4.5%
Tcl 3.2%
Python 0.8%
Other 2.1%