averello/isync-mirror
1
0
Fork 0
mirror of https://git.code.sf.net/p/isync/isync synced 2026-03-02 18:23:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix conditional on undefined value on some config syntax errors

Browse Source 
if the first token on a line was an unterminated escape/quote, we'd
branch based on an uninitialized 'comment' variable.

amends 725a122e.
This commit is contained in:
Oswald Buddenhagen
2025-03-19 15:30:59 +01:00
parent ffc0884efe
commit fbcdaf78bd
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/config.c
View File

@@ -73,8 +73,8 @@ get_arg( conffile_t *cfile, int required, int *comment )
while ((c = *p) && isspace( (uchar)c ))
p++;
if (!c || c == '#') {
if (comment)
*comment = (c == '#');
if (comment && c)
*comment = 1;
if (required) {
error( "%s:%d: parameter missing\n", cfile->file, cfile->line );
cfile->err = 1;
@@ -313,7 +313,6 @@ int
getcline( conffile_t *cfile )
{
char *arg;
int comment;
if (cfile->rest && (arg = get_arg( cfile, ARG_OPTIONAL, NULL ))) {
error( "%s:%d: excess token '%s'\n", cfile->file, cfile->line, arg );
@@ -322,6 +321,7 @@ getcline( conffile_t *cfile )
while (fgets( cfile->buf, cfile->bufl, cfile->fp )) {
cfile->line++;
cfile->rest = cfile->buf;
int comment = 0;
if (!(cfile->cmd = get_arg( cfile, ARG_OPTIONAL, &comment ))) {
if (comment)
continue;