Remove bigscreen plugin

The claim that the signal emitted by this plugin is consumed by Bigscreen is not true. As an alternative, we can repurpose the voice input in Android to send plain text instead without requiring this plugin.
2025-12-12 20:35:55 +01:00 · 2025-10-09 18:19:31 +02:00
parent 19c7a22941
commit 67199146b9
9 changed files with 0 additions and 247 deletions
--- a/declarativeplugin/kdeconnectdeclarativeplugin.cpp
+++ b/declarativeplugin/kdeconnectdeclarativeplugin.cpp
@@ -95,7 +95,6 @@ void KdeConnectDeclarativePlugin::registerTypes(const char *uri)
                                                                "RemoteSystemVolumeInterface",
                                                                QStringLiteral("You're not supposed to instantiate interfaces"));
    qmlRegisterUncreatableType<ShareDbusInterface>(uri, 1, 0, "ShareDbusInterface", QStringLiteral("You're not supposed to instantiate interfaces"));
-    qmlRegisterUncreatableType<BigscreenDbusInterface>(uri, 1, 0, "BigscreenDbusInterface", QStringLiteral("You're not supposed to instantiate interfaces"));
    qmlRegisterSingletonType<DaemonDbusInterface>(uri, 1, 0, "DaemonDbusInterface", [](QQmlEngine *, QJSEngine *) -> QObject * {
        return new DaemonDbusInterface;
    });
@@ -130,7 +129,6 @@ void KdeConnectDeclarativePlugin::registerTypes(const char *uri)
    registerFactory<RemoteCommandsDbusInterface>(uri, "RemoteCommandsDbusInterfaceFactory");
    registerFactory<ShareDbusInterface>(uri, "ShareDbusInterfaceFactory");
    registerFactory<RemoteSystemVolumeDbusInterface>(uri, "RemoteSystemVolumeDbusInterfaceFactory");
-    registerFactory<BigscreenDbusInterface>(uri, "BigscreenDbusInterfaceFactory");
    registerFactory<VirtualmonitorDbusInterface>(uri, "VirtualmonitorDbusInterfaceFactory");
 }

--- a/interfaces/CMakeLists.txt
+++ b/interfaces/CMakeLists.txt
@@ -59,7 +59,6 @@ geninterface(${PROJECT_SOURCE_DIR}/plugins/sms/smsplugin.h generated/smsinterfac
 geninterface(${PROJECT_SOURCE_DIR}/plugins/sms/conversationsdbusinterface.h generated/conversationsinterface)
 geninterface(${PROJECT_SOURCE_DIR}/plugins/share/shareplugin.h generated/shareinterface)
 geninterface(${PROJECT_SOURCE_DIR}/plugins/remotesystemvolume/remotesystemvolumeplugin.h generated/remotesystemvolumeinterface)
-geninterface(${PROJECT_SOURCE_DIR}/plugins/bigscreen/bigscreenplugin.h generated/bigscreeninterface)
 geninterface(${PROJECT_SOURCE_DIR}/plugins/virtualmonitor/virtualmonitorplugin.h generated/virtualmonitorinterface)
 geninterface(${PROJECT_SOURCE_DIR}/plugins/clipboard/clipboardplugin.h generated/deviceclipboardinterface)

--- a/interfaces/dbusinterfaces.cpp
+++ b/interfaces/dbusinterfaces.cpp
@@ -177,14 +177,6 @@ RemoteSystemVolumeDbusInterface::RemoteSystemVolumeDbusInterface(const QString &
 {
 }

-BigscreenDbusInterface::BigscreenDbusInterface(const QString &deviceId, QObject *parent)
-    : OrgKdeKdeconnectDeviceBigscreenInterface(DaemonDbusInterface::activatedService(),
-                                               QLatin1String("/modules/kdeconnect/devices/%1/bigscreen").arg(deviceId),
-                                               QDBusConnection::sessionBus(),
-                                               parent)
-{
-}
-
 VirtualmonitorDbusInterface::VirtualmonitorDbusInterface(const QString &deviceId, QObject *parent)
    : OrgKdeKdeconnectDeviceVirtualmonitorInterface(DaemonDbusInterface::activatedService(),
                                                    QLatin1String("/modules/kdeconnect/devices/%1/virtualmonitor").arg(deviceId),
--- a/interfaces/dbusinterfaces.h
+++ b/interfaces/dbusinterfaces.h
@@ -10,7 +10,6 @@
 #include "kdeconnectinterfaces_export.h"

 #include "generated/batteryinterface.h"
-#include "generated/bigscreeninterface.h"
 #include "generated/connectivityinterface.h"
 #include "generated/conversationsinterface.h"
 #include "generated/daemoninterface.h"
@@ -223,13 +222,6 @@ public:
    explicit RemoteSystemVolumeDbusInterface(const QString &deviceId, QObject *parent = nullptr);
 };

-class KDECONNECTINTERFACES_EXPORT BigscreenDbusInterface : public OrgKdeKdeconnectDeviceBigscreenInterface
-{
-    Q_OBJECT
-public:
-    explicit BigscreenDbusInterface(const QString &deviceId, QObject *parent = nullptr);
-};
-
 class KDECONNECTINTERFACES_EXPORT VirtualmonitorDbusInterface : public OrgKdeKdeconnectDeviceVirtualmonitorInterface
 {
    Q_OBJECT
--- a/plugins/CMakeLists.txt
+++ b/plugins/CMakeLists.txt
@@ -14,10 +14,6 @@ if(NOT WIN32)
    add_subdirectory(battery)
 endif()

-if(NOT WIN32 AND NOT APPLE)
-    add_subdirectory(bigscreen)
-endif()
-
 add_subdirectory(presenter)

 if((WIN32 AND MSVC AND ("${CMAKE_SYSTEM_VERSION}" VERSION_GREATER_EQUAL 10.0.17763.0)) OR (NOT WIN32 AND NOT APPLE))
--- a/plugins/bigscreen/CMakeLists.txt
+++ b/plugins/bigscreen/CMakeLists.txt
@@ -1,6 +0,0 @@
-kdeconnect_add_plugin(kdeconnect_bigscreen SOURCES bigscreenplugin.cpp)
-target_link_libraries(kdeconnect_bigscreen
-    kdeconnectcore
-    kdeconnectinterfaces
-    Qt::DBus
-    KF6::I18n)
--- a/plugins/bigscreen/bigscreenplugin.cpp
+++ b/plugins/bigscreen/bigscreenplugin.cpp
@@ -1,36 +0,0 @@
-/**
- * SPDX-FileCopyrightText: 2020 Aditya Mehra <aix.m@outlook.com>
- *
- * SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL
- */
-
-#include "bigscreenplugin.h"
-
-#include <KLocalizedString>
-#include <KPluginFactory>
-
-#include <QDBusConnection>
-#include <QDebug>
-#include <QLoggingCategory>
-
-#include <core/daemon.h>
-#include <core/device.h>
-
-K_PLUGIN_CLASS_WITH_JSON(BigscreenPlugin, "kdeconnect_bigscreen.json")
-
-void BigscreenPlugin::receivePacket(const NetworkPacket &np)
-{
-    QString message = np.get<QString>(QStringLiteral("content"));
-    /* Emit a signal that will be consumed by Plasma BigScreen:
-     * https://invent.kde.org/plasma/plasma-bigscreen/-/blob/master/containments/homescreen/package/contents/ui/indicators/KdeConnect.qml
-     */
-    Q_EMIT messageReceived(message);
-}
-
-QString BigscreenPlugin::dbusPath() const
-{
-    return QLatin1String("/modules/kdeconnect/devices/%1/bigscreen").arg(device()->id());
-}
-
-#include "bigscreenplugin.moc"
-#include "moc_bigscreenplugin.cpp"
--- a/plugins/bigscreen/bigscreenplugin.h
+++ b/plugins/bigscreen/bigscreenplugin.h
@@ -1,26 +0,0 @@
-/**
- * SPDX-FileCopyrightText: 2013 Albert Vaca <albertvaka@gmail.com>
- * SPDX-FileCopyrightText: 2020 Aditya Mehra <aix.m@outlook.com>
- *
- * SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL
- */
-
-#pragma once
-
-#include <core/kdeconnectplugin.h>
-
-#define PACKET_TYPE_BIGSCREEN_STT QStringLiteral("kdeconnect.bigscreen.stt")
-
-class BigscreenPlugin : public KdeConnectPlugin
-{
-    Q_OBJECT
-    Q_CLASSINFO("D-Bus Interface", "org.kde.kdeconnect.device.bigscreen")
-
-public:
-    using KdeConnectPlugin::KdeConnectPlugin;
-    void receivePacket(const NetworkPacket &np) override;
-    QString dbusPath() const override;
-
-Q_SIGNALS:
-    Q_SCRIPTABLE void messageReceived(const QString &message);
-};
--- a/plugins/bigscreen/kdeconnect_bigscreen.json
+++ b/plugins/bigscreen/kdeconnect_bigscreen.json
@@ -1,156 +0,0 @@
-{
-    "$schema": "../kdeconnect.schema.json",
-    "KPlugin": {
-        "Authors": [
-            {
-                "Email": "aix.m@outlook.com",
-                "Name": "Aditya Mehra",
-                "Name[ar]": "أديتيا ميهرا",
-                "Name[az]": "Aditya Mehra",
-                "Name[bg]": "Aditya Mehra",
-                "Name[ca@valencia]": "Aditya Mehra",
-                "Name[ca]": "Aditya Mehra",
-                "Name[cs]": "Aditya Mehra",
-                "Name[da]": "Aditya Mehra",
-                "Name[de]": "Aditya Mehra",
-                "Name[el]": "Aditya Mehra",
-                "Name[en_GB]": "Aditya Mehra",
-                "Name[eo]": "Aditya Mehra",
-                "Name[es]": "Aditya Mehra",
-                "Name[et]": "Aditya Mehra",
-                "Name[eu]": "Aditya Mehra",
-                "Name[fi]": "Aditya Mehra",
-                "Name[fr]": "Aditya Mehra",
-                "Name[gl]": "Aditya Mehra",
-                "Name[he]": "אדיטיה מהרה",
-                "Name[hi]": "आदित्य मेहरा",
-                "Name[hu]": "Aditya Mehra",
-                "Name[ia]": "Aditya Mehra",
-                "Name[id]": "Aditya Mehra",
-                "Name[ie]": "Aditya Mehra",
-                "Name[is]": "Aditya Mehra",
-                "Name[it]": "Aditya Mehra",
-                "Name[ja]": "Aditya Mehra",
-                "Name[ka]": "Aditya Mehra",
-                "Name[ko]": "Aditya Mehra",
-                "Name[lt]": "Aditya Mehra",
-                "Name[lv]": "Aditya Mehra",
-                "Name[nl]": "Aditya Mehra",
-                "Name[nn]": "Aditya Mehra",
-                "Name[pa]": "ਅਦਿੱਤਿਆ ਮਹਿਰਾ",
-                "Name[pl]": "Aditya Mehra",
-                "Name[pt]": "Aditya Mehra",
-                "Name[pt_BR]": "Aditya Mehra",
-                "Name[ro]": "Aditya Mehra",
-                "Name[ru]": "Aditya Mehra",
-                "Name[sa]": "आदित्य मेहरा",
-                "Name[sk]": "Aditya Mehra",
-                "Name[sl]": "Aditya Mehra",
-                "Name[sv]": "Aditya Mehra",
-                "Name[tr]": "Aditya Mehra",
-                "Name[uk]": "Aditya Mehra",
-                "Name[zh_CN]": "Aditya Mehra",
-                "Name[zh_TW]": "Aditya Mehra"
-            }
-        ],
-        "Description": "Send voice commands to your TV running Plasma Bigscreen",
-        "Description[ar]": "أرسل أوامر صوتية إلى تلفازك الذي يشغل بلازما الشاشة الكبيرة",
-        "Description[az]": "Plasma Böyük ekranın işlək olduğu televizora səs əmri göndər",
-        "Description[bg]": "Изпращане на гласови команди към телевизора с Bigscreen на Plasma",
-        "Description[ca@valencia]": "Envieu ordres de veu al televisor executant Plasma Bigscreen",
-        "Description[ca]": "Envieu ordres de veu al televisor executant el Plasma Bigscreen",
-        "Description[cs]": "Posílejte hlasové příkazy TV, na které běží Plasma Bigscreen",
-        "Description[da]": "Sen stemmekommandoer til dit TV, der kører Plasma Storskærm",
-        "Description[de]": "Sprachbefehle zum Fernseher senden, auf dem Plasma Bigscreen installiert ist",
-        "Description[en_GB]": "Send voice commands to your TV running Plasma Bigscreen",
-        "Description[eo]": "Sendi voĉkomandojn al via televidilo kun Plasma Bigscreen",
-        "Description[es]": "Envie órdenes de voz a su televisor ejecutando Plasma Bigscreen",
-        "Description[eu]": "Plasma Bigscreen darabilen zure TBara ahots-aginduak bidali",
-        "Description[fi]": "Lähetä Plasma Bigscreen -TV:lle äänikomentoja",
-        "Description[fr]": "Envoyer des commandes vocales vers votre télévision fonctionnant avec Plasma Bigscreen.",
-        "Description[gl]": "Enviar ordes de voz a un televisor que use Plasma Bigscreen.",
-        "Description[he]": "שליחת פקודות קוליות לטלוויזיה שלך שמפעילה Bigscreen פלזמה",
-        "Description[hi]": "प्लाज़्मा बिगस्क्रीन चलाने वाले अपने टीवी पर ध्वनि आदेश भेजें",
-        "Description[hu]": "Küldjön hangparancsokat Plasma Bigscreent futtató televíziójának",
-        "Description[ia]": "Invia commandos de voce a tu TV executante  Bigscreen de Plasma",
-        "Description[is]": "Senda raddskipanir í sjónvarpið þitt sem keyrir Plasma Bigscreen",
-        "Description[it]": "Invia comandi vocali alla tua TV con Plasma Bigscreen",
-        "Description[ja]": "Plasma Bigscreen を実行している TV に音声コマンドを送信",
-        "Description[ka]": "გაუგზავნეთ თქვენს TV-ზე გაშვებულ Plasma Bigscreen-ს ხმოვანი ბრძანებები",
-        "Description[ko]": "Plasma 큰 화면을 실행 중인 TV에 음성 명령 보내기",
-        "Description[lt]": "Siųsti balso komandas į televizorių, kuriame veikia Plasma Bigscreen",
-        "Description[lv]": "Nosūtīt balss komandas uz TV, izmantojot „Plasma Bigscreen“",
-        "Description[nl]": "Stemcommando s naar uw TV zenden bij actief Plasma Bigscreen",
-        "Description[nn]": "Send stemmekommandoar til fjernsyn som køyrer Plasma Bigscreen",
-        "Description[pa]": "ਪਲਾਜ਼ਮਾ ਬਿੱਗ-ਸਕਰੀਨ ਨਾਲ ਚੱਲ ਰਹੇ ਆਪਣੇ ਟੀਵੀ ਨੂੰ ਆਵਾਜ਼ ਕਮਾਡਾਂ ਭੇਜੋ",
-        "Description[pl]": "Wysyłaj polecenie głosowe do swojego TV, używając Dużego Ekranu Plazmy",
-        "Description[pt]": "Enviar comandos de voz para a sua TV com o Plasma para Ecrãs Grandes",
-        "Description[pt_BR]": "Envie comandos de voz para sua TV rodando Plasma Bigscreen",
-        "Description[ro]": "Trimite comenzi vocale spre televizorul ce rulează Plasma Bigscreen",
-        "Description[ru]": "Передача голосовых команд на телевизор под управлением Plasma Bigscreen",
-        "Description[sa]": "Plasma Bigscreen चालयन्तं स्वस्य टीवीं प्रति स्वर-आदेशं प्रेषयन्तु",
-        "Description[sl]": "Pošljite glasovne ukaze vašemu televizorju, kjer teče Plasma Bigscreen",
-        "Description[sv]": "Skicka röstkommandon till en tv-apparat som kör Plasma storbildsskärm",
-        "Description[ta]": "பிளாஸ்மா பெருந்திரையைப் பயன்படுத்தும் தொலைக்காட்சிக்கு குரல்வழி கட்டளைகளை அனுப்பும்",
-        "Description[tr]": "Plasma Büyük ekran kullanan televizyonlara ses komutları gönder",
-        "Description[uk]": "Надсилання голосових команд вашому телевізору, де запущено Plasma Bigscreen",
-        "Description[zh_CN]": "发送语音命令给运行 Plasma Bigscreen 的电视机",
-        "Description[zh_TW]": "傳送人聲指令到您執行 Plasma 大螢幕的電視",
-        "EnabledByDefault": true,
-        "Icon": "tvtrusted",
-        "License": "GPL",
-        "Name": "Bigscreen voice control",
-        "Name[ar]": "التحكم الصوتي للشاشة الكبيرة",
-        "Name[az]": "Böyük Ekran səs ilə idarəetmə",
-        "Name[bg]": "Bigscreen управление на гласа",
-        "Name[ca@valencia]": "Control de veu de la Bigscreen",
-        "Name[ca]": "Control de veu de la Bigscreen",
-        "Name[cs]": "Hlasové ovládání pro Bigscreen",
-        "Name[da]": "Plugin til stemmekontrol",
-        "Name[de]": "Bigscreen-Sprachsteuerung",
-        "Name[en_GB]": "Bigscreen voice control",
-        "Name[eo]": "Grandekrana pervoĉa stiro",
-        "Name[es]": "Control de voz de Bigscreen",
-        "Name[eu]": "Bigscreen ahots-kontrola",
-        "Name[fi]": "Bigscreen-äänen hallinta",
-        "Name[fr]": "Contrôle vocal pour Bigscreen",
-        "Name[gl]": "Control de voz de Bigscreen",
-        "Name[he]": "שליטה קולית ב־Bigscreen",
-        "Name[hi]": "बड़ीस्क्रीन आवाज नियंत्रण",
-        "Name[hu]": "Bigscreen hangvezérlés",
-        "Name[ia]": "Controlo de voce de BigScreen",
-        "Name[is]": "Bigscreen-raddstýring",
-        "Name[it]": "Controllo vocale di Bigscreen",
-        "Name[ja]": "Bigscreen ボイスコントロール",
-        "Name[ka]": "Bigscreen-ის ხმოვანი კონტროლი",
-        "Name[ko]": "큰 화면 음성 제어",
-        "Name[lt]": "Bigscreen valdymas balsu",
-        "Name[lv]": "Lielekrāna balss kontrole",
-        "Name[nl]": "Bigscreen stembesturing",
-        "Name[nn]": "Bigscreen-stemmestyring",
-        "Name[pa]": "ਬਿਗ-ਸਕਰੀਨ ਆਵਾਜ਼ ਕੰਟਰੋਲ",
-        "Name[pl]": "Sterowanie głosowe Dużym Ekranem",
-        "Name[pt]": "Comando por voz do Ecrã Grande",
-        "Name[pt_BR]": "Plugin para controle de voz do Bigscreen",
-        "Name[ro]": "Control vocal pentru ecranul mare",
-        "Name[ru]": "Голосовое управление Bigscreen",
-        "Name[sa]": "बिगस्क्रीन् स्वरनियन्त्रणम्",
-        "Name[sl]": "Glasovni nadzor velikega zaslona",
-        "Name[sv]": "Röstkontroll av storskärm",
-        "Name[ta]": "பெருந்திரை குரல்வழி கட்டுப்பாடு",
-        "Name[tr]": "Büyük Ekran sesle denetim",
-        "Name[uk]": "Голосове керування Bigscreen",
-        "Name[zh_CN]": "Bigscreen 语音控制",
-        "Name[zh_TW]": "大螢幕人聲控制"
-    },
-    "X-KdeConnect-OutgoingPacketType": [
-        "kdeconnect.mousepad.request",
-        "kdeconnect.bigscreen.stt"
-    ],
-    "X-KdeConnect-SupportedDeviceTypes": [
-        "tv"
-    ],
-    "X-KdeConnect-SupportedPacketType": [
-        "kdeconnect.bigscreen.stt"
-    ]
-}