mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2026-09-22 09:34:56 +02:00
wifi: iwlwifi: mvm: fix read in wake packet notification handler
[ Upstream commit9d7657aae8] In iwl_mvm_wowlan_store_wake_pkt(), packet_len was initialized from notif->wake_packet_length before the explicit check that len >= sizeof(*notif). Move the assignment of packet_len to after the size check so that notif->wake_packet_length is only accessed once the payload length has been validated. Fixes:219ed58fed("wifi: iwlwifi: mvm: Add support for wowlan wake packet notification") Signed-off-by: Shahar Tzarfati <shahar.tzarfati@intel.com> Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com> Link: https://patch.msgid.link/20260715215523.99d5cf85a528.Ic4aa736011d4fe88e0cd19723d1d48bb24642198@changeid Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
dafd46a720
commit
0a070d5ad7
@@ -2812,7 +2812,7 @@ static int iwl_mvm_wowlan_store_wake_pkt(struct iwl_mvm *mvm,
|
||||
struct iwl_wowlan_status_data *status,
|
||||
u32 len)
|
||||
{
|
||||
u32 data_size, packet_len = le32_to_cpu(notif->wake_packet_length);
|
||||
u32 data_size, packet_len;
|
||||
|
||||
if (len < sizeof(*notif)) {
|
||||
IWL_ERR(mvm, "Invalid WoWLAN wake packet notification!\n");
|
||||
@@ -2831,6 +2831,7 @@ static int iwl_mvm_wowlan_store_wake_pkt(struct iwl_mvm *mvm,
|
||||
return -EIO;
|
||||
}
|
||||
|
||||
packet_len = le32_to_cpu(notif->wake_packet_length);
|
||||
data_size = len - offsetof(struct iwl_wowlan_wake_pkt_notif, wake_packet);
|
||||
|
||||
/* data_size got the padding from the notification, remove it. */
|
||||
|
||||
Reference in New Issue
Block a user