averello/linux-stable-mirror
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2026-05-05 09:57:21 +02:00
Code Issues Packages Projects Releases Wiki Activity

selftests: fib_nexthops: test stale has_v4 on nexthop replace

Browse Source 
Add test cases that exercise the scenario where an IPv6 nexthop is
replaced with an IPv4 nexthop while being part of a group. The group's
has_v4 flag must be updated so that subsequent IPv6 route additions are
properly rejected.

Two cases are covered:
  1. Gateway nexthop replaced across families with an existing IPv6
     route on the group (rejected by fib6_check_nh_list).
  2. Blackhole nexthop replaced across families with no existing IPv6
     route on the group (fib6_check_nh_list returns early) — this is
     the path that triggers a NULL ptr deref without the kernel fix.

Signed-off-by: Jiayuan Chen <jiayuan.chen@linux.dev>
Reviewed-by: David Ahern <dsahern@kernel.org>
Link: https://patch.msgid.link/20260413114522.147784-2-jiayuan.chen@linux.dev
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
This commit is contained in:
Jiayuan Chen
2026-04-13 19:45:20 +08:00
committed by Paolo Abeni
parent 29c95185ba
commit 104f082f5e
1 changed files with 22 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/testing/selftests/net/fib_nexthops.sh
+22
View File
@@ -1209,6 +1209,28 @@ ipv6_fcnal_runtime()
run_cmd "$IP ro replace 2001:db8:101::1/128 nhid 124"
log_test $? 0 "IPv6 route using a group after replacing v4 gateways"
# Replacing an IPv6 nexthop with an IPv4 nexthop should update has_v4
# for all groups using it, preventing IPv6 routes from referencing the
# group after the replace.
run_cmd "$IP nexthop add id 89 via 2001:db8:91::2 dev veth1"
run_cmd "$IP nexthop add id 125 group 89"
run_cmd "$IP nexthop replace id 89 via 172.16.1.1 dev veth1"
run_cmd "$IP ro replace 2001:db8:101::1/128 nhid 125"
log_test $? 2 "IPv6 route can not use group after v6 nexthop replaced by v4"
# Same scenario but with a blackhole nexthop: the group has no IPv6
# routes yet when the replace happens, so fib6_check_nh_list returns
# early without checking. has_v4 must still be updated to block
# subsequent IPv6 route additions.
run_cmd "$IP nexthop flush >/dev/null 2>&1"
run_cmd "$IP -6 nexthop add id 90 blackhole"
run_cmd "$IP nexthop add id 125 group 90"
run_cmd "$IP nexthop replace id 90 blackhole"
run_cmd "$IP -6 ro add 2001:db8:101::1/128 nhid 125"
log_test $? 2 "IPv6 route reject v6 blackhole replaced by v4 blackhole"
run_cmd "ip netns exec $me ping -6 2001:db8:101::1 -c1 -w$PING_TIMEOUT"
log_test $? 2 "Ping unreachable after rejected route"
$IP nexthop flush >/dev/null 2>&1
#