rxrpc: Disable IRQ, not BH, to take the lock for ->attend_link

commit d920270a6d upstream.

Use spin_lock_irq(), not spin_lock_bh() to take the lock when accessing the
->attend_link() to stop a delay in the I/O thread due to an interrupt being
taken in the app thread whilst that holds the lock and vice versa.

Fixes: a2ea9a9072 ("rxrpc: Use irq-disabling spinlocks between app and I/O thread")
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
Link: https://patch.msgid.link/2870146.1734037095@warthog.procyon.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
David Howells
2026-08-03 11:15:40 +02:00
committed by Greg Kroah-Hartman
parent 410f8e562e
commit 299e2a6eb5
+4 -4
View File
@@ -423,9 +423,9 @@ int rxrpc_io_thread(void *data)
struct rxrpc_connection,
attend_link);
if (conn) {
spin_lock_bh(&local->lock);
spin_lock_irq(&local->lock);
list_del_init(&conn->attend_link);
spin_unlock_bh(&local->lock);
spin_unlock_irq(&local->lock);
rxrpc_input_conn_event(conn, NULL);
rxrpc_put_connection(conn, rxrpc_conn_put_poke);
@@ -440,9 +440,9 @@ int rxrpc_io_thread(void *data)
if ((call = list_first_entry_or_null(&local->call_attend_q,
struct rxrpc_call,
attend_link))) {
spin_lock_bh(&local->lock);
spin_lock_irq(&local->lock);
list_del_init(&call->attend_link);
spin_unlock_bh(&local->lock);
spin_unlock_irq(&local->lock);
trace_rxrpc_call_poked(call);
rxrpc_input_call_event(call, NULL);