igbvf: Fix leak in TX DMA error cleanup

mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2026-09-22 09:34:56 +02:00

commit 0565052b7e upstream.

If an error is encountered while mapping TX buffers, the driver should
unmap any buffers already mapped for that skb.

Because count is incremented before each frag mapping, it will always
match the correct number of unmappings needed when dma_error is reached.
Decrementing count before the while loop in dma_error causes an
off-by-one error. If any mapping was successful before an unsuccessful
mapping, exactly one DMA mapping (the head) would leak.

This bug was introduced by a 2010 fix for an endless loop in dma_error.
All other affected drivers have already been fixed.

Fixes: c1fa347f20 ("e1000/e1000e/igb/igbvf/ixgb/ixgbe: Fix tests of unsigned in *_tx_map()")
Cc: stable@vger.kernel.org
Assisted-by: Claude:claude-4-7-opus
Signed-off-by: Matt Vollrath <tactii@gmail.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This commit is contained in:

Matt Vollrath

2026-08-09 20:21:53 +02:00

committed by

Greg Kroah-Hartman

parent 5c477b7a20

commit 31089f4eab

1 changed files with 0 additions and 2 deletions

									
										drivers/net/ethernet/intel/igbvf/netdev.c
									
		-2
	
												View File
												
				@@ -2201,8 +2201,6 @@ dma_error:

					buffer_info->time_stamp = 0;

					buffer_info->length = 0;

					buffer_info->mapped_as_page = false;

					if (count)

						count--;

					/* clear timestamp and dma mappings for remaining portion of packet */

					while (count--) {