mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2026-09-22 09:34:56 +02:00
reset: sunxi: fix memory region leak on ioremap failure
commit1a8c89f8c1upstream. In sunxi_reset_init(), when ioremap() fails, the memory region obtained via request_mem_region() is not released, leading to a resource leak. Add an err_mem_region label to properly release the memory region before freeing the data structure. Fixes:8f1ae77f46("reset: Add Allwinner SoCs Reset Controller Driver") Cc: stable@vger.kernel.org Signed-off-by: Zhao Dongdong <zhaodongdong@kylinos.cn> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
ac6ac3d35b
commit
6dc0c8cd9c
@@ -44,7 +44,7 @@ static int sunxi_reset_init(struct device_node *np)
|
||||
data->membase = ioremap(res.start, size);
|
||||
if (!data->membase) {
|
||||
ret = -ENOMEM;
|
||||
goto err_alloc;
|
||||
goto err_mem_region;
|
||||
}
|
||||
|
||||
spin_lock_init(&data->lock);
|
||||
@@ -57,6 +57,8 @@ static int sunxi_reset_init(struct device_node *np)
|
||||
|
||||
return reset_controller_register(&data->rcdev);
|
||||
|
||||
err_mem_region:
|
||||
release_mem_region(res.start, size);
|
||||
err_alloc:
|
||||
kfree(data);
|
||||
return ret;
|
||||
|
||||
Reference in New Issue
Block a user