mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2026-09-22 09:34:56 +02:00
sched_ext: Use rcu_access_pointer() for the first_task comparison
dsq->first_task is __rcu for the lockless scx_bpf_dsq_peek(). The task removal path compares it against the departing task with a plain load, which sparse flags. The comparison runs under the dsq lock and only tests identity, so rcu_access_pointer() is the fit. Signed-off-by: Tejun Heo <tj@kernel.org>
This commit is contained in:
@@ -1654,7 +1654,7 @@ static void task_unlink_from_dsq(struct task_struct *p,
|
||||
list_del_init(&p->scx.dsq_list.node);
|
||||
dsq_dec_nr(dsq, p);
|
||||
|
||||
if (!(dsq->id & SCX_DSQ_FLAG_BUILTIN) && dsq->first_task == p) {
|
||||
if (!(dsq->id & SCX_DSQ_FLAG_BUILTIN) && rcu_access_pointer(dsq->first_task) == p) {
|
||||
struct task_struct *first_task;
|
||||
|
||||
first_task = nldsq_next_task(dsq, NULL, false);
|
||||
|
||||
Reference in New Issue
Block a user