mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2026-04-03 12:05:13 +02:00
fjes: Add missing iounmap in fjes_hw_init()
commit15ef641a0cupstream. In error paths, add fjes_hw_iounmap() to release the resource acquired by fjes_hw_iomap(). Add a goto label to do so. Fixes:8cdc3f6c5d("fjes: Hardware initialization routine") Cc: stable@vger.kernel.org Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn> Signed-off-by: Simon Horman <horms@kernel.org> Reviewed-by: Simon Horman <horms@kernel.org> Link: https://patch.msgid.link/20251211073756.101824-1-lihaoxiang@isrc.iscas.ac.cn Signed-off-by: Paolo Abeni <pabeni@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
26c8bebc2f
commit
73feae0c71
@@ -334,7 +334,7 @@ int fjes_hw_init(struct fjes_hw *hw)
|
||||
|
||||
ret = fjes_hw_reset(hw);
|
||||
if (ret)
|
||||
return ret;
|
||||
goto err_iounmap;
|
||||
|
||||
fjes_hw_set_irqmask(hw, REG_ICTL_MASK_ALL, true);
|
||||
|
||||
@@ -347,8 +347,10 @@ int fjes_hw_init(struct fjes_hw *hw)
|
||||
hw->max_epid = fjes_hw_get_max_epid(hw);
|
||||
hw->my_epid = fjes_hw_get_my_epid(hw);
|
||||
|
||||
if ((hw->max_epid == 0) || (hw->my_epid >= hw->max_epid))
|
||||
return -ENXIO;
|
||||
if ((hw->max_epid == 0) || (hw->my_epid >= hw->max_epid)) {
|
||||
ret = -ENXIO;
|
||||
goto err_iounmap;
|
||||
}
|
||||
|
||||
ret = fjes_hw_setup(hw);
|
||||
|
||||
@@ -356,6 +358,10 @@ int fjes_hw_init(struct fjes_hw *hw)
|
||||
hw->hw_info.trace_size = FJES_DEBUG_BUFFER_SIZE;
|
||||
|
||||
return ret;
|
||||
|
||||
err_iounmap:
|
||||
fjes_hw_iounmap(hw);
|
||||
return ret;
|
||||
}
|
||||
|
||||
void fjes_hw_exit(struct fjes_hw *hw)
|
||||
|
||||
Reference in New Issue
Block a user