mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2026-07-25 16:19:48 +02:00
scsi: sim710: Fix resource leak by adding missing ioport_unmap() calls
[ Upstream commitacd194d9b5] The driver calls ioport_map() to map I/O ports in sim710_probe_common() but never calls ioport_unmap() to release the mapping. This causes resource leaks in both the error path when request_irq() fails and in the normal device removal path via sim710_device_remove(). Add ioport_unmap() calls in the out_release error path and in sim710_device_remove(). Fixes:56fece2008("[PATCH] finally fix 53c700 to use the generic iomem infrastructure") Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn> Link: https://patch.msgid.link/20251029032555.1476-1-vulab@iscas.ac.cn Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
39c754efb3
commit
796037ca2f
@@ -133,6 +133,7 @@ static int sim710_probe_common(struct device *dev, unsigned long base_addr,
|
||||
out_put_host:
|
||||
scsi_host_put(host);
|
||||
out_release:
|
||||
ioport_unmap(hostdata->base);
|
||||
release_region(base_addr, 64);
|
||||
out_free:
|
||||
kfree(hostdata);
|
||||
@@ -148,6 +149,7 @@ static int sim710_device_remove(struct device *dev)
|
||||
|
||||
scsi_remove_host(host);
|
||||
NCR_700_release(host);
|
||||
ioport_unmap(hostdata->base);
|
||||
kfree(hostdata);
|
||||
free_irq(host->irq, host);
|
||||
release_region(host->base, 64);
|
||||
|
||||
Reference in New Issue
Block a user