averello/linux-stable-mirror
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2026-09-22 09:34:56 +02:00
Code Issues Packages Projects Releases Wiki Activity

xfs: remove file_path tracepoint data

Browse Source 
commit e31c53a806 upstream.

The xfile/xmbuf shmem file descriptions are no longer as detailed as
they were when online fsck was first merged, because moving to static
strings in commit 60382993a2 ("xfs: get rid of the
xchk_xfile_*_descr calls") removed a memory allocation and hence a
source of failure.

However this makes encoding the description in the tracepoints sort of a
waste of memory.  David Laight also points out that file_path doesn't
zero the whole buffer which causes exposure of stale trace bytes, and
Steven Rostedt wonders why we're not using a dynamic array for the file
path.

I don't think this is worth fixing, so let's just rip it out.

Cc: rostedt@goodmis.org
Cc: david.laight.linux@gmail.com
Link: https://lore.kernel.org/linux-xfs/20260323172204.work.979-kees@kernel.org/
Cc: stable@vger.kernel.org # v6.11
Fixes: 19ebc8f84e ("xfs: fix file_path handling in tracepoints")
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Carlos Maiolino <cem@kernel.org>
[ Karl Mehltretter: Omit the xmbuf_create hunk because that tracepoint
  is not in 6.6.y.  The xfile_create hunk applies unchanged.  This drops
  dynamically generated descriptions because 60382993a2 is not in
  6.6.y, but fixes the stale-byte exposure and matches newer stable
  kernels. ]
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Darrick J. Wong
2026-09-02 14:29:19 +02:00
committed by Greg Kroah-Hartman
parent b5181516a9
commit 95f90c6029
1 changed files with 2 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fs/xfs/scrub/trace.h
+2 -10
View File
@@ -784,20 +784,12 @@ TRACE_EVENT(xfile_create,
TP_STRUCT__entry(
__field(dev_t, dev)
__field(unsigned long, ino)
__array(char, pathname, MAXNAMELEN)
),
TP_fast_assign(
char *path;
__entry->ino = file_inode(xf->file)->i_ino;
path = file_path(xf->file, __entry->pathname, MAXNAMELEN);
if (IS_ERR(path))
strncpy(__entry->pathname, "(unknown)",
sizeof(__entry->pathname));
),
TP_printk("xfino 0x%lx path '%s'",
__entry->ino,
__entry->pathname)
TP_printk("xfino 0x%lx",
__entry->ino)
);
TRACE_EVENT(xfile_destroy,