averello/linux-stable-mirror
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2026-09-22 09:34:56 +02:00
Code Issues Packages Projects Releases Wiki Activity

mm/damon/core: reduce range setup in damon_commit_target_regions()

Browse Source 
damon_commit_target_regions() calls damon_set_regions() for updating the
destination target's monitoring target region boundaries.  It sets the
boundaries same to source target's monitoring regions, even if they are
adjacent.  Meanwhile, damon_set_region() sets the destination target
regions exactly the same to the source, only when the target regions are
empty.  When there are existing target regions, only a few regions are
expanded or shrunk to fit on only the boundaries for disjoint regions in
the source.  Hence the adjacent source ranges mean nothing in common
cases.  When there are many regions, such adjacent range setup is only a
waste of time and space.  We recently found [1] it is actually causing
memory overhead.  Setup the ranges for only distinct ranges.

Link: https://lore.kernel.org/20260630141726.92246-9-sj@kernel.org
Link: https://lore.kernel.org/20260603112306.58490-1-akinobu.mita@gmail.com [1]
Signed-off-by: SJ Park <sj@kernel.org>
Cc: Brendan Higgins <brendan.higgins@linux.dev>
Cc: David Hildenbrand <david@kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Liam R. Howlett <liam@infradead.org>
Cc: Lorenzo Stoakes <ljs@kernel.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: Vlastimil Babka <vbabka@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
SJ Park
2026-07-30 19:40:27 -07:00
committed by Andrew Morton
parent 8fa52376da
commit 97ae89aa9f
1 changed files with 17 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mm/damon/core.c
+17 -5
View File
@@ -1360,21 +1360,33 @@ static struct damon_target *damon_nth_target(int n, struct damon_ctx *ctx)
static int damon_commit_target_regions(struct damon_target *dst,
struct damon_target *src, unsigned long src_min_region_sz)
{
struct damon_region *src_region;
struct damon_region *src_region, *prev = NULL;
struct damon_addr_range *ranges;
int i = 0, err;
damon_for_each_region(src_region, src)
i++;
damon_for_each_region(src_region, src) {
if (!prev || prev->ar.end != src_region->ar.start)
i++;
prev = src_region;
}
if (!i)
return 0;
ranges = kvmalloc_objs(*ranges, i, GFP_KERNEL | __GFP_NOWARN);
if (!ranges)
return -ENOMEM;
prev = NULL;
i = 0;
damon_for_each_region(src_region, src)
ranges[i++] = src_region->ar;
damon_for_each_region(src_region, src) {
if (!prev) {
ranges[i].start = src_region->ar.start;
} else if (prev->ar.end != src_region->ar.start) {
ranges[i++].end = prev->ar.end;
ranges[i].start = src_region->ar.start;
}
prev = src_region;
}
ranges[i++].end = damon_last_region(src)->ar.end;
err = damon_set_regions(dst, ranges, i, src_min_region_sz);
kvfree(ranges);
return err;