mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2026-09-22 09:34:56 +02:00
gpu: host1x: Fix use-after-free in host1x_bo_clear_cached_mappings
[ Upstream commit 266cddf7bd ]
__host1x_bo_unpin() drops the last reference to the mapping and frees
it, so we can't dereference mapping afterwards. The cache itself
outlives the mapping, so use the cache local variable instead.
Reported-by: Dan Carpenter <error27@gmail.com>
Closes: https://lore.kernel.org/linux-tegra/ah6ErK6f4kVudVIA@stanley.mountain/T/#u
Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Link: https://patch.msgid.link/20260603-host1x-bocache-leak-fix-v1-1-494101dbfd30@nvidia.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
5592a207e1
commit
abeff53233
@@ -1006,10 +1006,10 @@ void host1x_bo_clear_cached_mappings(struct host1x_bo *bo)
|
||||
if (WARN_ON(!cache))
|
||||
continue;
|
||||
|
||||
mutex_lock(&mapping->cache->lock);
|
||||
mutex_lock(&cache->lock);
|
||||
WARN_ON(kref_read(&mapping->ref) != 1);
|
||||
__host1x_bo_unpin(&mapping->ref);
|
||||
mutex_unlock(&mapping->cache->lock);
|
||||
mutex_unlock(&cache->lock);
|
||||
}
|
||||
}
|
||||
EXPORT_SYMBOL(host1x_bo_clear_cached_mappings);
|
||||
|
||||
Reference in New Issue
Block a user