mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2026-04-29 12:28:27 +02:00
sched/deadline: Fix accounting after global limits change
[ Upstream commit 440989c10f ]
A global limits change (sched_rt_handler() logic) currently leaves stale
and/or incorrect values in variables related to accounting (e.g.
extra_bw).
Properly clean up per runqueue variables before implementing the change
and rebuild scheduling domains (so that accounting is also properly
restored) after such a change is complete.
Reported-by: Marcel Ziswiler <marcel.ziswiler@codethink.co.uk>
Signed-off-by: Juri Lelli <juri.lelli@redhat.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: Marcel Ziswiler <marcel.ziswiler@codethink.co.uk> # nuc & rock5b
Link: https://lore.kernel.org/r/20250627115118.438797-4-juri.lelli@redhat.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
037d856072
commit
ac31ba7430
@@ -2661,6 +2661,9 @@ void sched_dl_do_global(void)
|
||||
if (global_rt_runtime() != RUNTIME_INF)
|
||||
new_bw = to_ratio(global_rt_period(), global_rt_runtime());
|
||||
|
||||
for_each_possible_cpu(cpu)
|
||||
init_dl_rq_bw_ratio(&cpu_rq(cpu)->dl);
|
||||
|
||||
for_each_possible_cpu(cpu) {
|
||||
rcu_read_lock_sched();
|
||||
|
||||
@@ -2676,7 +2679,6 @@ void sched_dl_do_global(void)
|
||||
raw_spin_unlock_irqrestore(&dl_b->lock, flags);
|
||||
|
||||
rcu_read_unlock_sched();
|
||||
init_dl_rq_bw_ratio(&cpu_rq(cpu)->dl);
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -2861,6 +2861,12 @@ undo:
|
||||
}
|
||||
mutex_unlock(&mutex);
|
||||
|
||||
/*
|
||||
* After changing maximum available bandwidth for DEADLINE, we need to
|
||||
* recompute per root domain and per cpus variables accordingly.
|
||||
*/
|
||||
rebuild_sched_domains();
|
||||
|
||||
return ret;
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user