mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2026-09-22 09:34:56 +02:00
tls: device: push pending open record on splice EOF
[ Upstream commiteaa39f9f8a] On kTLS device-offload sockets, sendfile() with count > EOF can reach ->splice_eof() with a fully assembled but still-open TLS record left pending. tls_device_splice_eof() only flushes partially sent records, so an abrupt close() can drop the final record and the peer receives a short file. Fix tls_device_splice_eof() to also push pending open records. This matches the software path, where splice EOF already flushes pending open records. Fixes:d4c1e80b0d("tls/device: Use splice_eof() to flush") Link: https://lore.kernel.org/netdev/CAMPsyauZ+jzG9AysO0FWv6ZY0kvCUpjX_U7o=oOjCuOQ87BCgg@mail.gmail.com/ Reported-by: Nils Juenemann <nils.juenemann@gmail.com> Signed-off-by: Rishikesh Jethwani <rjethwani@purestorage.com> Tested-by: Nils Juenemann <nils.juenemann@gmail.com> Link: https://patch.msgid.link/20260709224436.1608993-2-rjethwani@purestorage.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
b255d8cd6c
commit
def321ca6b
@@ -600,13 +600,15 @@ void tls_device_splice_eof(struct socket *sock)
|
||||
struct tls_context *tls_ctx = tls_get_ctx(sk);
|
||||
struct iov_iter iter = {};
|
||||
|
||||
if (!tls_is_partially_sent_record(tls_ctx))
|
||||
if (!tls_is_partially_sent_record(tls_ctx) &&
|
||||
!tls_is_pending_open_record(tls_ctx))
|
||||
return;
|
||||
|
||||
mutex_lock(&tls_ctx->tx_lock);
|
||||
lock_sock(sk);
|
||||
|
||||
if (tls_is_partially_sent_record(tls_ctx)) {
|
||||
if (tls_is_partially_sent_record(tls_ctx) ||
|
||||
tls_is_pending_open_record(tls_ctx)) {
|
||||
iov_iter_bvec(&iter, ITER_SOURCE, NULL, 0, 0);
|
||||
tls_push_data(sk, &iter, 0, 0, TLS_RECORD_TYPE_DATA);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user