Input: ims-pcu - fix potential infinite loop in CDC union descriptor parsing

commit d4579af29e upstream.

The driver parses CDC union descriptors in ims_pcu_get_cdc_union_desc()
by iterating through the extra descriptor data. However, it does not
verify that the bLength of each descriptor is at least 2. A malicious
device could provide a descriptor with bLength = 0, leading to an
infinite loop in the driver.

Add a check to ensure bLength is at least 2 before proceeding with
parsing.

Fixes: 628329d524 (Input: add IMS Passenger Control Unit driver)
Cc: stable@vger.kernel.org
Assisted-by: Gemini:gemini-3.1-pro
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dmitry Torokhov
2026-07-24 16:03:41 +02:00
committed by Greg Kroah-Hartman
parent 3fd7c0ace2
commit e3f93d63dc
+3 -2
View File
@@ -1675,8 +1675,9 @@ ims_pcu_get_cdc_union_desc(struct usb_interface *intf)
while (buflen >= sizeof(*union_desc)) {
union_desc = (struct usb_cdc_union_desc *)buf;
if (union_desc->bLength > buflen) {
dev_err(&intf->dev, "Too large descriptor\n");
if (union_desc->bLength < 2 || union_desc->bLength > buflen) {
dev_err(&intf->dev, "Invalid descriptor length: %d\n",
union_desc->bLength);
return NULL;
}